* [PATCH v1] eventdev/eth_rx: sub event type gets reset @ 2022-09-13 7:02 Ganapati Kundapura 2022-09-13 17:02 ` Jayatheerthan, Jay 2022-09-14 6:20 ` [PATCH v2] " Ganapati Kundapura 0 siblings, 2 replies; 5+ messages in thread From: Ganapati Kundapura @ 2022-09-13 7:02 UTC (permalink / raw) To: dev, jerinj; +Cc: jay.jayatheerthan, s.v.naga.harish.k In rte_event_eth_rx_adapter_queue_add(), sub_event_type of rte_event structure is reset which is used by the application to determine the processing function. Removed resetting of rte_event::sub_event_type Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 64a6add..e42e41c 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter *rx_adapter, qi_ev->event = ev->event; qi_ev->op = RTE_EVENT_OP_NEW; qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; - qi_ev->sub_event_type = 0; if (conf->rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { -- 2.6.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset 2022-09-13 7:02 [PATCH v1] eventdev/eth_rx: sub event type gets reset Ganapati Kundapura @ 2022-09-13 17:02 ` Jayatheerthan, Jay 2022-09-14 6:22 ` Kundapura, Ganapati 2022-09-14 6:20 ` [PATCH v2] " Ganapati Kundapura 1 sibling, 1 reply; 5+ messages in thread From: Jayatheerthan, Jay @ 2022-09-13 17:02 UTC (permalink / raw) To: Kundapura, Ganapati, dev, jerinj; +Cc: Naga Harish K, S V > -----Original Message----- > From: Kundapura, Ganapati <ganapati.kundapura@intel.com> > Sent: Tuesday, September 13, 2022 12:32 PM > To: dev@dpdk.org; jerinj@marvell.com > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S V <s.v.naga.harish.k@intel.com> > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of > rte_event structure is reset which is used by the application Just a minor comment - application may or may not use this field. "which can be used" is better suited. Rest looks good. Thanks for posting. With this change, Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com> > to determine the processing function. > > Removed resetting of rte_event::sub_event_type > > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com> > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > index 64a6add..e42e41c 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter *rx_adapter, > qi_ev->event = ev->event; > qi_ev->op = RTE_EVENT_OP_NEW; > qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; > - qi_ev->sub_event_type = 0; > > if (conf->rx_queue_flags & > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { > -- > 2.6.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset 2022-09-13 17:02 ` Jayatheerthan, Jay @ 2022-09-14 6:22 ` Kundapura, Ganapati 2022-09-14 13:42 ` Jerin Jacob 0 siblings, 1 reply; 5+ messages in thread From: Kundapura, Ganapati @ 2022-09-14 6:22 UTC (permalink / raw) To: Jayatheerthan, Jay, dev, jerinj; +Cc: Naga Harish K, S V Hi Jay, > -----Original Message----- > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com> > Sent: 13 September 2022 22:32 > To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; dev@dpdk.org; > jerinj@marvell.com > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > > -----Original Message----- > > From: Kundapura, Ganapati <ganapati.kundapura@intel.com> > > Sent: Tuesday, September 13, 2022 12:32 PM > > To: dev@dpdk.org; jerinj@marvell.com > > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S > > V <s.v.naga.harish.k@intel.com> > > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > > > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of > rte_event > > structure is reset which is used by the application > > Just a minor comment - application may or may not use this field. "which can > be used" is better suited. Rest looks good. Thanks for posting. Updated commit message as suggested in V2 > > With this change, > Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com> > Added Ack with commit header change in V2 > > to determine the processing function. > > > > Removed resetting of rte_event::sub_event_type > > > > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com> > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > > b/lib/eventdev/rte_event_eth_rx_adapter.c > > index 64a6add..e42e41c 100644 > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter > *rx_adapter, > > qi_ev->event = ev->event; > > qi_ev->op = RTE_EVENT_OP_NEW; > > qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; > > - qi_ev->sub_event_type = 0; > > > > if (conf->rx_queue_flags & > > > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { > > -- > > 2.6.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] eventdev/eth_rx: sub event type gets reset 2022-09-14 6:22 ` Kundapura, Ganapati @ 2022-09-14 13:42 ` Jerin Jacob 0 siblings, 0 replies; 5+ messages in thread From: Jerin Jacob @ 2022-09-14 13:42 UTC (permalink / raw) To: Kundapura, Ganapati; +Cc: Jayatheerthan, Jay, dev, jerinj, Naga Harish K, S V On Wed, Sep 14, 2022 at 11:52 AM Kundapura, Ganapati <ganapati.kundapura@intel.com> wrote: > > Hi Jay, > > > -----Original Message----- > > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com> > > Sent: 13 September 2022 22:32 > > To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; dev@dpdk.org; > > jerinj@marvell.com > > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > > Subject: RE: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > > > > -----Original Message----- > > > From: Kundapura, Ganapati <ganapati.kundapura@intel.com> > > > Sent: Tuesday, September 13, 2022 12:32 PM > > > To: dev@dpdk.org; jerinj@marvell.com > > > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Naga Harish K, S > > > V <s.v.naga.harish.k@intel.com> > > > Subject: [PATCH v1] eventdev/eth_rx: sub event type gets reset > > > > > > In rte_event_eth_rx_adapter_queue_add(), sub_event_type of > > rte_event > > > structure is reset which is used by the application > > > > Just a minor comment - application may or may not use this field. "which can > > be used" is better suited. Rest looks good. Thanks for posting. > Updated commit message as suggested in V2 > > > > With this change, > > Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com> > > > Added Ack with commit header change in V2 Updated the git commit as follows and applied v2 to dpdk-next-net-eventdev/for-main. Thanks eventdev/eth_rx: remove resetting sub event type In rte_event_eth_rx_adapter_queue_add(), sub_event_type of rte_event structure is reset which can be used by the application to determine the processing function. Removed resetting of rte_event::sub_event_type Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com> Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com> > > > to determine the processing function. > > > > > > Removed resetting of rte_event::sub_event_type > > > > > > Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com> > > > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > > > b/lib/eventdev/rte_event_eth_rx_adapter.c > > > index 64a6add..e42e41c 100644 > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > > @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter > > *rx_adapter, > > > qi_ev->event = ev->event; > > > qi_ev->op = RTE_EVENT_OP_NEW; > > > qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; > > > - qi_ev->sub_event_type = 0; > > > > > > if (conf->rx_queue_flags & > > > > > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { > > > -- > > > 2.6.4 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] eventdev/eth_rx: sub event type gets reset 2022-09-13 7:02 [PATCH v1] eventdev/eth_rx: sub event type gets reset Ganapati Kundapura 2022-09-13 17:02 ` Jayatheerthan, Jay @ 2022-09-14 6:20 ` Ganapati Kundapura 1 sibling, 0 replies; 5+ messages in thread From: Ganapati Kundapura @ 2022-09-14 6:20 UTC (permalink / raw) To: dev, jerinj; +Cc: jay.jayatheerthan, s.v.naga.harish.k In rte_event_eth_rx_adapter_queue_add(), sub_event_type of rte_event structure is reset which can be used by the application to determine the processing function. Removed resetting of rte_event::sub_event_type Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com> Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 64a6add..e42e41c 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -2054,7 +2054,6 @@ rxa_add_queue(struct event_eth_rx_adapter *rx_adapter, qi_ev->event = ev->event; qi_ev->op = RTE_EVENT_OP_NEW; qi_ev->event_type = RTE_EVENT_TYPE_ETH_RX_ADAPTER; - qi_ev->sub_event_type = 0; if (conf->rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) { -- 2.6.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-14 13:42 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-13 7:02 [PATCH v1] eventdev/eth_rx: sub event type gets reset Ganapati Kundapura 2022-09-13 17:02 ` Jayatheerthan, Jay 2022-09-14 6:22 ` Kundapura, Ganapati 2022-09-14 13:42 ` Jerin Jacob 2022-09-14 6:20 ` [PATCH v2] " Ganapati Kundapura
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).