From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 86737A00C5;
	Wed, 14 Sep 2022 16:30:47 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 77BFF4021D;
	Wed, 14 Sep 2022 16:30:47 +0200 (CEST)
Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com
 [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id F04BF40156
 for <dev@dpdk.org>; Wed, 14 Sep 2022 16:30:46 +0200 (CEST)
Received: by mail-pj1-f46.google.com with SMTP id
 n23-20020a17090a091700b00202a51cc78bso12925323pjn.2
 for <dev@dpdk.org>; Wed, 14 Sep 2022 07:30:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date;
 bh=AqOvIeuGBkwI2Q+p4dboNArnJ91bM7ueOagc9+u03y8=;
 b=osdD/R3FQQauPQKxG+93i00ZULLoQUfSnY6ERdHcN7DHRy3cj4qPgNhreXeG8GYO+b
 rxWL+cAr8jn1PR+l7d9lRKUnOFTUsoa7aPqaaSIARAQpko3aURtZEBOJ90hjHTJxM+4g
 9pePvvSJudoArp8eZoBGZb68bHVGUTrKTLbD3UNk9S16okhtSx7qf1OKLJpE9SqJCpFH
 H9FqBPSlrIXo/2ICjJlrQOn03Zwi1TED/deqBJlAPhKcuk4evgky4g/P2ao9Mlhdm6Ap
 3FPvhSd1G+mp8P4kRTYCdLTrfe0gWKXjjvjF2MkwAFgKtrezb8vn/A+d57DitAeq1a8s
 w/eg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date;
 bh=AqOvIeuGBkwI2Q+p4dboNArnJ91bM7ueOagc9+u03y8=;
 b=ZPfEeaGdPsgaR6tA2tlUFyUDMztz2BaqT0L1uwKb/H35CCyE06g2njmi174zDuIYWM
 zjq1xpe8+dMTu6HnQghL2VPmk8rEO6LcPyWGv7isIm09NnfFegLXfCxxqpSGdN0tk3js
 GYQOVGVlWH7icNygSGdNkLKngK+ANFplfc43xcvdZitiS+LguFKe4Kml0PnMqHP6LBzN
 MEMXUtsFdA3Xlr30qRRWNMVIzWnOkHvHpkYMg1BzdRR0oX3wpKOEdEMQYR/MEFuC5tJy
 DPVMPr8iEnXhE+mGZ/44TMBR9G8Sq5DK5sDKjx/ZXNa/UC4NXyrexslArRPT5Bqn0sPg
 O0FQ==
X-Gm-Message-State: ACgBeo3Gd9xaxxU2WA8BpwJS5JBMpYsr0EFR/lBNmy/10EbAVY1kSxpQ
 /IhL/2Q7eCDTNFoEy1d8HR9afg==
X-Google-Smtp-Source: AA6agR7Vh626U6dVdy0jnwHn9cIr9iYXoob9BwFU2FON6O5mLV1n3AZnCSS94LN2/60NRuUmSUcHCQ==
X-Received: by 2002:a17:902:ccc7:b0:16c:484f:4c69 with SMTP id
 z7-20020a170902ccc700b0016c484f4c69mr38110110ple.118.1663165845682; 
 Wed, 14 Sep 2022 07:30:45 -0700 (PDT)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
 by smtp.gmail.com with ESMTPSA id
 i1-20020a17090332c100b00172bf229dfdsm10902333plr.97.2022.09.14.07.30.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 14 Sep 2022 07:30:45 -0700 (PDT)
Date: Wed, 14 Sep 2022 07:30:43 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, Conor Walsh
 <conor.walsh@intel.com>, David Hunt <david.hunt@intel.com>, Bruce
 Richardson <bruce.richardson@intel.com>, Nicolas Chautru
 <nicolas.chautru@intel.com>, Fan Zhang <roy.fan.zhang@intel.com>, Ashish
 Gupta <ashish.gupta@marvell.com>, Akhil Goyal <gakhil@marvell.com>,
 Chengwen Feng <fengchengwen@huawei.com>, Ray Kinsella <mdr@ashroe.eu>,
 Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit
 <ferruh.yigit@xilinx.com>, Andrew Rybchenko
 <andrew.rybchenko@oktetlabs.ru>, Jerin Jacob <jerinj@marvell.com>, Sachin
 Saxena <sachin.saxena@oss.nxp.com>, Hemant Agrawal
 <hemant.agrawal@nxp.com>, Ori Kam <orika@nvidia.com>, Honnappa Nagarahalli
 <honnappa.nagarahalli@arm.com>, Konstantin Ananyev
 <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry
Message-ID: <20220914073043.3d9e9df7@hermes.local>
In-Reply-To: <20220914092929.1159773-2-kevin.laatz@intel.com>
References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com>
 <20220914092929.1159773-1-kevin.laatz@intel.com>
 <20220914092929.1159773-2-kevin.laatz@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, 14 Sep 2022 10:29:26 +0100
Kevin Laatz <kevin.laatz@intel.com> wrote:

> +struct lcore_poll_telemetry {
> +	int poll_busyness;
> +	/**< Calculated poll busyness (gets set/returned by the API) */
> +	int raw_poll_busyness;
> +	/**< Calculated poll busyness times 100. */
> +	uint64_t interval_ts;
> +	/**< when previous telemetry interval started */
> +	uint64_t empty_cycles;
> +	/**< empty cycle count since last interval */
> +	uint64_t last_poll_ts;
> +	/**< last poll timestamp */
> +	bool last_empty;
> +	/**< if last poll was empty */
> +	unsigned int contig_poll_cnt;
> +	/**< contiguous (always empty/non empty) poll counter */
> +} __rte_cache_aligned;
> +

For api's always prefer to use fix size types.
Is there any reason the poll_busyness values could be negative.
If not please use unsigned types.