DPDK patches and discussions
 help / color / mirror / Atom feed
From: Brian Dooley <brian.dooley@intel.com>
To: Fan Zhang <roy.fan.zhang@intel.com>,
	Brian Dooley <brian.dooley@intel.com>
Cc: dev@dpdk.org, gmuthukrishn@marvell.com, gakhil@marvell.com,
	kai.ji@intel.com
Subject: [PATCH v3] examples/fips_validation: add parsing for AES GMAC
Date: Fri, 16 Sep 2022 08:59:43 +0000	[thread overview]
Message-ID: <20220916085943.21916-1-brian.dooley@intel.com> (raw)
In-Reply-To: <20220901103501.304471-1-brian.dooley@intel.com>

Added functionality to parse algorithm for AES GMAC test

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
Acked-by: Kai Ji <kai.ji@intel.com>
---
v2: add random internal iv generation
---
v3: in reply to fix and patchwork CI
---
 examples/fips_validation/fips_validation.c    |  2 ++
 examples/fips_validation/fips_validation.h    |  1 +
 .../fips_validation/fips_validation_gcm.c     | 13 ++++++------
 examples/fips_validation/main.c               | 21 +++++++++++++++++++
 4 files changed, 31 insertions(+), 6 deletions(-)

diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c
index 12b9b03f56..5c7ecce412 100644
--- a/examples/fips_validation/fips_validation.c
+++ b/examples/fips_validation/fips_validation.c
@@ -458,6 +458,8 @@ fips_test_parse_one_json_vector_set(void)
 	/* Vector sets contain the algorithm type, and nothing else we need. */
 	if (strstr(algo_str, "AES-GCM"))
 		info.algo = FIPS_TEST_ALGO_AES_GCM;
+	else if (strstr(algo_str, "AES-GMAC"))
+		info.algo = FIPS_TEST_ALGO_AES_GMAC;
 	else if (strstr(algo_str, "HMAC"))
 		info.algo = FIPS_TEST_ALGO_HMAC;
 	else if (strstr(algo_str, "CMAC"))
diff --git a/examples/fips_validation/fips_validation.h b/examples/fips_validation/fips_validation.h
index 5c1abcbd91..24edab68da 100644
--- a/examples/fips_validation/fips_validation.h
+++ b/examples/fips_validation/fips_validation.h
@@ -36,6 +36,7 @@ enum fips_test_algorithms {
 		FIPS_TEST_ALGO_AES = 0,
 		FIPS_TEST_ALGO_AES_CBC,
 		FIPS_TEST_ALGO_AES_GCM,
+		FIPS_TEST_ALGO_AES_GMAC,
 		FIPS_TEST_ALGO_AES_CMAC,
 		FIPS_TEST_ALGO_AES_CCM,
 		FIPS_TEST_ALGO_AES_XTS,
diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index 6b3d158629..7e1bd77faf 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -291,13 +291,14 @@ parse_test_gcm_json_writeback(struct fips_val *val)
 
 	if (info.op == FIPS_TEST_ENC_AUTH_GEN) {
 		json_t *ct;
+		if (!info.interim_info.gcm_data.is_gmac) {
+			tmp_val.val = val->val;
+			tmp_val.len = vec.pt.len;
 
-		tmp_val.val = val->val;
-		tmp_val.len = vec.pt.len;
-
-		writeback_hex_str("", info.one_line_text, &tmp_val);
-		ct = json_string(info.one_line_text);
-		json_object_set_new(json_info.json_write_case, CT_JSON_STR, ct);
+			writeback_hex_str("", info.one_line_text, &tmp_val);
+			ct = json_string(info.one_line_text);
+			json_object_set_new(json_info.json_write_case, CT_JSON_STR, ct);
+		}
 
 		if (info.interim_info.gcm_data.gen_iv) {
 			json_t *iv;
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index 8bd5a66889..9118ca4d92 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -669,6 +669,21 @@ prepare_auth_op(void)
 
 	__rte_crypto_op_reset(env.op, RTE_CRYPTO_OP_TYPE_SYMMETRIC);
 
+	if (info.interim_info.gcm_data.gen_iv == 1) {
+		uint32_t i;
+
+		if (!vec.iv.val) {
+			vec.iv.val = rte_malloc(0, vec.iv.len, 0);
+			if (!vec.iv.val)
+				return -ENOMEM;
+		}
+
+		for (i = 0; i < vec.iv.len; i++) {
+			int random = rand();
+			vec.iv.val[i] = (uint8_t)random;
+		}
+	}
+
 	if (vec.iv.len) {
 		uint8_t *iv = rte_crypto_op_ctod_offset(env.op, uint8_t *,
 				IV_OFF);
@@ -1817,6 +1832,11 @@ init_test_ops(void)
 		else
 			test_ops.test = fips_generic_test;
 		break;
+	case FIPS_TEST_ALGO_AES_GMAC:
+		test_ops.prepare_op = prepare_auth_op;
+		test_ops.prepare_xform = prepare_gmac_xform;
+		test_ops.test = fips_generic_test;
+		break;
 	case FIPS_TEST_ALGO_AES_GCM:
 		test_ops.prepare_op = prepare_aead_op;
 		test_ops.prepare_xform = prepare_gcm_xform;
@@ -1994,6 +2014,7 @@ fips_test_one_test_group(void)
 	json_object_set_new(json_info.json_write_group, "tests", write_tests);
 
 	switch (info.algo) {
+	case FIPS_TEST_ALGO_AES_GMAC:
 	case FIPS_TEST_ALGO_AES_GCM:
 		ret = parse_test_gcm_json_init();
 		break;
-- 
2.25.1


  parent reply	other threads:[~2022-09-16  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  9:46 [PATCH v1] " Brian Dooley
2022-09-01 10:35 ` [PATCH v2] " Brian Dooley
2022-09-15 13:20   ` Ji, Kai
2022-09-16  8:59   ` Brian Dooley [this message]
2022-09-16 17:06     ` [EXT] [PATCH v3] " Gowrishankar Muthukrishnan
2022-10-10 19:50     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220916085943.21916-1-brian.dooley@intel.com \
    --to=brian.dooley@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=gmuthukrishn@marvell.com \
    --cc=kai.ji@intel.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).