[PATCH 0/2] ethdev: add GTP PSC QFI field

[PATCH 0/2] ethdev: add GTP PSC QFI field

[Dariusz Sosnowski]

This patch series adds support for modifying GTP PSC QFI field using MODIFY_FIELD action.

Dariusz Sosnowski (2):
  ethdev: add GTP PSC QFI field
  app/testpmd: add GTP PSC QFI field support

 app/test-pmd/cmdline_flow.c | 2 +-
 lib/ethdev/rte_flow.h       | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.25.1

[PATCH 1/2] ethdev: add GTP PSC QFI field

[Dariusz Sosnowski]

This patch introduces a GTP PSC QFI field to MODIFY_FIELD flow action.

Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
 lib/ethdev/rte_flow.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index a79f1e7ef0..e64831f8f1 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -3689,6 +3689,7 @@ enum rte_flow_field_id {
 	RTE_FLOW_FIELD_VALUE,		/**< Immediate value. */
 	RTE_FLOW_FIELD_IPV4_ECN,	/**< IPv4 ECN. */
 	RTE_FLOW_FIELD_IPV6_ECN,	/**< IPv6 ECN. */
+	RTE_FLOW_FIELD_GTP_PSC_QFI,	/**< GTP QFI. */
 };
 
 /**
-- 
2.25.1

[PATCH 2/2] app/testpmd: add GTP PSC QFI field support

[Dariusz Sosnowski]

This patch adds support for specifying GTP PSC QFI field as a source or
destination of MODIFY_FIELD flow action in testpmd.

An example for copying GTP PSC QFI field using MODIFY_FIELD action:

    modify_field op set
                 dst_type meta
                 src_type gtp_psc_qfi
                 width 8

An example of setting GTP PSC QFI value to 0x1f using MODIFY_FIELD
action:

    modify_field op set
                 dst_type gtp_psc_qfi
                 src_type value src_value 1f
                 width 8

Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 7f50028eb7..b9673314b1 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -796,7 +796,7 @@ static const char *const modify_field_ids[] = {
 	"udp_port_src", "udp_port_dst",
 	"vxlan_vni", "geneve_vni", "gtp_teid",
 	"tag", "mark", "meta", "pointer", "value",
-	"ipv4_ecn", "ipv6_ecn", NULL
+	"ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", NULL
 };
 
 /** Maximum number of subsequent tokens and arguments on the stack. */
-- 
2.25.1

RE: [PATCH 1/2] ethdev: add GTP PSC QFI field

[Ori Kam]

Hi Dariusz,
Please merge the testpmd and this commit.
And you can add my ack.

> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Sent: Wednesday, 21 September 2022 13:19
> To: Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas Monjalon
> (EXTERNAL) <thomas@monjalon.net>; Ferruh Yigit
> <ferruh.yigit@xilinx.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Cc: dev@dpdk.org
> Subject: [PATCH 1/2] ethdev: add GTP PSC QFI field
> 
> This patch introduces a GTP PSC QFI field to MODIFY_FIELD flow action.
> 
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
>  lib/ethdev/rte_flow.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index a79f1e7ef0..e64831f8f1 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -3689,6 +3689,7 @@ enum rte_flow_field_id {
>  	RTE_FLOW_FIELD_VALUE,		/**< Immediate value. */
>  	RTE_FLOW_FIELD_IPV4_ECN,	/**< IPv4 ECN. */
>  	RTE_FLOW_FIELD_IPV6_ECN,	/**< IPv6 ECN. */
> +	RTE_FLOW_FIELD_GTP_PSC_QFI,	/**< GTP QFI. */
>  };
> 
>  /**
> --
> 2.25.1

Re: [PATCH 2/2] app/testpmd: add GTP PSC QFI field support

[Singh, Aman Deep]

On 9/21/2022 3:48 PM, Dariusz Sosnowski wrote:
> This patch adds support for specifying GTP PSC QFI field as a source or
> destination of MODIFY_FIELD flow action in testpmd.
>
> An example for copying GTP PSC QFI field using MODIFY_FIELD action:
>
>      modify_field op set
>                   dst_type meta
>                   src_type gtp_psc_qfi
>                   width 8
>
> An example of setting GTP PSC QFI value to 0x1f using MODIFY_FIELD
> action:
>
>      modify_field op set
>                   dst_type gtp_psc_qfi
>                   src_type value src_value 1f
>                   width 8
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Aman Singh<aman.deep.singh@intel.com>
> ---
>

[PATCH v2] ethdev: add GTP PSC QFI field

[Dariusz Sosnowski]

This patch introduces the GTP PSC QFI modify field support and adds
the testpmd CLI command support.

An example for copying GTP QFI field using modify_field action:

	modify_field op set
	             dst_type meta
	             src_type gtp_psc_qfi
	             width 8

An example of setting GTP QFI field value to 0x1f using modify_field
action:

	modify_field op set
	             dst_type gtp_psc_qfi
	             src_type value src_value 1f
	             width 8

Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---

v2:

* Squashed ethdev and testpmd commits.

 app/test-pmd/cmdline_flow.c | 2 +-
 lib/ethdev/rte_flow.h       | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 7f50028eb7..b9673314b1 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -796,7 +796,7 @@ static const char *const modify_field_ids[] = {
 	"udp_port_src", "udp_port_dst",
 	"vxlan_vni", "geneve_vni", "gtp_teid",
 	"tag", "mark", "meta", "pointer", "value",
-	"ipv4_ecn", "ipv6_ecn", NULL
+	"ipv4_ecn", "ipv6_ecn", "gtp_psc_qfi", NULL
 };
 
 /** Maximum number of subsequent tokens and arguments on the stack. */
diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index a79f1e7ef0..e64831f8f1 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -3689,6 +3689,7 @@ enum rte_flow_field_id {
 	RTE_FLOW_FIELD_VALUE,		/**< Immediate value. */
 	RTE_FLOW_FIELD_IPV4_ECN,	/**< IPv4 ECN. */
 	RTE_FLOW_FIELD_IPV6_ECN,	/**< IPv6 ECN. */
+	RTE_FLOW_FIELD_GTP_PSC_QFI,	/**< GTP QFI. */
 };
 
 /**
-- 
2.25.1

RE: [PATCH 1/2] ethdev: add GTP PSC QFI field

[Dariusz Sosnowski]

Hi Ori,

> -----Original Message-----
> From: Ori Kam <orika@nvidia.com>
> Sent: Wednesday, September 21, 2022 14:43
> To: Dariusz Sosnowski <dsosnowski@nvidia.com>; NBU-Contact-Thomas
> Monjalon (EXTERNAL) <thomas@monjalon.net>; Ferruh Yigit
> <ferruh.yigit@xilinx.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 1/2] ethdev: add GTP PSC QFI field
> 
> Hi Dariusz,
> Please merge the testpmd and this commit.
> And you can add my ack.

Sent v2 to the ML (http://patches.dpdk.org/project/dpdk/patch/20220921143202.1790802-1-dsosnowski@nvidia.com/)

Thank you.

Best regards,
Dariusz Sosnowski

Re: [PATCH v2] ethdev: add GTP PSC QFI field

[Andrew Rybchenko]

On 9/21/22 17:32, Dariusz Sosnowski wrote:
> This patch introduces the GTP PSC QFI modify field support and adds
> the testpmd CLI command support.
> 
> An example for copying GTP QFI field using modify_field action:
> 
> 	modify_field op set
> 	             dst_type meta
> 	             src_type gtp_psc_qfi
> 	             width 8
> 
> An example of setting GTP QFI field value to 0x1f using modify_field
> action:
> 
> 	modify_field op set
> 	             dst_type gtp_psc_qfi
> 	             src_type value src_value 1f
> 	             width 8
> 
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
> 
> v2:
> 
> * Squashed ethdev and testpmd commits.
> 
>   app/test-pmd/cmdline_flow.c | 2 +-
>   lib/ethdev/rte_flow.h       | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 

Applied to dpdk-next-net/main, thanks.