From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2920DA0544; Fri, 23 Sep 2022 12:18:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 320A140156; Fri, 23 Sep 2022 12:18:18 +0200 (CEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 2004E4003C for ; Fri, 23 Sep 2022 12:18:17 +0200 (CEST) Received: by mail-lf1-f45.google.com with SMTP id 10so1128320lfy.5 for ; Fri, 23 Sep 2022 03:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date; bh=7KiXgB8TilPaadlEJJaxhf+Ri2Qol/8vB6GKV9iC7bY=; b=XzDjhpSr3Cdj5M5wYpLDq4UnY85ln5O1ivtLJ8q0Mb71vSmxYmvqiYBi2O/hG/YNgm +eNIgVztvqYUoE5MlMuefb1AvyO4dGFqJPxkAki8IpS4uTRpzLCAGv54F4SNliyjqBca JuOhmhmWeTqz28CER+fE9u0QsrJxpXdUAsSmM4rqXAiHv5RvFC55EHZEc90NxxwCE3rM 0qYQpxZsioJnAN4lP/ggMr09XfCaS+Ys0WBR8Fe/7rHVfDtuOAWUZjHJx7pY3d2eUvSN NfU3eUWhof33zDSlsLBaFWexrLZx+pHeN2RdDlvZ7E7tc01rRMqLglKP8Qd0YcUztU0L UlQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date; bh=7KiXgB8TilPaadlEJJaxhf+Ri2Qol/8vB6GKV9iC7bY=; b=Jr6s63mZsS8RFHq0k/ViQbwSakjH7lKQBavPvOE25hFytcAqdULLySzp+bOZ1KPWha ccG6mzIyCUsoMsRhx36poiPxXBqnCVV9WbZXR9UI1vqdwkfeGSnYUdgSt5+UgbcFFngI M/TYN3zM63SO90WlhaTDXCJ2exF+539s7Y/fQyGYeYWzREq2WFVXn4e+/Ms6gXUmBMai hJcyy7tIAvjPOWy7EPSQkrtnSzRuZOC5CVVze+ewVsX+5EUyEKAdDfx88Q9Z17MJM5Gn lzvP/tweLSCc0J6Bxg8MqSMR0vQoLD39K3Efx7pObq2/7bp5UqkktLQLwxBe/bT8kmwY IJ7A== X-Gm-Message-State: ACrzQf1YaXsdm/zEpagQmnl5G9Dw0MP1Oo4ernrw0o6nSmS1TX/NTPQc BUXVk++2exn0lgtBoHBXCiygXQ== X-Google-Smtp-Source: AMsMyM4ReFhtZPAJO9ZLOZJ1GtzyK+OOf2h91zbl7LdLqYveu+S+ghcrJuEun4vpsIkBKwk2/zR4LQ== X-Received: by 2002:a05:6512:b82:b0:4a0:5970:115c with SMTP id b2-20020a0565120b8200b004a05970115cmr226231lfv.531.1663928296518; Fri, 23 Sep 2022 03:18:16 -0700 (PDT) Received: from toster (87-206-67-180.dynamic.chello.pl. [87.206.67.180]) by smtp.gmail.com with ESMTPSA id a16-20020ac25e70000000b004974da17c2bsm1391511lfr.0.2022.09.23.03.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 03:18:15 -0700 (PDT) Date: Fri, 23 Sep 2022 12:18:12 +0200 From: Stanislaw Kardach To: Bruce Richardson Cc: Juraj =?utf-8?Q?Linke=C5=A1?= , "thomas@monjalon.net" , "david.marchand@redhat.com" , "ronan.randles@intel.com" , "Honnappa.Nagarahalli@arm.com" , "ohilyard@iol.unh.edu" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: Re: [PATCH v4 4/9] dts: add ssh pexpect library Message-ID: <20220923101812.ufpzcbd54c5mcaep@toster> References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-1-juraj.linkes@pantheon.tech> <20220729105550.1382664-5-juraj.linkes@pantheon.tech> <20220914094222.vprahs3kfhnsklyh@toster> <7f360965ca2c47b29e2413e3207234db@pantheon.tech> <20220922143226.3d5e552cylcie665@toster> <115446c94a7c4eda877c8a968adce100@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 23, 2022 at 09:15:07AM +0100, Bruce Richardson wrote: > On Fri, Sep 23, 2022 at 07:22:26AM +0000, Juraj Linkeš wrote: > > > > Absolutely, but effective time use is also something to consider. Our current plan doesn't won't really have to contend with problems in the future, as we want to add the Farbic implementation in the next release cycle. I'm also working on refactoring the code a bit - I'm adding an abstraction that would allow us to easily replace the pexpect implementation with Fabric (with no impact on DTS behavior - the same APIs will need to be implemented). Also, we'll remove the pexpect implementation once Fabric is in place (unless we can think of a reason for pexpect to stay, in which case we'll need to refactor it). I think that instead of focusing on pexpect we could focus on making sure the replacement won't cause any issues. What do you think? > > > > Personally, I would be very keen to get the move of DTS to the main repo > underway, and so I wouldn't look to have too many massive changes required > before we start seeing patches merged in. Basic code cleanup and > refactoring is fine, but I would think that requiring massive changes like > replacing expect with fabric may be too big an ask. After all, the rest of > DPDK is moving on, meaning more and more DTS content is being added to the > separate DTS repo every release, making the job bigger each time. :-( > > Tl;dr - I'm ok to leave fabric replacement for a release next year. > > /Bruce That makes sense. I would suggest however to put comments around implementation hacks and the public APIs simply to not forget. Though I'd do the refactoring sooner than later because once tests start being merged there will be a higher possibility of them relying on hacks. -- Best Regards, Stanislaw Kardach