From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3197A054D; Fri, 23 Sep 2022 21:01:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 531F4406A2; Fri, 23 Sep 2022 21:01:32 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 2C67540156 for ; Fri, 23 Sep 2022 21:01:30 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id l10so972349plb.10 for ; Fri, 23 Sep 2022 12:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=MKf6KXyd04aI5zZBqDKMlrK6h/lqAHCr67leuEFlc1Q=; b=HZBRrbPGh0EIiXTsfx12047HIHk0qmq3anJvMi/aTnloWUvKgxAps+1d9CiMHQMNgF v5G1J0mSx5wKSdTAxnvTCGXXTXnNvVqjYR2XThOSdMlJrzyRhgeLKZz68AzzRL1ecY1u eZqsdvB5ONGbBjc7LNyjjRttW+sSGqNOm2e+8cpSU55FU55/bd8Qfdv5y/YS6de8JNqJ 8YglJpIFAJgzIhCmsdnlT48q8qW1Y8AJh3fFuaqN/lxLgYpZccuY0GdYaPboAUpgPVgU xiyqmOkeK5qFBc8uM43AsWVaZlKkzeTfO+P+i2TcdF6ZZmuM8IB9LWwRFyRA5yEwuBId kvHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=MKf6KXyd04aI5zZBqDKMlrK6h/lqAHCr67leuEFlc1Q=; b=tWlkIfsj71nvuaIgL62b8VgouZOmzhjjdt36JdDdzrEAp2XF7LnGKtV6snTR+uHNTI 0VU6oILFVb6l1SDd/GibWfnnAZNnzKQLkl0oH9UyZ5oCzjukT4mUW9HY4DISFbhnkWBu 9GjBBuFzDjekFWGMmOHUh48T+8IRJWrrzlTJonWAa/vgU4yMkSNIffgTTrSAZUXR9h0O JuEl0yJ+RPyPxi/nIckBG+DQSAGua9lD+SEwyFoy6KX4UQDeO07dYbMdSo0B47HIif1Y 6FyBYDE60UA2lFgcdFgUDqcIgorkYXwrn3UCcYVhdjaRmnHADSX1TaT/VPYU8tFttgOu oRNA== X-Gm-Message-State: ACrzQf1vSyla6DmQOCY2HRYapm5mN9FEfzwryFgZO4s8NCu56cSIdZEi Oet5YUfmsxsOvUwH3T1sxhTbYw== X-Google-Smtp-Source: AMsMyM6WLobZ7GzvtSe+vHpqKHfZCUKP60O6qPZIYl0l5DNbl+VdeKZ9zU/lzoKWl8QDMwKpuWjMFw== X-Received: by 2002:a17:902:c942:b0:177:fcf1:dc0d with SMTP id i2-20020a170902c94200b00177fcf1dc0dmr9619540pla.35.1663959689307; Fri, 23 Sep 2022 12:01:29 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d12-20020a170903230c00b00172d0c7edf4sm6380341plh.106.2022.09.23.12.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 12:01:29 -0700 (PDT) Date: Fri, 23 Sep 2022 12:01:28 -0700 From: Stephen Hemminger To: Junfeng Guo Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, ferruh.yigit@xilinx.com, dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, xueqin.lin@intel.com, Haiyue Wang Subject: Re: [PATCH v3 2/9] net/gve: add logs and OS specific implementation Message-ID: <20220923120128.771e0778@hermes.local> In-Reply-To: <20220923093829.3019525-3-junfeng.guo@intel.com> References: <20220829084127.934183-11-junfeng.guo@intel.com> <20220923093829.3019525-1-junfeng.guo@intel.com> <20220923093829.3019525-3-junfeng.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 23 Sep 2022 17:38:22 +0800 Junfeng Guo wrote: > + > +#define PMD_DRV_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt "\n", \ > + __func__, ## args) Many of your existing log messages already have newline, so using this common definition will create double spaced log messages. Please audit all usages and print one newline.