DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>
To: dev@dpdk.org
Cc: "Abdullah Ömer Yamaç" <omer.yamac@ceng.metu.edu.tr>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	"David Marchand" <david.marchand@redhat.com>
Subject: [PATCH v5] eal: fix thread names for high order lcores
Date: Mon, 26 Sep 2022 13:03:14 +0300	[thread overview]
Message-ID: <20220926100314.1115507-1-omer.yamac@ceng.metu.edu.tr> (raw)
In-Reply-To: <CAJFAV8xXJ55KB1u3CsJR8z2sB+Z4UA_h-Dh-DENkwmKmx-mPDA@mail.gmail.com>

In this patch we suggest a new name for lcore-worker.
In case of higher order (greater than 99) logical cores, name is truncated
(length is restricted to 16 characters, including the
terminating null byte ('\0')) and it makes hard to follow threads.

Ex: This issue can be generated using following arguments:
	--lcores=0,10@1,100@2
Then we have;
lcore-worker-10
lcore-worker-10

Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

---
Cc: David Marchand <david.marchand@redhat.com>
---
 lib/eal/freebsd/eal.c | 2 +-
 lib/eal/linux/eal.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index ee5c929da8..a1bb5363b1 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -817,7 +817,7 @@ rte_eal_init(int argc, char **argv)
 
 		/* Set thread_name for aid in debugging. */
 		snprintf(thread_name, sizeof(thread_name),
-				"lcore-worker-%d", i);
+				"rte-worker-%d", i);
 		rte_thread_setname(lcore_config[i].thread_id, thread_name);
 
 		ret = pthread_setaffinity_np(lcore_config[i].thread_id,
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 46bf52cef0..9a168b7773 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -1248,7 +1248,7 @@ rte_eal_init(int argc, char **argv)
 
 		/* Set thread_name for aid in debugging. */
 		snprintf(thread_name, sizeof(thread_name),
-			"lcore-worker-%d", i);
+			"rte-worker-%d", i);
 		ret = rte_thread_setname(lcore_config[i].thread_id,
 						thread_name);
 		if (ret != 0)
-- 
2.27.0


  parent reply	other threads:[~2022-09-26 10:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 10:18 [PATCH] Update lcore-worker name due to high number of cores Abdullah Ömer Yamaç
2022-09-22 10:30 ` [PATCH v2] lib/eal/linux: update " Abdullah Ömer Yamaç
2022-09-22 15:18   ` Stephen Hemminger
2022-09-23  7:06     ` [PATCH v3] eal: " Abdullah Ömer Yamaç
2022-09-26  9:39       ` David Marchand
2022-09-26  9:56         ` [PATCH v4] eal: fix thread names for high order lcores Abdullah Ömer Yamaç
2022-09-26 10:03         ` Abdullah Ömer Yamaç [this message]
2022-09-30  8:52           ` [PATCH v5] " David Marchand
2022-09-26 10:44         ` [PATCH v3] eal: update lcore-worker name due to high number of cores Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926100314.1115507-1-omer.yamac@ceng.metu.edu.tr \
    --to=omer.yamac@ceng.metu.edu.tr \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).