* [PATCH] app/eventdev: fix incorrect cleanup check
@ 2022-09-26 15:05 pbhagavatula
2022-09-28 13:50 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: pbhagavatula @ 2022-09-26 15:05 UTC (permalink / raw)
To: jerinj; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
During cleanup `rte_event_port_quiesce` should be called
irrespective of whether an event has been dequeued or not
to flush any prefetched events.
Fixes: 7da008df0c8d ("app/eventdev: use port quiescing")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test-eventdev/test_pipeline_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
index 4f40d37659..22a3918ed8 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -696,9 +696,6 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[],
{
int i;
- if (!(deq - enq))
- return;
-
if (deq) {
for (i = enq; i < deq; i++) {
if (ev[i].op == RTE_EVENT_OP_RELEASE)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] app/eventdev: fix incorrect cleanup check
2022-09-26 15:05 [PATCH] app/eventdev: fix incorrect cleanup check pbhagavatula
@ 2022-09-28 13:50 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-09-28 13:50 UTC (permalink / raw)
To: pbhagavatula; +Cc: jerinj, dev
On Mon, Sep 26, 2022 at 8:35 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> During cleanup `rte_event_port_quiesce` should be called
> irrespective of whether an event has been dequeued or not
> to flush any prefetched events.
>
> Fixes: 7da008df0c8d ("app/eventdev: use port quiescing")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> app/test-eventdev/test_pipeline_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 4f40d37659..22a3918ed8 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -696,9 +696,6 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[],
> {
> int i;
>
> - if (!(deq - enq))
> - return;
> -
> if (deq) {
> for (i = enq; i < deq; i++) {
> if (ev[i].op == RTE_EVENT_OP_RELEASE)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-28 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 15:05 [PATCH] app/eventdev: fix incorrect cleanup check pbhagavatula
2022-09-28 13:50 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).