From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7D4BCA00C2;
Tue, 27 Sep 2022 12:10:12 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C450E4282F;
Tue, 27 Sep 2022 12:09:59 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by mails.dpdk.org (Postfix) with ESMTP id 13BB7427EC
for <dev@dpdk.org>; Tue, 27 Sep 2022 12:09:55 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1664273396; x=1695809396;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=4YDHD+oHSrTTpHUdXmmNFdvzuEkkDaB0bXw526XCfb8=;
b=fogD+NC8G8KJ3IHIY9Zh2MUEE9VMDQP7gz4Nn3oytwfH713hdW34rdL6
jXj+lFu+aoAuecOEIKUqMzK9g0v+kqQcJIECHo0vq4Gt+eb2WEoPqigRY
bc8FS7ZBsp0C2a/ukUBczDtBYlIsafwWxR8a9vnKKImxFmC8gCUfoLd+A
Y7nrfxrwAr6iKRopfJsHBvpZqNjHL97huFVTczAWz3Pbkz/d4KyvsoGfa
KbZ5WQxm+YeDnOCRi85vEqAEQWmEm+B+IBkzZ7jFC20L3v3kC3R0UBxEg
NlgKByVtbx2v9opJzs6yzdXbBvdPOWjbsxODAixON9DQEAnF/ilQkR+df g==;
X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="298874277"
X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="298874277"
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Sep 2022 03:09:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="621466639"
X-IronPort-AV: E=Sophos;i="5.93,349,1654585200"; d="scan'208";a="621466639"
Received: from silpixa00401183.ir.intel.com ([10.55.129.143])
by orsmga002.jf.intel.com with ESMTP; 27 Sep 2022 03:09:54 -0700
From: Tadhg Kearney <tadhg.kearney@intel.com>
To: dev@dpdk.org
Cc: david.hunt@intel.com, anatoly.burakov@intel.com, reshma.pattan@intel.com,
Tadhg Kearney <tadhg.kearney@intel.com>
Subject: [PATCH v5 3/3] test/power: add unit tests for uncore API
Date: Tue, 27 Sep 2022 10:09:05 +0000
Message-Id: <20220927100905.1505722-4-tadhg.kearney@intel.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220927100905.1505722-1-tadhg.kearney@intel.com>
References: <20220920094822.1403168-1-tadhg.kearney@intel.com>
<20220927100905.1505722-1-tadhg.kearney@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add basic unit tests covering all nine uncore API's.
Signed-off-by: Tadhg Kearney <tadhg.kearney@intel.com>
---
app/test/meson.build | 2 +
app/test/test_power_uncore.c | 301 +++++++++++++++++++++++++++++++++++
2 files changed, 303 insertions(+)
create mode 100644 app/test/test_power_uncore.c
diff --git a/app/test/meson.build b/app/test/meson.build
index d5cad72116..8a864be957 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -101,6 +101,7 @@ test_sources = files(
'test_power.c',
'test_power_cpufreq.c',
'test_power_kvm_vm.c',
+ 'test_power_uncore.c',
'test_prefetch.c',
'test_rand_perf.c',
'test_rawdev.c',
@@ -241,6 +242,7 @@ fast_tests = [
['power_cpufreq_autotest', false, true],
['power_autotest', true, true],
['power_kvm_vm_autotest', false, true],
+ ['power_uncore_autotest', true, true],
['reorder_autotest', true, true],
['service_autotest', true, true],
['thash_autotest', true, true],
diff --git a/app/test/test_power_uncore.c b/app/test/test_power_uncore.c
new file mode 100644
index 0000000000..5d64524e20
--- /dev/null
+++ b/app/test/test_power_uncore.c
@@ -0,0 +1,301 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2022 Intel Corporation
+ */
+
+#include "test.h"
+
+#ifndef RTE_LIB_POWER
+
+static int
+test_power_uncore(void)
+{
+ printf("Power management library not supported, skipping test\n");
+ return TEST_SKIPPED;
+}
+
+#else
+#include <rte_power_uncore.h>
+#include <power_common.h>
+
+#define MAX_UNCORE_FREQS 32
+
+#define VALID_PKG 0
+#define VALID_DIE 0
+#define INVALID_PKG (rte_power_uncore_get_num_pkgs() + 1)
+#define INVALID_DIE (rte_power_uncore_get_num_dies(VALID_PKG) + 1)
+#define VALID_INDEX 1
+#define INVALID_INDEX (MAX_UNCORE_FREQS + 1)
+
+static int check_power_uncore_init(void)
+{
+ int ret;
+
+ /* Test initialisation of uncore configuration*/
+ ret = rte_power_uncore_init(VALID_PKG, VALID_DIE);
+ if (ret < 0) {
+ printf("Cannot initialise uncore power management for pkg %u die %u, this "
+ "may occur if environment is not configured "
+ "correctly(APCI cpufreq) or operating in another valid "
+ "Power management environment\n", VALID_PKG, VALID_DIE);
+ return -1;
+ }
+
+ /* Unsuccessful Test */
+ ret = rte_power_uncore_init(INVALID_PKG, INVALID_DIE);
+ if (ret == 0) {
+ printf("Unexpectedly was able to initialise uncore power management "
+ "for pkg %u die %u\n", INVALID_PKG, INVALID_DIE);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_get_uncore_freq(void)
+{
+ int ret;
+
+ /* Successfully get uncore freq */
+ ret = rte_power_get_uncore_freq(VALID_PKG, VALID_DIE);
+ if (ret < 0) {
+ printf("Failed to get uncore frequency for pkg %u die %u\n",
+ VALID_PKG, VALID_DIE);
+ return -1;
+ }
+
+ /* Unsuccessful Test */
+ ret = rte_power_get_uncore_freq(INVALID_PKG, INVALID_DIE);
+ if (ret >= 0) {
+ printf("Unexpectedly got invalid uncore frequency for pkg %u die %u\n",
+ INVALID_PKG, INVALID_DIE);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_set_uncore_freq(void)
+{
+ int ret;
+
+ /* Successfully set uncore freq */
+ ret = rte_power_set_uncore_freq(VALID_PKG, VALID_DIE, VALID_INDEX);
+ if (ret < 0) {
+ printf("Failed to set uncore frequency for pkg %u die %u index %u\n",
+ VALID_PKG, VALID_DIE, VALID_INDEX);
+ return -1;
+ }
+
+ /* Try to unsuccessfully set invalid uncore freq index */
+ ret = rte_power_set_uncore_freq(VALID_PKG, VALID_DIE, INVALID_INDEX);
+ if (ret == 0) {
+ printf("Unexpectedly set invalid uncore index for pkg %u die %u index %u\n",
+ VALID_PKG, VALID_DIE, INVALID_INDEX);
+ return -1;
+ }
+
+ /* Unsuccessful Test */
+ ret = rte_power_set_uncore_freq(INVALID_PKG, INVALID_DIE, VALID_INDEX);
+ if (ret == 0) {
+ printf("Unexpectedly set invalid uncore frequency for pkg %u die %u index %u\n",
+ INVALID_PKG, INVALID_DIE, VALID_INDEX);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_uncore_freq_max(void)
+{
+ int ret;
+
+ /* Successfully get max uncore freq */
+ ret = rte_power_uncore_freq_max(VALID_PKG, VALID_DIE);
+ if (ret < 0) {
+ printf("Failed to set max uncore frequency for pkg %u die %u\n",
+ VALID_PKG, VALID_DIE);
+ return -1;
+ }
+
+ /* Unsuccessful Test */
+ ret = rte_power_uncore_freq_max(INVALID_PKG, INVALID_DIE);
+ if (ret == 0) {
+ printf("Unexpectedly set invalid max uncore frequency for pkg %u die %u\n",
+ INVALID_PKG, INVALID_DIE);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_uncore_freq_min(void)
+{
+ int ret;
+
+ /* Successfully get min uncore freq */
+ ret = rte_power_uncore_freq_min(VALID_PKG, VALID_DIE);
+ if (ret < 0) {
+ printf("Failed to set min uncore frequency for pkg %u die %u\n",
+ VALID_PKG, VALID_DIE);
+ return -1;
+ }
+
+ /* Unsuccessful Test */
+ ret = rte_power_uncore_freq_min(INVALID_PKG, INVALID_DIE);
+ if (ret == 0) {
+ printf("Unexpectedly set invalid min uncore frequency for pkg %u die %u\n",
+ INVALID_PKG, INVALID_DIE);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_uncore_get_num_freqs(void)
+{
+ int ret;
+
+ /* Successfully get number of uncore freq */
+ ret = rte_power_uncore_get_num_freqs(VALID_PKG, VALID_DIE);
+ if (ret < 0) {
+ printf("Failed to get number of uncore frequencies for pkg %u die %u\n",
+ VALID_PKG, VALID_DIE);
+ return -1;
+ }
+
+ /* Unsuccessful Test */
+ ret = rte_power_uncore_get_num_freqs(INVALID_PKG, INVALID_DIE);
+ if (ret >= 0) {
+ printf("Unexpectedly got number of invalid frequencies for pkg %u die %u\n",
+ INVALID_PKG, INVALID_DIE);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_uncore_get_num_pkgs(void)
+{
+ int ret;
+
+ /* Successfully get number of uncore pkgs */
+ ret = rte_power_uncore_get_num_pkgs();
+ if (ret == 0) {
+ printf("Failed to get number of uncore pkgs\n");
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_uncore_get_num_dies(void)
+{
+ int ret;
+
+ /* Successfully get number of uncore dies */
+ ret = rte_power_uncore_get_num_dies(VALID_PKG);
+ if (ret == 0) {
+ printf("Failed to get number of uncore dies for pkg %u\n",
+ VALID_PKG);
+ return -1;
+ }
+
+ /* Unsuccessful test */
+ ret = rte_power_uncore_get_num_dies(INVALID_PKG);
+ if (ret > 0) {
+ printf("Unexpectedly got number of invalid dies for pkg %u\n",
+ INVALID_PKG);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+check_power_uncore_exit(void)
+{
+ int ret;
+
+ /* Successfully exit uncore power management */
+ ret = rte_power_uncore_exit(VALID_PKG, VALID_DIE);
+ if (ret < 0) {
+ printf("Failed to exit uncore power management for pkg %u die %u\n",
+ VALID_PKG, VALID_DIE);
+ }
+
+ /* Unsuccessful Test */
+ ret = rte_power_uncore_exit(INVALID_PKG, INVALID_DIE);
+ if (ret == 0) {
+ printf("Unexpectedly was able to exit uncore power management for pkg %u die %u\n",
+ INVALID_PKG, INVALID_DIE);
+ return -1;
+ }
+
+ return 0;
+}
+
+static int
+test_power_uncore(void)
+{
+ int ret;
+
+ ret = rte_power_uncore_get_num_pkgs();
+ if (ret == 0) {
+ printf("Uncore frequency management not supported/enabled on this kernel."
+ "Please enable CONFIG_INTEL_UNCORE_FREQ_CONTROL if on x86 with linux kernel"
+ " >= 5.6\n");
+ return TEST_SKIPPED;
+ }
+
+ ret = check_power_uncore_init();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_get_uncore_freq();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_set_uncore_freq();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_uncore_freq_max();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_uncore_freq_min();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_uncore_get_num_freqs();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_uncore_get_num_pkgs();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_uncore_get_num_dies();
+ if (ret < 0)
+ goto fail_all;
+
+ ret = check_power_uncore_exit();
+ if (ret < 0)
+ return -1;
+
+ return 0;
+
+fail_all:
+ rte_power_uncore_exit(VALID_PKG, VALID_DIE);
+ return -1;
+}
+#endif
+
+REGISTER_TEST_COMMAND(power_uncore_autotest, test_power_uncore);
--
2.25.1