* [PATCH] net/virtio: remove declaration of undefined function
@ 2022-09-29 12:22 Olivier Matz
2022-10-06 13:07 ` Maxime Coquelin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Olivier Matz @ 2022-09-29 12:22 UTC (permalink / raw)
To: dev; +Cc: Maxime Coquelin, Chenbo Xia
This function is not defined, remove its declaration.
Fixes: c1f86306a026 ("virtio: add new driver")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/virtio/virtqueue.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index d100ed8762..f5d8b40cad 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -474,10 +474,6 @@ virtqueue_enable_intr(struct virtqueue *vq)
virtqueue_enable_intr_split(vq);
}
-/**
- * Dump virtqueue internal structures, for debug purpose only.
- */
-void virtqueue_dump(struct virtqueue *vq);
/**
* Get all mbufs to be freed.
*/
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/virtio: remove declaration of undefined function
2022-09-29 12:22 [PATCH] net/virtio: remove declaration of undefined function Olivier Matz
@ 2022-10-06 13:07 ` Maxime Coquelin
2022-10-17 6:56 ` Xia, Chenbo
2022-10-26 9:43 ` Xia, Chenbo
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2022-10-06 13:07 UTC (permalink / raw)
To: Olivier Matz, dev; +Cc: Chenbo Xia
On 9/29/22 14:22, Olivier Matz wrote:
> This function is not defined, remove its declaration.
>
> Fixes: c1f86306a026 ("virtio: add new driver")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/virtio/virtqueue.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index d100ed8762..f5d8b40cad 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -474,10 +474,6 @@ virtqueue_enable_intr(struct virtqueue *vq)
> virtqueue_enable_intr_split(vq);
> }
>
> -/**
> - * Dump virtqueue internal structures, for debug purpose only.
> - */
> -void virtqueue_dump(struct virtqueue *vq);
> /**
> * Get all mbufs to be freed.
> */
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/virtio: remove declaration of undefined function
2022-09-29 12:22 [PATCH] net/virtio: remove declaration of undefined function Olivier Matz
2022-10-06 13:07 ` Maxime Coquelin
@ 2022-10-17 6:56 ` Xia, Chenbo
2022-10-26 9:43 ` Xia, Chenbo
2 siblings, 0 replies; 4+ messages in thread
From: Xia, Chenbo @ 2022-10-17 6:56 UTC (permalink / raw)
To: Matz, Olivier, dev; +Cc: Maxime Coquelin
> -----Original Message-----
> From: Olivier Matz <olivier.matz@6wind.com>
> Sent: Thursday, September 29, 2022 8:22 PM
> To: dev@dpdk.org
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>
> Subject: [PATCH] net/virtio: remove declaration of undefined function
>
> This function is not defined, remove its declaration.
>
> Fixes: c1f86306a026 ("virtio: add new driver")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/virtio/virtqueue.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/virtio/virtqueue.h
> b/drivers/net/virtio/virtqueue.h
> index d100ed8762..f5d8b40cad 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -474,10 +474,6 @@ virtqueue_enable_intr(struct virtqueue *vq)
> virtqueue_enable_intr_split(vq);
> }
>
> -/**
> - * Dump virtqueue internal structures, for debug purpose only.
> - */
> -void virtqueue_dump(struct virtqueue *vq);
> /**
> * Get all mbufs to be freed.
> */
> --
> 2.30.2
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/virtio: remove declaration of undefined function
2022-09-29 12:22 [PATCH] net/virtio: remove declaration of undefined function Olivier Matz
2022-10-06 13:07 ` Maxime Coquelin
2022-10-17 6:56 ` Xia, Chenbo
@ 2022-10-26 9:43 ` Xia, Chenbo
2 siblings, 0 replies; 4+ messages in thread
From: Xia, Chenbo @ 2022-10-26 9:43 UTC (permalink / raw)
To: Matz, Olivier, dev; +Cc: Maxime Coquelin
> -----Original Message-----
> From: Olivier Matz <olivier.matz@6wind.com>
> Sent: Thursday, September 29, 2022 8:22 PM
> To: dev@dpdk.org
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>
> Subject: [PATCH] net/virtio: remove declaration of undefined function
>
> This function is not defined, remove its declaration.
>
> Fixes: c1f86306a026 ("virtio: add new driver")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/virtio/virtqueue.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/virtio/virtqueue.h
> b/drivers/net/virtio/virtqueue.h
> index d100ed8762..f5d8b40cad 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -474,10 +474,6 @@ virtqueue_enable_intr(struct virtqueue *vq)
> virtqueue_enable_intr_split(vq);
> }
>
> -/**
> - * Dump virtqueue internal structures, for debug purpose only.
> - */
> -void virtqueue_dump(struct virtqueue *vq);
> /**
> * Get all mbufs to be freed.
> */
> --
> 2.30.2
Applied to next-virtio/main, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-26 9:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 12:22 [PATCH] net/virtio: remove declaration of undefined function Olivier Matz
2022-10-06 13:07 ` Maxime Coquelin
2022-10-17 6:56 ` Xia, Chenbo
2022-10-26 9:43 ` Xia, Chenbo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).