From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 17FCCA0542;
	Wed,  5 Oct 2022 18:34:45 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 567AA42685;
	Wed,  5 Oct 2022 18:34:42 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 1CD8F427F7
 for <dev@dpdk.org>; Wed,  5 Oct 2022 18:34:40 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 63F5720E97BC; Wed,  5 Oct 2022 09:34:39 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 63F5720E97BC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1664987679;
 bh=E5edN0DRfAhX+Dy+P1IclNm1qD3vl6Wky3xZRrlJNJY=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=o0PpdGvcOUoeUIAfSFPHB8/svmBtFEMihdXliSKEIz1GuBXjL5Ron/hnt3a7uidd6
 zo8s4X9ftsycFHBVVtQlDaCimEDqKp73fac6vZqHp8smmWD1Fb7tPuecqBHcnHS9HV
 n9SGwVaMgV/c5k2hu0a/eEIoLhID/p3FpvJphYkA=
Date: Wed, 5 Oct 2022 09:34:39 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>, thomas@monjalon.net,
 dmitry.kozliuk@gmail.com
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API
Message-ID: <20221005163439.GC7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com>
 <1656348966-10194-1-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8ySD5ORi4cp6GWYNUa8-+620jL=WrKLbkkcvLLCLP5avA@mail.gmail.com>
 <20221005161126.GB7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221005161126.GB7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote:
> hi David,
> 
> 
> > 
> > Newly added code can go to eal_common_thread.c rather than introduce a
> > new common/rte_thread.c file (or is there a rationale for this?).
> 
> i will make this change in the next revision. if anyone does object i
> hope they will do so quickly.

looking at this more closely i'm going to back away from making the
adjustment here. if Thomas and/or Dmitry could comment it would be
appreciated.

it appears that functions placed in eal_common_xxx files are consumed
internally by the eal where rte_xxx files are functions that are exposed
through public api.

since these additions are public api it seems they should remain in
rte_thread.c
 
i won't change this in the next revision, but please do correct me if
i'm still not on track.