From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03B11A00C2; Thu, 6 Oct 2022 17:14:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 906CA42C9E; Thu, 6 Oct 2022 17:14:22 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 9772242C9D for ; Thu, 6 Oct 2022 17:14:21 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id E304E20E94D7; Thu, 6 Oct 2022 08:14:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E304E20E94D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1665069260; bh=I/1O4BJ8mPMcnoetc1pYpOCLB8FymuuVFaO4KAFLSmk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sI5u3CT2WQo0RPp129sjHace4QAIzuIPFao7XfBCEyyqq8M6gpoyx4HZTSjvE5yWO f9FwOyKxfTGUYcNX5b+DLSLtIJZZjvJFya6J51r2BYsE0Pg22zzPBDP73WKb3ExF86 H6YDcDNtSPOWaiiT6X0E53XCAMu0yqfEpY+xvFTo= Date: Thu, 6 Oct 2022 08:14:20 -0700 From: Tyler Retzlaff To: David Marchand Cc: thomas@monjalon.net, dmitry.kozliuk@gmail.com, dev@dpdk.org, anatoly.burakov@intel.com Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API Message-ID: <20221006151420.GB2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1656348966-10194-1-git-send-email-roretzla@linux.microsoft.com> <20221005161126.GB7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20221005163439.GC7581@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 06, 2022 at 08:52:02AM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 6:34 PM Tyler Retzlaff > wrote: > > > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > hi David, > > > > > > > > > > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > > new common/rte_thread.c file (or is there a rationale for this?). > > > > > > i will make this change in the next revision. if anyone does object i > > > hope they will do so quickly. > > > > looking at this more closely i'm going to back away from making the > > adjustment here. if Thomas and/or Dmitry could comment it would be > > appreciated. > > > > it appears that functions placed in eal_common_xxx files are consumed > > internally by the eal where rte_xxx files are functions that are exposed > > through public api. > > > > since these additions are public api it seems they should remain in > > rte_thread.c > > > > i won't change this in the next revision, but please do correct me if > > i'm still not on track. > > This seems a fair argument. > > > I'll reply on the v5 series: compilation is still broken at patch 4. can you share what the break is? and which platform/target/toolchain? the only thing I found was that the removal of errno.h broke compilation but that is fixed in v5. the CI run for the series doesn't indicate any compilation failures. assuming i'm looking at the correct results. https://lab.dpdk.org/results/dashboard/patchsets/23789/ it does show a unit test failure but it looks like it is related to a service test that you mailed about within the past few days. thanks