From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A58FA00C2; Thu, 6 Oct 2022 17:19:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADEDF42C9E; Thu, 6 Oct 2022 17:19:15 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4FAE942C9D for ; Thu, 6 Oct 2022 17:19:14 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 9C38B20E94C0; Thu, 6 Oct 2022 08:19:13 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9C38B20E94C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1665069553; bh=7r0tgley4Q66S9/YGAT4+fqI/WKoFXPwQPWHFfuF44U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iq/o8Fxx9FAQBrh5I1N6QyExuy4XW7/YHBnnA5W20ND6w3m6AmOyGmlukPR24k1Kt tEJCM6V6vfuUcD7v/FHp9yknZ5z0+CdugzrK3ke7DKJhCdtQ6iWOhsENhfZz4sAb6u TJrG2w29czjiCeHX28lnf2d1KQhcLcHo/qg7vJl4= Date: Thu, 6 Oct 2022 08:19:13 -0700 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com, anatoly.burakov@intel.com Subject: Re: [PATCH v5 4/6] test/threads: add tests for thread lifetime API Message-ID: <20221006151913.GC2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1664989651-29303-1-git-send-email-roretzla@linux.microsoft.com> <1664989651-29303-5-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 06, 2022 at 10:32:56AM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff > wrote: > > > > Test basic functionality and demonstrate use of following thread > > lifetime api. > > > > * rte_thread_create > > * rte_thread_detach > > And, to some extent, rte_thread_equal. > > > * rte_thread_join > > > > Signed-off-by: Narcisa Vasile > > Signed-off-by: Tyler Retzlaff > > --- > > app/test/test_threads.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 52 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_threads.c b/app/test/test_threads.c > > index b9d8b4e..1077373 100644 > > --- a/app/test/test_threads.c > > +++ b/app/test/test_threads.c > > @@ -14,7 +14,7 @@ > > > > static uint32_t thread_id_ready; > > > > -static void * > > +static uint32_t > > thread_main(void *arg) > > Stopping at this patch, I still see a build failure. > This prototype change makes it uncompatible with remaining calls to > pthread_create. hmm, i must have made a mistake somewhere in the rebase. now i see what you mean about build failure @ patch 4 i was considering it only with the entire series applied i had not been testing individual patches in the series. sorry about that. > > This is fixed in patch 6 which I intend to squash here (and adding the > check on arg != NULL that is in patch 5). > Deal? i have no problem with that. now that i've read this can you confirm the only outstanding issue is whether to move code to eal_common_thread? i posted a follow up to thomas and i'm just waiting on his reply. if the reply is still a positive to move the code i can fix the above in a v6. Thomas waiting on your follow up regarding code move. thanks