From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12F62A00C2; Thu, 6 Oct 2022 17:27:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05BFB42B78; Thu, 6 Oct 2022 17:27:17 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1BFD641153 for ; Thu, 6 Oct 2022 17:27:16 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 72F1A20E97AE; Thu, 6 Oct 2022 08:27:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 72F1A20E97AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1665070035; bh=g+AhAf28yeuHQaFEXsIY3AGM82OiAfYlr964P7C4Ibo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHCiKRMxeaQEXquB+D2U/XiGwRpPDaYkFkoU30sDuy6jAnn/2+3J6KIUS07zde97Y MilGKRQqqC5un2+6BiGaskuBzEng87892+o+pb7fe6dITsAbk1uiWQkXWlSlZC8vgQ 6d7z9bGyjoUAXJDf79rmg4q58DFGfaSDQ7LRDHjc= Date: Thu, 6 Oct 2022 08:27:15 -0700 From: Tyler Retzlaff To: David Marchand Cc: Thomas Monjalon , dmitry.kozliuk@gmail.com, dev@dpdk.org, anatoly.burakov@intel.com Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API Message-ID: <20221006152715.GF2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <2082798.OBFZWjSADL@thomas> <20221006151020.GA2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <2599081.BddDVKsqQX@thomas> <20221006152052.GD2395@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 06, 2022 at 05:26:10PM +0200, David Marchand wrote: > On Thu, Oct 6, 2022 at 5:20 PM Tyler Retzlaff > wrote: > > > > On Thu, Oct 06, 2022 at 05:14:55PM +0200, Thomas Monjalon wrote: > > > 06/10/2022 17:10, Tyler Retzlaff: > > > > On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalon wrote: > > > > > 05/10/2022 18:34, Tyler Retzlaff: > > > > > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > > > > > > new common/rte_thread.c file (or is there a rationale for this?). > > > > > > > > > > > > > > i will make this change in the next revision. if anyone does object i > > > > > > > hope they will do so quickly. > > > > > > > > > > > > looking at this more closely i'm going to back away from making the > > > > > > adjustment here. if Thomas and/or Dmitry could comment it would be > > > > > > appreciated. > > > > > > > > > > > > it appears that functions placed in eal_common_xxx files are consumed > > > > > > internally by the eal where rte_xxx files are functions that are exposed > > > > > > through public api. > > > > > > > > > > It is not so clear. > > > > > There is already eal_common_thread.c which implements the same kind of functions, > > > > > so I think you should move your new functions here. > > > > > > > > > > > since these additions are public api it seems they should remain in > > > > > > rte_thread.c > > > > > > > > > > Let's not have 2 .c files for the same purpose in the same directory. > > > > > > > > just as another point there seem to be several other rte_xxx.c files > > > > here can we clarify why they were not subject to the same requirement? > > > > as a follow on does it mean that the code in those files should also be > > > > moved to eal_common_xxx files? > > > > > > That's just history. > > > > > > > please let me know if the justification is not the same i'll move the > > > > functions to the eal_common file as requested. i just want to make sure > > > > it is being done for the consistent/correct reason. > > > > > > Some file names are not correct, we could rename them. > > > > > > I think David is already doing the last minor changes on this series > > > while merging, so no need to do anything on your side. > > > > > > > Thomas, David with this just a final confirmation no need for a v6? > > you're tweaking the series as is for final comments? > > No need for a v6, the code move is trivial, and for the rest, I'm finished. > I'll restart the per patch build all over again to be sure, and then > merge the series probably tonight (CET+2). acknowledged. thanks very much! > > > -- > David Marchand