From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2976A04FD; Fri, 7 Oct 2022 18:20:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9118940DDC; Fri, 7 Oct 2022 18:20:10 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 2A7BA40A80 for ; Fri, 7 Oct 2022 18:20:09 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id w2so5382058pfb.0 for ; Fri, 07 Oct 2022 09:20:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=oAuHCbeQby2972etqsoa5rFSwlXTJqKH1DE6SF2ILw8=; b=D11aDhUIvN7MGSzpjBfUvnNnQGnqL3kF94CvUt2ue39m+HTM95eMa/2X0wJnw3RZ43 DlWc1sz/lS61WTNIi/PNMRh3PY+h1zJmz0OvLoBOlmX/sr557Nu50Ufki6/3d+OY79zt DSIrQmtWKvrexuRflWJECB1Sp0q+ZtSTDwzD5jV0+yu2TA7l4kmXfGmpf67tf1mjYUln DZD880jUYM5f38PNYtr5OIGlmSV0XRv7jH9w/PpC0F6qSkhc3a0hWxzVY2yANxLFxTSJ Te3a/rDmurKKW4OyQCiNFA7kFofey6CZ9EUQltNTcNdRHfJM0jNlgEoI2sL/4wzx2egy l8nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAuHCbeQby2972etqsoa5rFSwlXTJqKH1DE6SF2ILw8=; b=q6JkE8Sen78vv3Dbcw/Mu9oCExxXgUDROmxWxjbVI5NFBLRNrkgmXhqi7zpkNfsvrC sgcuoSWRYPer+72L7RxLUbvxcNeUpyyXImjNouKQ9P1Ys7pjb4eBwCGyWUeVMHCE+776 SZOgnZZfRJRmyl2c3GXqjis8swOBA5OyTFsdxr7o+hXRVlxq6cFqkw9GlOceVw3LMdEG /DmfHFv4F9BhdRDZzT9+bsoJ8m21hQf602i4w/gRIwJ2OZboRsGy8NLWlEhGOPmGtP3i IXEod0PxzM3HdzAVUKd8RTMCx/lY6KthdWYLhxIMZ8ph6dBtkONVVoyEokdRcTOrnjSj g+0w== X-Gm-Message-State: ACrzQf2sCfvYG7dnY6MFhv7AzBsTY7OVlVmJhdN8oIoLA70/KE0WmDNK kUWLt4dKj3UabNUGB+ZywlRqtyeVyjiHIQ== X-Google-Smtp-Source: AMsMyM4aqPzphA6dJRKvd/ithBtYq6TS9NLMIw54woYV5nglAOTDRFuQgupVfmRRcR+RQy/AYmX3UA== X-Received: by 2002:a63:e22:0:b0:458:cfe7:958 with SMTP id d34-20020a630e22000000b00458cfe70958mr5133186pgl.449.1665159608237; Fri, 07 Oct 2022 09:20:08 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id p14-20020aa79e8e000000b005625f08116esm1818563pfq.68.2022.10.07.09.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 09:20:08 -0700 (PDT) Date: Fri, 7 Oct 2022 09:20:06 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: Hanumanth Pothula , Andrew Rybchenko , Ferruh Yigit , dev@dpdk.org Subject: Re: [PATCH v7 2/4] ethdev: support mulitiple mbuf pools per Rx queue Message-ID: <20221007092006.68e5d7fc@hermes.local> In-Reply-To: <20221007091814.764ada2a@hermes.local> References: <20221006170126.1322852-1-hpothula@marvell.com> <20221007143723.3204575-1-andrew.rybchenko@oktetlabs.ru> <20221007143723.3204575-3-andrew.rybchenko@oktetlabs.ru> <13112956.dW097sEU6C@thomas> <20221007091814.764ada2a@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 7 Oct 2022 09:18:14 -0700 Stephen Hemminger wrote: > On Fri, 07 Oct 2022 18:08:57 +0200 > Thomas Monjalon wrote: >=20 > > > + /* Ensure that we have one and only one source of Rx buffers */ > > > + if ((mp !=3D NULL) + =20 > >=20 > > + operator? > > Are we sure a boolean is always translated as 1? =20 >=20 > Yes, it is likely part of C standard. Found it: https://en.cppreference.com/w/c/language/operator_comparison The type of any equality operator expression is int, and its value (which = is not an lvalue) is 1 when the specified relationship holds true and =E2=80=8B0=E2=80=8B when th= e specified relationship does not hold.