From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FA87A0543; Fri, 7 Oct 2022 23:22:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 013B0400D5; Fri, 7 Oct 2022 23:22:21 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id A8BB040042 for ; Fri, 7 Oct 2022 23:22:19 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id b15so5406835pje.1 for ; Fri, 07 Oct 2022 14:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6TYd/7EOCK205yUimfqY76RBkZnjlW+OAgeDCl8lsIg=; b=Z9rCZbZxA4knbvQyCYDE4SaQ+7UKREBWmQuYbjCfifwHQrsA0Lqc1LF/lD5+9Lm3c4 fWxu1nlivjPSNmPXXSMEvmlB4OWPQSe9KHRPn6mel133y46kuTw6vlU84QbGJRD9nXD9 cpgbLVUBWXGe89Ny5h+njIwpdvQUDBLHCTw0ctW2t5Ft9skKfzUw4tF4hBbzFX0OJxNb rriHEoZFwyBv2XJcFGOlL9np6CjwQ3ErFZL/TWxHZMRWrnXxS9kRZgFgSrTHUIb2i11C roGaZsjecW/yKov1B/Ql5YZZ4CJvjECQXJwojyunPJH5r4WN+popVxMcutTOlxCB9rz/ c9yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6TYd/7EOCK205yUimfqY76RBkZnjlW+OAgeDCl8lsIg=; b=wNDDCIH4xlnSFK3QVZBV2+IgNTES2YUtu/Zru7j/1mqhRaLpP0+WqlyhSrDdpnedig zaRwgul4q/2nvGLSIaWP5CsRTJZGRF+HtznDNOtmEEu97kEeoBI5he5ZY0GR3xwSiA4u i1u8m8GVzttwN9wpwpoo9J/s/36d/wZRm+Sk3K26q4lBitfZPoxiSPmERUncPBCDKFEl vLLtYyqCyxyyzr+SuB6GrMhyQpOplGnZTkwXOCeKzu9e9daZrc/XVIcaRNVK50RRdg1r oQAe0eQMcIgoWlUh14EXmehAm/VXb1Wfptnlr7hhKXrg+bM4s7QL/YMpKgkyy/BFvcM1 td4A== X-Gm-Message-State: ACrzQf0SH0agBWTBPVJq+AJxLJ7KeUptZ0PvC8peMJuwtOhYku0+pQx8 atx7/ZSE6fom1mBOYpEa1C/DQA== X-Google-Smtp-Source: AMsMyM7Jq4u6aBtABo4sPg9bXXfY7RziXnrZ1TKPd+g0b7Fbh3QV+hUaRMfsyR/yvqgTcL2W92Nt2A== X-Received: by 2002:a17:902:eccd:b0:17f:8ec1:39d1 with SMTP id a13-20020a170902eccd00b0017f8ec139d1mr7044253plh.139.1665177738720; Fri, 07 Oct 2022 14:22:18 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id l18-20020a170903245200b00172f6726d8esm1950288pls.277.2022.10.07.14.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Oct 2022 14:22:18 -0700 (PDT) Date: Fri, 7 Oct 2022 14:22:16 -0700 From: Stephen Hemminger To: Shijith Thotton Cc: , , , , , , Subject: Re: [PATCH v5 5/7] lib: move mbuf next pointer to first cache line Message-ID: <20221007142216.7d141e9a@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 8 Oct 2022 02:32:09 +0530 Shijith Thotton wrote: > Swapped position of mbuf next pointer and second dynamic field (dynfield2) > if the build is configured to disable IOVA as PA. This is to move the > mbuf next pointer to first cache line. > > Signed-off-by: Shijith Thotton > Acked-by: Olivier Matz Why not always move it? Having things on different cache lines based on config options could cause surprising performance impacts.