From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EB912A0540;
	Fri,  7 Oct 2022 21:20:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B1854400D5;
	Fri,  7 Oct 2022 21:20:31 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 4385040042
 for <dev@dpdk.org>; Fri,  7 Oct 2022 21:20:30 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 8E4C42034CBC; Fri,  7 Oct 2022 12:20:29 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8E4C42034CBC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1665170429;
 bh=DT1aykNTu7iVcIm8i3Cr2zLaK3FCDL56vSHVwrwry9s=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=p2uWrYZ0G3F+S+jjvqJ7D3GoGPjanh0owWRTNLABtsywswzSQlxbRr6PrGxK+zghP
 Edu2sKufl4p3R9XQC38CAdhtyWmavGOx9Tu1yxWTk+PnqRcgho2spcwyMNM5Yw1wmQ
 LrabYdqdA/r29WaBxAaXFz/RIuOWRQCtP2lY1Jf4=
Date: Fri, 7 Oct 2022 12:20:29 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,
 anatoly.burakov@intel.com
Subject: Re: [PATCH v5 0/6] add thread lifetime and attributes API
Message-ID: <20221007192029.GA29785@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com>
 <1664989651-29303-1-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8xeABpgYXufiMHG-Kc6cKhQyzhBfUi2-7Pf1ZcuQZeSkQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8xeABpgYXufiMHG-Kc6cKhQyzhBfUi2-7Pf1ZcuQZeSkQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

thanks David,

appreciate it. it's nice to finally get this series cleared.

On Thu, Oct 06, 2022 at 09:25:12PM +0200, David Marchand wrote:
> On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > add rte thread lifetime and attributes api. with these api additions
> > there is now sufficient platform abstracted thread api to remove the
> > use of pthread in the unit tests.
> >
> > v5:
> >   * include errno.h in rte_thread.c since errno.h is no longer included
> >     in rte_common.h
> >   * move rte_thread_attr symbols from 22.07 to 22.11 section of
> >     version.map.
> >   * remove RTE_HAS_CPUSET guards from rte_thread.h
> 
> Here is a summary of what I did:
> - I had to rollback part of RTE_HAS_CPUSET guards.
> I had forgotten about the reason for those guards: the "culprit" is
> Alpine Linux / musl where cpuset is not exposed unless an application
> is built with _GNU_SOURCE.
> See: https://git.dpdk.org/dpdk/commit/lib/librte_eal/include/rte_thread.h?id=e0473c6d5b18560dd11fd4d7ebc81dea6774f33e
> - I squashed patch 6 in patch 4 to fix the compilation.
> - I moved rte_thread.c content to eal_common_thread.c.
> - I still added Dmitry acks from v4, as the functional parts/API did not change.
> 
> 
> Series applied, thanks.
> 
> 
> -- 
> David Marchand