DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,
	Long Li <longli@microsoft.com>
Subject: [PATCH] net/mana: fix dependencies
Date: Sun,  9 Oct 2022 15:53:37 +0200	[thread overview]
Message-ID: <20221009135337.1317477-1-thomas@monjalon.net> (raw)

The reason for not building is updated
to be consistent with other drivers.

The libibverbs was not detected through pkg-config.
The method dependency() needs to be used first.

The support in rdma-core and Linux is not released yet,
so the documentation is updated.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/nics/mana.rst     | 6 ++++--
 drivers/net/mana/meson.build | 9 ++++++---
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/doc/guides/nics/mana.rst b/doc/guides/nics/mana.rst
index 30e3fd1cb6..005c0b2ca7 100644
--- a/doc/guides/nics/mana.rst
+++ b/doc/guides/nics/mana.rst
@@ -29,7 +29,6 @@ and must be installed separately:
   It allows slow and privileged operations
   (context initialization, hardware resources allocations)
   to be managed by the kernel and fast operations to never leave user space.
-  The minimum required rdma-core version is v43.
 
   In most cases, rdma-core is shipped as a package with an OS distribution.
   User can also install the upstream version of the rdma-core from
@@ -40,7 +39,8 @@ and must be installed separately:
   Low-level user space driver library
   for Microsoft Azure Network Adapter devices,
   it is automatically loaded by libibverbs.
-  The minimum required version of rdma-core with libmana is v43.
+
+  The support of MANA is not merged in rdma-core 42.
 
 - **Kernel modules**
 
@@ -56,6 +56,8 @@ and must be installed separately:
   - mana_ib: InifiniBand device driver.
   - ib_uverbs: user space driver for verbs (entry point for libibverbs).
 
+  The support of MANA is planned in Linux 6.2.
+
 Driver compilation and testing
 ------------------------------
 
diff --git a/drivers/net/mana/meson.build b/drivers/net/mana/meson.build
index bdf526e846..493f0d26d4 100644
--- a/drivers/net/mana/meson.build
+++ b/drivers/net/mana/meson.build
@@ -3,7 +3,7 @@
 
 if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64')
     build = false
-    reason = 'mana is supported on Linux X86_64'
+    reason = 'only supported on x86_64 Linux'
     subdir_done()
 endif
 
@@ -18,9 +18,12 @@ sources += files(
         'tx.c',
 )
 
-libnames = ['ibverbs', 'mana' ]
+libnames = ['ibverbs', 'mana']
 foreach libname:libnames
-    lib = cc.find_library(libname, required:false)
+    lib = dependency('lib' + libname, required:false)
+    if not lib.found()
+        lib = cc.find_library(libname, required:false)
+    endif
     if lib.found()
         ext_deps += lib
     else
-- 
2.36.1


             reply	other threads:[~2022-10-09 13:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-09 13:53 Thomas Monjalon [this message]
2022-10-09 14:03 ` Thomas Monjalon
2022-10-09 14:08   ` Jason Gunthorpe
2022-10-10 18:53     ` Long Li
2022-10-10 19:55       ` Thomas Monjalon
2022-10-10 20:20         ` Long Li
2022-10-10  8:18   ` Ferruh Yigit
2022-10-09 14:18 ` Thomas Monjalon
2022-10-10 21:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221009135337.1317477-1-thomas@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=longli@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).