From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95879A0544; Mon, 10 Oct 2022 12:45:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E93D4282D; Mon, 10 Oct 2022 12:45:00 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id E5FBC4281C for ; Mon, 10 Oct 2022 12:44:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665398699; x=1696934699; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gU9fqShtpjoil736c5TqXl7/fuh6GQ2/qtxBuOkWBM4=; b=dAKmSR1E4li7vn2hDqhh7Yy1nLCuDQ4VTtVRE5/Gsygx7OyZi0aj7lgR XDKzVDT9fCmnwnR94C9XmaOstsCarJM+CgTIgbi9sR4WYcaLvrYFwOa1C Wkji74DyynnM+IyKOVOatvvzeAIL6gZeRFrjCHs7xGF0qreV8Nds03Kc1 ASJNs+YfnHERG7sXYVyya9+9DYo4SD4T0XzExpv2vA2Y2oVi02jIq5qA7 Z1x/M6qkld8pDyQfEZ54Jgp3bnnCL+xOKmwfDO78253pzCzBnor03LsN0 8wCVaMFX2FBC3ZKzeqzSkY69UtPpjhmRuMY/VmGbtChAejskfj71epZOA Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="283921426" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="283921426" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 03:44:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="954871945" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="954871945" Received: from silpixa00401385.ir.intel.com ([10.237.214.34]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2022 03:44:57 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson Subject: [PATCH v3 2/3] kni: add deprecation warning at runtime Date: Mon, 10 Oct 2022 11:44:47 +0100 Message-Id: <20221010104448.350578-2-bruce.richardson@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221010104448.350578-1-bruce.richardson@intel.com> References: <20221005143451.157613-1-bruce.richardson@intel.com> <20221010104448.350578-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When KNI is being used at runtime, output a warning message about its deprecated status. This is part of the deprecation process for KNI agreed by the DPDK technical board.[1] [1] http://mails.dpdk.org/archives/dev/2022-June/243596.html Signed-off-by: Bruce Richardson Reviewed-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 6 ++---- lib/kni/rte_kni.c | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 7c74725968..41e81be6ae 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -37,10 +37,8 @@ Deprecation Notices applications - other technologies such as virtio-user are recommended instead. Following the DPDK technical board `decision `_ - and `refinement `_: - - * Some deprecation warnings will be added in DPDK 22.11. - * The KNI kernel module, library and PMD will be removed from the DPDK 23.11. + and `refinement `_, + the KNI kernel module, library and PMD will be removed from the DPDK 23.11 release. * lib: will fix extending some enum/define breaking the ABI. There are multiple samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index 7971c56bb4..eb7c10ff19 100644 --- a/lib/kni/rte_kni.c +++ b/lib/kni/rte_kni.c @@ -96,6 +96,8 @@ static volatile int kni_fd = -1; int rte_kni_init(unsigned int max_kni_ifaces __rte_unused) { + RTE_LOG(WARNING, KNI, "WARNING: KNI is deprecated and will be removed in DPDK 23.11\n"); + #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 10, 0) if (rte_eal_iova_mode() != RTE_IOVA_PA) { RTE_LOG(ERR, KNI, "KNI requires IOVA as PA\n"); -- 2.34.1