From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C841A0544; Tue, 11 Oct 2022 02:51:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8140842BC3; Tue, 11 Oct 2022 02:51:38 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2067.outbound.protection.outlook.com [40.107.95.67]) by mails.dpdk.org (Postfix) with ESMTP id 5A5B942BBC; Tue, 11 Oct 2022 02:51:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/AdflrPTaxzFpFeqCjgcrDo5pbHn1JozI48rylKFscKrQAV9e3KdDwSzY7tNfFzqpiwkko+nRs2HwO8ZMbmDcBJFmWQYE6bA8/BtBvFVM4vROXekhIXpeCg+mIxO2ANd3aO1tFRNntHVHx9CXiUCZUCXnjK+CV5sqAQvIIWDopfbTZ2QExtHjKK5uh2vGVIVwVmGFW/x6Sk0SSUBZt+umUbmVDHncrhL4RQtp5DUbS0l42KMmJgkIdqXVVHePFm/OdvWo1LVLCM1liMvwg1jDUReTK63PQAVS0tx/Tb3LiXz7uVanr3fvWkA5OEXEa+wdhiw/ThD+ZPc48NHSH8cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2D9kgK+HW6LulQg52lNcgajhCK4gktTz9uKrqFgyWmA=; b=hvIx8Zjuf4Ia0B62Y/uPrgX/q0SxEfBOtU0Q/t448WCEc/j+kLII0923PfP9LWdxK12ZX6hjo1EGn42wKSP3bPw1Qnca6XX5CigjuVsZ7T/z5/hmGlUExSMGfp++ZwcnNwXX/5gavQ3gtxZJlSqjuteiWq8STxVdDxXw0IxbaM+GP2ciWL/UKyBxxGRoRf3GcQ9JgBeHPXEwD64mtBl9Z8tlRi1NAF+Ll50sCSj4KnzYxJDL3Z9+PIhOURN4YRP6Qlkikdozg6/Ri3L/tbAArNTPJLdarZz1O7R9i9pzQuCXwkjgOapVHmqdkYl/HP+kCFn6nmjxGYt2VoklHKtIlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2D9kgK+HW6LulQg52lNcgajhCK4gktTz9uKrqFgyWmA=; b=20I/cHEPSVT1YnOxImR/U3QRmhyQyzitojuP4GLRt0rPOrNNlJv8UcB2yehNEndGYlM0uRoMZSX0jtyesPlhnVimtySlY0r/HPwg2mPwksgj/2SZ1u+PtkIcsM4yd7bFn1g9NzjA2FXu5cPzqjde8nFy89QaGQM/weJVfKrhxYM= Received: from BN9PR03CA0504.namprd03.prod.outlook.com (2603:10b6:408:130::29) by DM6PR12MB4403.namprd12.prod.outlook.com (2603:10b6:5:2ab::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Tue, 11 Oct 2022 00:51:35 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:408:130:cafe::72) by BN9PR03CA0504.outlook.office365.com (2603:10b6:408:130::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.20 via Frontend Transport; Tue, 11 Oct 2022 00:51:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5709.10 via Frontend Transport; Tue, 11 Oct 2022 00:51:35 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 10 Oct 2022 19:51:34 -0500 From: Andrew Boyer To: CC: Andrew Boyer , Subject: [PATCH v1 04/35] net/ionic: fix up the Rx filter save API Date: Mon, 10 Oct 2022 17:50:01 -0700 Message-ID: <20221011005032.47584-5-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221007174336.54354-1-andrew.boyer@amd.com> References: <20221007174336.54354-1-andrew.boyer@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT067:EE_|DM6PR12MB4403:EE_ X-MS-Office365-Filtering-Correlation-Id: c13b631b-91f6-4959-c4a4-08daab22bf5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WGkxKgkAPMS3LH11oOmCIVusi+2dynC2gq0TALWy0cZU1on7HqBTjvw6ifth2F4CClVAUxN3bFKqymvVKxiJ18tk1qZp1570uLvjfHKIm1pN9UO8AdLYeHjVyUxInLPWGsk4A9UP3VAqSpSSyj/d/EfvzM4OglPqA7uOQxwpocM/o5yTejJnC+TeoYtnP4CvSQPwV36WKfYOZcgvsfeO1ehiGQst8+NsL+lJGvv4KUo5IKX5Yf3VRktvzhSeb+Q0so3zJ6zFBAnD+yv4uY59XnIpIYfkMiWMTw0ti6q22os4UF3RQcf1Qpq6oWIi3WGiBrTl8sJoCOFPFMGw7PTB1Y/44/jtVX3kkcjTA2Grd957K1BZyozR4D1l8SL20AZoAmgvJSPQi1KCqhbwuWmsdgBMjFyIaF2gF1vvSMnuj2JelBvmx090kqKrxO5j6LWiE29v03bcl2z4zs1shESizrqOWCQAV4OGU3qPAhLPKwb0VIxmjVq59/P4XSsmj8KoHyPVUt3UaQkkrtd4SWDI8UIZSTDFT1FRZQaweGW8fdHHht9yq42ECSR/yg+aqDFb2e5C8YcR4+eBCibf9ThUZkHNOMfmoPg5K4KVCJpEnJ+In5XTxWucw+ChTi4p9DglvNUqKLlkhbVfSZLcJ8j0Ujgf5XOskqjTHdY2QZD5pEerYo5TimlAUcWHArSwtkz0dS1DEpguKAFmKCE+lNKvSTo2y1NWE/ovBoRmFjOfTR2OEzLFacZClAUhfvRi+PCHn7aCoctqaqR/eACj2jqFCWfxClgdJWPI8lLMHkwW5xOu/bZyyjo1m4u3mRz2nJUu X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(376002)(39860400002)(136003)(451199015)(36840700001)(46966006)(40470700004)(26005)(1076003)(36860700001)(40480700001)(83380400001)(6666004)(16526019)(336012)(47076005)(186003)(4744005)(2616005)(2906002)(5660300002)(44832011)(40460700003)(82310400005)(54906003)(8936002)(6916009)(41300700001)(478600001)(450100002)(4326008)(70206006)(70586007)(8676002)(316002)(426003)(356005)(86362001)(36756003)(81166007)(82740400003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 00:51:35.3708 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c13b631b-91f6-4959-c4a4-08daab22bf5d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4403 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Check the match variable after copying cmd info, or else there can be unexpected results. Fixes: a27e0e96ab77 ("net/ionic: observe endianness in Rx filter") Cc: andrew.boyer@amd.com Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rx_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c index bf57a9fa52..4b2e907f9f 100644 --- a/drivers/net/ionic/ionic_rx_filter.c +++ b/drivers/net/ionic/ionic_rx_filter.c @@ -63,8 +63,8 @@ ionic_rx_filter_save(struct ionic_lif *lif, uint32_t flow_id, f->flow_id = flow_id; f->filter_id = rte_le_to_cpu_32(ctx->comp.rx_filter_add.filter_id); f->rxq_index = rxq_index; - f->match = rte_le_to_cpu_16(f->cmd.match); memcpy(&f->cmd, &ctx->cmd, sizeof(f->cmd)); + f->match = rte_le_to_cpu_16(f->cmd.match); switch (f->match) { case IONIC_RX_FILTER_MATCH_VLAN: -- 2.17.1