From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C098A0545; Tue, 11 Oct 2022 16:04:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E1CC42DE1; Tue, 11 Oct 2022 16:04:08 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 76D9E42B7D for ; Tue, 11 Oct 2022 16:04:06 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id e129so12862256pgc.9 for ; Tue, 11 Oct 2022 07:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OcYYAplWpslswx6BmiuP/8lm/JNCsVNS4rGX0WT/l1k=; b=sZkyfjf5eThIeeb1hYhpN2bbRDtIxIe4LHpWtxjpwXOYTb4EAzr3isdLHK0uYc7H6/ 2qZqkuCtOZgs4grSvsis+NO84Q3Jem+tdrXHP7msps8+SeVvRCApppmXaamXQOdludeW ingcIMJDW9G9YdO+/3inx1zlBlKhjWF114kl2q8a6zT92aGTpFyEtgMMK0UsI/+k1poc wKk9+FA+PXp/iZIePvzxuMWEeu6iNwsKVeJVq/Whctzo+/T8lXsp5WTEMpbPFSRMNcFY s5WZG5WqniLybCzh3IpvT76yUI96+stTYQs64paaTKM1BmycpYpANLzo7Rj6gZwhKu8i 3Wgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OcYYAplWpslswx6BmiuP/8lm/JNCsVNS4rGX0WT/l1k=; b=derz3A6pZs33fPYEwnRlL+0KfBKbM5g1XRHDsIOv5Xy49cpMtfC16j3Gumd3PZHyP1 5bRLp5DQL0fxH/kbiu307liULH7jgLe2L23AxCLYrKtN5Zdp04LlPyUPusj3EtVrP3i4 X+YQOGpo3ktPY/uPl3LcIHcHQRIp3WB/7AVlQAazhIGk5UzkkdoxJKnaQhhhxblJi4FS xRNBOLGeEQM6PIE76Yf3A65obq8U53Thq/qyNHUYUjVTsGbyVS8HR1w64mjZkSgDnFgR J6OYJWLWnYzHRN4jT/Jo/iLbGV4eKdTCEoquqGSVoz9p0x/8eh3hDPBXEEYNLaShq1po gffw== X-Gm-Message-State: ACrzQf3WPCfihyvBq4rLC9rXbCUTR05JWqURpQf7s2UK/ShfbkJD8rXH Iv/PJv3rtRSQSk8ah3f6LEZhxA== X-Google-Smtp-Source: AMsMyM42tHRNsQTsoJr1b1rmIOLYfuDgVIC9zXE9yjrZ8B/78vZL6wLVBr2awk0UpBR8i1Jvv0pR/g== X-Received: by 2002:a63:fc5b:0:b0:43c:3f90:ca07 with SMTP id r27-20020a63fc5b000000b0043c3f90ca07mr21752257pgk.110.1665497045477; Tue, 11 Oct 2022 07:04:05 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id c82-20020a624e55000000b0056265011136sm9038540pfb.112.2022.10.11.07.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 07:04:05 -0700 (PDT) Date: Tue, 11 Oct 2022 07:04:02 -0700 From: Stephen Hemminger To: Zhichao Zeng Cc: dev@dpdk.org, stable@dpdk.org, yidingx.zhou@intel.com, Bruce Richardson , Harman Kalra Subject: Re: [PATCH v6] lib/eal: fix segfaults in exiting Message-ID: <20221011070402.76c709e0@hermes.local> In-Reply-To: <20221011052514.1430015-1-zhichaox.zeng@intel.com> References: <20220906025132.160801-1-zhichaox.zeng@intel.com> <20221011052514.1430015-1-zhichaox.zeng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 11 Oct 2022 13:25:14 +0800 Zhichao Zeng wrote: > This patch closes the 'eal-intr-thread' before memory cleanup in > 'rte_eal_cleanup' to avoid segfaults, and adds a flag to avoid executing > 'rte_eal_cleanup' in the child process which is forked to execute some > test cases(e.g. debug_autotest of dpdk-test This is a test bug, not an DPDK bug. I don't think DPDK should account for misuse of API in this way.