From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1447AA0548;
Tue, 11 Oct 2022 20:58:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E11DC42BBE;
Tue, 11 Oct 2022 20:57:33 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by mails.dpdk.org (Postfix) with ESMTP id 6016F42B74;
Tue, 11 Oct 2022 20:57:25 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1665514645; x=1697050645;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=dSge29VminNObHdBdcpCVAtZ25X9foXOhc/LVTuAmxI=;
b=aGYvLJbEnoJIi3pFnjKbx0jlI1uVXpaY4p1D4mON3JY2Np1WTc/13+dd
3/IGWMMBfuoRFcHw+Enw80+CNsReF+Bedulno1olivSTjzap/C7pRga2a
txMIGTk9A6c7ibcIMkikW84xkFqvq/JejTb5HWmNf2Yr/URFzxGrFYzKS
3qZ8yJIrm+vb1M8ZGT9jcXOmhLbohT8ARY3c7wj/LPzQl+Is59RFq7FjJ
TtekdoVvKbv6/BEW2LclJ9oWzZqnJB34HIuGRQ848VBXUu7HhjStHV3SP
6UKVplX8FEQTFaPmUDK28Ld5/PIQfpUjwSyu6G+5oT2vSyE38T0F4oWt2 w==;
X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="284981633"
X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="284981633"
Received: from orsmga006.jf.intel.com ([10.7.209.51])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
11 Oct 2022 11:57:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="604261541"
X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="604261541"
Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])
by orsmga006.jf.intel.com with ESMTP; 11 Oct 2022 11:57:24 -0700
From: Hernan Vargas <hernan.vargas@intel.com>
To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,
maxime.coquelin@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com,
Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org
Subject: [PATCH v3 10/30] baseband/acc100: fix clearing PF IR outside handler
Date: Tue, 11 Oct 2022 19:53:26 -0700
Message-Id: <20221012025346.204394-11-hernan.vargas@intel.com>
X-Mailer: git-send-email 2.37.1
In-Reply-To: <20221012025346.204394-1-hernan.vargas@intel.com>
References: <20221012025346.204394-1-hernan.vargas@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Clearing of PF info ring outside of handler may cause interrupt to be
missed.
A condition in the ACC100 PMD implementation may cause an interrupt
functional handler call to be missed due to related bit being cleared
when checking PF info ring status.
Fixes: 06531464151 ("baseband/acc100: support interrupt")
Cc: stable@dpdk.org
Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
drivers/baseband/acc/rte_acc100_pmd.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index c0e6d0ef23..e561d33150 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -261,11 +261,12 @@ acc100_check_ir(struct acc_device *acc100_dev)
while (ring_data->valid) {
if ((ring_data->int_nb < ACC100_PF_INT_DMA_DL_DESC_IRQ) || (
ring_data->int_nb >
- ACC100_PF_INT_DMA_DL5G_DESC_IRQ))
+ ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) {
rte_bbdev_log(WARNING, "InfoRing: ITR:%d Info:0x%x",
ring_data->int_nb, ring_data->detailed_info);
- /* Initialize Info Ring entry and move forward */
- ring_data->val = 0;
+ /* Initialize Info Ring entry and move forward */
+ ring_data->val = 0;
+ }
info_ring_head++;
ring_data = acc100_dev->info_ring +
(info_ring_head & ACC_INFO_RING_MASK);
--
2.37.1