From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E24CAA0543; Wed, 12 Oct 2022 17:15:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5AD7430A7; Wed, 12 Oct 2022 17:15:35 +0200 (CEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 0B04A42EF7 for ; Wed, 12 Oct 2022 17:15:35 +0200 (CEST) Received: by mail-pj1-f52.google.com with SMTP id o9-20020a17090a0a0900b0020ad4e758b3so2341887pjo.4 for ; Wed, 12 Oct 2022 08:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WFA4zlZoug9GCEN1lQ3SiwE1PGfrOZmx+BZTolvpllo=; b=PDGOjwjEls9g1ViIM36ms+tYVD+0kQbLGSXS5i4xUzIU2B+Qwg8THai4/4TfuWVNPT 1DXkizFqpB4Rk6CVkoHXRShPhnKW+b7QoyIMsGhxb7IVlsUW7wSgy7LXz5bFXvf+vybH dXirUr5QygSYN1cumbMBTmneAPbcTE+zHid3PoH24883YnJaEibnG0K79KPwBmAPZVXn MaR9MLjXoUIYac1Cio7LOj8AdWwjWODvupLlc54+w8UalpBKAt2PDeYCriUH+cZg2Va1 aNKGqb5Ehz5/nlim7J1V4lXgA1UlPYq8E0byqBGzYfiYpBhgWQyusnzpDc0A9HWrlrjr f6dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WFA4zlZoug9GCEN1lQ3SiwE1PGfrOZmx+BZTolvpllo=; b=HrwFWBUQrIa+2jW2wa3nWBn5uOgvTwhDDZ4pekTmE4XPQFcyt5pBnMHpFM6EigwXpT 6SjhnPnoAzyP7s8bjAcqk4/pOUcG1db1MjhKOPzEdqbhKzItRipWswBp0YrlbBRuFV92 qjx94sVRDCPNDic4uEphe7j98YoLCaW75NTtQWfwlproG/jgCRbsfM/eyj2e9xIQ0FSl fdxZWTvIrSNydB/MCkYVJVF6em9kSY2RPpFyKlfSccuztD1k+pVNI3F/28Ddddn8P6uj bzr7rJRecL7cqbHnltqHDztF8m4YxErspOGhVQdvLHYZoykSvxN0vFUIOU3qF1GDxmcW eW2g== X-Gm-Message-State: ACrzQf067WaDJncjCz9TPKpYKsvB8eIxE8/xWefgCBvNMhZ+1AI8hLXN nht6vU1cDSsX1FFy9ekOCQqrkD4fO/4EKw== X-Google-Smtp-Source: AMsMyM6DKoFYbRL7JS3BH0hLswDdcXOEln57huUb670tXm/0Oe0yybWOPVHcFsIGzSFiZFnGocPuvw== X-Received: by 2002:a17:90a:1a43:b0:20a:ea98:b962 with SMTP id 3-20020a17090a1a4300b0020aea98b962mr5831148pjl.118.1665587734082; Wed, 12 Oct 2022 08:15:34 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id k18-20020a170902c41200b0016c0c82e85csm9903427plk.75.2022.10.12.08.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 08:15:33 -0700 (PDT) Date: Wed, 12 Oct 2022 08:15:31 -0700 From: Stephen Hemminger To: Michael Piszczek Cc: dev@dpdk.org, Vipin.Varghese@amd.com Subject: Re: [PATCH v4] pci: read amd iommu virtual address width Message-ID: <20221012081531.722f9f6d@hermes.local> In-Reply-To: <20221011140854.777428-1-mpiszczek@ddn.com> References: <20220912160157.3642968-2-mpiszczek@ddn.com> <20221011140854.777428-1-mpiszczek@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 11 Oct 2022 16:08:53 +0200 Michael Piszczek wrote: > + mgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1; > } > + else { Minor nit, the kernel style used by DPDK uses "cuddle else" } else {