From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 846B3A0547; Wed, 12 Oct 2022 10:29:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21C9642D6E; Wed, 12 Oct 2022 10:29:35 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C649842B6D for ; Wed, 12 Oct 2022 10:29:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665563373; x=1697099373; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RYsC2fIZ2Aoxz4SoLcE5ypJKtnw7o0iZ7jQGNCdlap4=; b=RjTiefbXqPLQ9PaeRjKVphDxzQeg+TNQj+i0ajYOOydSxH7rCxiHf4Nk 2k7jJRQrdpSTZ+GVkl6OUtsCJqQEnCscF3Oqx4l82NWl7uN5xtx8ArqRK c/3BS+ofGSTmYiEkYiMokd7AV1kTMNkUJyciFyt3xqojMn/JNrDYR2vjx OlZedkJCfxFp00hTOt85/azeRrCD7/yKRzLpFDrGYQ7NL8pf7cLUDHxiH lxS/0B7y9+BqhzSjW2YxBYIYoJuoDiKmbp4dWKhazpPvKKOZNATFLvyFi sd6geBrE65XTg6rtDe/L86Uk5bAgofbmH96pK9/3W9jKGYvRgrtHRl4WL w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="288002797" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="288002797" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 01:29:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="715838940" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="715838940" Received: from silpixa00401183.ir.intel.com ([10.55.129.143]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2022 01:29:31 -0700 From: Tadhg Kearney To: dev@dpdk.org Cc: david.hunt@intel.com, anatoly.burakov@intel.com, reshma.pattan@intel.com, Tadhg Kearney Subject: [PATCH] power: fix resource leak by open file pointers Date: Wed, 12 Oct 2022 08:29:28 +0000 Message-Id: <20221012082928.2171562-1-tadhg.kearney@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Close file pointers to Intel uncore sysfiles. Coverity issue: 381400 381397 Fixes: 60b8a661a957 ("power: add Intel uncore frequency control") CC: david.hunt@intel.com Signed-off-by: Tadhg Kearney --- lib/power/rte_power_intel_uncore.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/power/rte_power_intel_uncore.c b/lib/power/rte_power_intel_uncore.c index 3afe8feffa..f86e1c8b7a 100644 --- a/lib/power/rte_power_intel_uncore.c +++ b/lib/power/rte_power_intel_uncore.c @@ -192,6 +192,11 @@ power_init_for_setting_uncore_freq(struct uncore_power_info *ui) ui->init_max_freq = base_max_freq; ui->init_min_freq = base_min_freq; + fclose(f_base_min); + fclose(f_base_max); + fclose(f_max); + fclose(f_min); + return 0; err: -- 2.25.1