From: Radu Nicolau <radu.nicolau@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, Jian Wang <jianwang@trustnetic.com>
Cc: dev@dpdk.org, Radu Nicolau <radu.nicolau@intel.com>, gakhil@marvell.com
Subject: [PATCH 3/3] net/txgbe: fix security session destroy
Date: Thu, 13 Oct 2022 13:19:13 +0100 [thread overview]
Message-ID: <20221013121913.3543260-3-radu.nicolau@intel.com> (raw)
In-Reply-To: <20221013121913.3543260-1-radu.nicolau@intel.com>
Replace mempool_put with memset 0, the internal session memory block
is no longer allocated from a mempool
Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
Cc: gakhil@marvell.com
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
drivers/net/txgbe/txgbe_ipsec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c
index b458b3a922..f9f8108fb8 100644
--- a/drivers/net/txgbe/txgbe_ipsec.c
+++ b/drivers/net/txgbe/txgbe_ipsec.c
@@ -409,7 +409,6 @@ txgbe_crypto_remove_session(void *device,
{
struct rte_eth_dev *eth_dev = device;
struct txgbe_crypto_session *ic_session = SECURITY_GET_SESS_PRIV(session);
- struct rte_mempool *mempool = rte_mempool_from_obj(ic_session);
if (eth_dev != ic_session->dev) {
PMD_DRV_LOG(ERR, "Session not bound to this device\n");
@@ -421,7 +420,7 @@ txgbe_crypto_remove_session(void *device,
return -EFAULT;
}
- rte_mempool_put(mempool, (void *)ic_session);
+ memset(ic_session, 0, sizeof(struct txgbe_crypto_session));
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2022-10-13 12:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 12:19 [PATCH 1/3] net/iavf: " Radu Nicolau
2022-10-13 12:19 ` [PATCH 2/3] net/ixgbe: " Radu Nicolau
2022-10-13 12:24 ` [EXT] " Akhil Goyal
2022-10-18 4:18 ` Zhang, Qi Z
2022-10-13 12:19 ` Radu Nicolau [this message]
2022-10-13 12:23 ` [EXT] [PATCH 3/3] net/txgbe: " Akhil Goyal
2022-10-14 9:58 ` Jiawen Wu
2022-10-18 4:19 ` Zhang, Qi Z
2022-10-13 12:23 ` [EXT] [PATCH 1/3] net/iavf: " Akhil Goyal
2022-10-18 4:13 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013121913.3543260-3-radu.nicolau@intel.com \
--to=radu.nicolau@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).