From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B75DA0560; Tue, 18 Oct 2022 12:22:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49A184021E; Tue, 18 Oct 2022 12:22:39 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 1B4554021D for ; Tue, 18 Oct 2022 12:22:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666088558; x=1697624558; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GDv9NoYL3BPIAWzUETqNBfwGMlBaUueU1Tx3JYppIQQ=; b=DEfZFVnCN1lLG3SfmQaRjG0c63Bc0zk7QDF52rRgiLmRdyvxt2HjQ08U Pb/6fisWKkxduOpI3MlO8vGTwyq9XrcPeBqbBisUPtOIsB4/z45gRax3b y7mNC561LhP09yUGMDiycmMIrr3vczOzydZ6IagYFK6B2YTN3EKpoJZJy Y+YHzYMU/q0jKqzihePH+YtuQxrLqvwfs63AY6TWyq79SOqsZlYOEgs7j j0VQLOPMTTNGr7wtpqXR8mDYPwVH2mCOGGMafD7KKNYzJXpwbngLSWMTy LHTAy+nVeRDPM+1k0Z86Qcd65pJK9c2515Sq+Y2skuNJy76w38FKxJxgM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="332604007" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="332604007" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 03:22:37 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="697433955" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="697433955" Received: from unknown (HELO dpdkserver..) ([10.239.252.174]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 03:22:35 -0700 From: Yiding Zhou To: dev@dpdk.org Cc: Yiding Zhou Subject: [PATCH] net/iavf: revert fix VLAN insertion Date: Tue, 18 Oct 2022 18:26:02 +0800 Message-Id: <20221018102602.217673-1-yidingx.zhou@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The patch to be reverted forces to select normal Tx path when kernel driver tells that L2TAG2 is required, it results in a lot of performance loss. We should support Tx context descriptor on vector path to handle the L2TAG2 case. This commit reverts commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") Signed-off-by: Yiding Zhou --- drivers/net/iavf/iavf_rxtx_vec_common.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h index 4ab22c6b2b..a59cb2ceee 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_common.h +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) return -1; - if (txq->vlan_flag == IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) - return -1; - if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD) return IAVF_VECTOR_OFFLOAD_PATH; -- 2.34.1