From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66B5AA0560; Tue, 18 Oct 2022 15:27:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1798D40395; Tue, 18 Oct 2022 15:27:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6810F4021D for ; Tue, 18 Oct 2022 15:27:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666099635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L/RvWh5uuhYAPTCmzJnbbdhktGexstAaKeQN91NHPdY=; b=LMjOO2L6qGgVf2seSQVIAG76EdEOfF6bwAvGH5eSAX4KVtGJXBprDwK7hh0WWzTJmH+DwM ioqx461K+lIcnnsdx2E4UufvTMGjEG6CNz0/RVMmH8yg4QxldVQB1F2NP2k3LPkRpSHrVW SWr+Lu2KEeYrp/gSgSh6rE1a+fN7W/Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-ukb4lgfzOY-oarHO-NwnKQ-1; Tue, 18 Oct 2022 09:27:12 -0400 X-MC-Unique: ukb4lgfzOY-oarHO-NwnKQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 148D585A5A6; Tue, 18 Oct 2022 13:27:12 +0000 (UTC) Received: from localhost.localdomain (ovpn-192-244.brq.redhat.com [10.40.192.244]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4640B200B400; Tue, 18 Oct 2022 13:27:11 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: jerinj@marvell.com, skori@marvell.com Subject: [PATCH v4 00/11] Trace subsystem fixes and more Date: Tue, 18 Oct 2022 15:26:43 +0200 Message-Id: <20221018132654.3760561-1-david.marchand@redhat.com> In-Reply-To: <20220921120359.2201131-1-david.marchand@redhat.com> References: <20220921120359.2201131-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, This series addresses a number of issues and limitations I have identified over time in the trace subsystem. The main issue was with dynamically enabling trace points which was not working if no trace point had been enabled at rte_eal_init() time. This is 22.11 material. We may start thinking about marking this API stable, but this is another topic. -- David Marchand Changes since v3: - added one more change for creating new trace directory on call to rte_trace_save(), - added the telemetry commands patch in the series, Changes since v2: - fixed trace point name storage, Changes since v1: - split patch 3, - addressed comments on (previously) patch 4, David Marchand (11): trace: fix mode for new trace point trace: fix mode change trace: fix leak with regexp trace: rework loop on trace points trace: fix dynamically enabling trace points trace: fix race in debug dump trace: fix metadata dump trace: remove limitation on trace point name trace: remove limitation on directory trace: create new directory for each trace dump trace: enable trace operations via telemetry app/test/test_trace.c | 67 +++---- app/test/test_trace.h | 2 + doc/guides/prog_guide/trace_lib.rst | 53 +++++- lib/eal/common/eal_common_trace.c | 192 ++++++++++++++------- lib/eal/common/eal_common_trace_ctf.c | 3 - lib/eal/common/eal_common_trace_utils.c | 132 ++++++-------- lib/eal/common/eal_trace.h | 13 +- lib/eal/include/rte_trace_point_register.h | 3 +- lib/telemetry/telemetry_data.c | 1 + 9 files changed, 279 insertions(+), 187 deletions(-) -- 2.37.3