From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D4BFA0573; Wed, 19 Oct 2022 09:51:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B40E740A8B; Wed, 19 Oct 2022 09:51:17 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id DAE774069C for ; Wed, 19 Oct 2022 09:51:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666165876; x=1697701876; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=D6g274CQpMfmvjRG6C1aMobKScUOyX71hzrX92/xzlg=; b=klozZfhqBIZDGriWxJ3ALpkX8mW5/b4ZqApVPTjnyQcE+vm7jmPs24XV 4MBRrhpCYpVbQf0XNVRwodrTQ8KDcoFu2n8HKLJUrCzBDEMXSep7pprDV U4VRqYDUQYN1ecn+LzY9g9FJrTtxvFUnZdv8mhPZrHOc5yfNVMn4lxQOp H46vbGd8os7nThYTGoCSb7iYptZOobqi1uowqoexie8Zhs9jxhn57Pm5M iOGDRMGUEripmCDRvN8AOLkHmKU8tu48bl+KgDn5lhadrh9BWT1yBO5am J/HEALTvy6xxW0ttEUIdb4WiH24twtBhfDksb/ZH10ruWAmGIszghgmlA A==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="368388181" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="368388181" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 00:51:14 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="697937149" X-IronPort-AV: E=Sophos;i="5.95,195,1661842800"; d="scan'208";a="697937149" Received: from unknown (HELO dpdkserver..) ([10.239.252.174]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2022 00:51:12 -0700 From: Yiding Zhou To: dev@dpdk.org Cc: ktraynor@redhat.com, Yiding Zhou Subject: [PATCH v2] net/iavf: revert fix VLAN insertion Date: Wed, 19 Oct 2022 15:54:32 +0800 Message-Id: <20221019075432.9698-1-yidingx.zhou@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221018102602.217673-1-yidingx.zhou@intel.com> References: <20221018102602.217673-1-yidingx.zhou@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the kernel driver tells to use the L2TAG2 field for VLAN insertion, the context descriptor needs to be used. There is an issue on the vector Tx path, because it does not support the context descriptor. The previous commit forces to select normal path to avoid the above issue, but it results in a performance loss of around 40%. So it needs to be reverted and the original issue needed to be fixed by rework. To reverts commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") Signed-off-by: Yiding Zhou --- drivers/net/iavf/iavf_rxtx_vec_common.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h index 4ab22c6b2b..a59cb2ceee 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_common.h +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) return -1; - if (txq->vlan_flag == IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) - return -1; - if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD) return IAVF_VECTOR_OFFLOAD_PATH; -- 2.34.1