From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 162D9A0A03; Thu, 20 Oct 2022 05:22:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0772A42C74; Thu, 20 Oct 2022 05:22:43 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2079.outbound.protection.outlook.com [40.107.220.79]) by mails.dpdk.org (Postfix) with ESMTP id 3ADD142C8B for ; Thu, 20 Oct 2022 05:22:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CcVmQXDug5cnXtjGfA0bd72E+dP+1gDXzYEAQLi9H0F0+kGneRqM6u+B7njkfZbToutxnMkTe694N/Tjp4V83bzTEhK7xNLVrpRp3DFh3QTtzsVfeLbFwlc7jl0aVQWU59W1YZEUJsdbkVcYgQ+AQKG08YS2RdYQXgG7XMCPU5wouF7g/fElgjL4zNhlWRNbXK5TtBaqXdKBWHXPevlQuf8F2qOyEQaC6l92o+mh1qGF3lFbRBzKk9x0RfsakKReCbxcG4DRAc8tAH82SU/tgs3WbdW845Q4jhOlNb6ejOWu3izfbHfifpLwBVt68hZ5/saQtojrnGOUsN2gdvKIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SgaElT9vBW5/yGd2izniNLdsiMSZ1262QPP+p6moPZ8=; b=meQV5WAw3zBkAn3uwydORscEhoFLX3VGrddv6yDgYWh8mT3hNmC5EJcq+CQJMiPdNeFZhEt2QBczT7DrE6IrgbtPMUFAEohgTOGhSu3Pr3bJYjtZFSy0UCwVeU2U3H7nUQN+2RrjNZHYkoCjR9CnX5PFWmS8emdE919yyGMFLmoqg+kjgPdd6v0l/uqfWWjPCx/jaX3ZMrtMoZhCs0uEADkQ/3ZcJ1W5zcTbvuXTMnvFCn+Eo6jEGIuEoSsLek2ZLrAd6dBkfwvoavCHPe1Pz1U59v7AUr0m+KaPqzeeOCdLGBCugz0sr/h9Pq2dNinjgBMtaSVFaNxPjU63he76Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SgaElT9vBW5/yGd2izniNLdsiMSZ1262QPP+p6moPZ8=; b=LgJzA123kaM8gUT4O+cPJoKRtq+YoXmGhYbZqVLfIn7o7jFQICFZJu059zwfY0VEpCOpe39q+JDdSEtITsU5iWEN1+egK16v43C5V4OwpzwsUI0ECFvXNx1eQv/G3LePTSp4IQAiSMtAcKGN1Ur+b03grz5XUSLeKqp7GYH1BKkwxQKl8NtDZB8dsvMkj88uvmH4v74rePLa7agkxvaZF+SMYCVXGKqQDWmnAormYU9Jy557TPhB+XUxdav0sYQWIi4uE1tHoM9n9xSMbWkh0GQT15sahceLbr9SRd9vX0158yrTUOMSlm+S+KUI44L1rq+xyyS3mBcXfyRTTHWS2w== Received: from DM5PR08CA0057.namprd08.prod.outlook.com (2603:10b6:4:60::46) by SA0PR12MB7076.namprd12.prod.outlook.com (2603:10b6:806:2d5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31; Thu, 20 Oct 2022 03:22:37 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:4:60:cafe::48) by DM5PR08CA0057.outlook.office365.com (2603:10b6:4:60::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15 via Frontend Transport; Thu, 20 Oct 2022 03:22:37 +0000 X-MS-Exchange-Authentication-Results: spf=none (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=nvidia.com; Received-SPF: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.16 via Frontend Transport; Thu, 20 Oct 2022 03:22:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 19 Oct 2022 20:22:29 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 19 Oct 2022 20:22:27 -0700 From: Suanming Mou To: Matan Azrad , Viacheslav Ovsiienko CC: , , Subject: [PATCH v5 02/18] net/mlx5: fix IPv6 and TCP RSS hash fields Date: Thu, 20 Oct 2022 06:21:54 +0300 Message-ID: <20221020032210.30250-3-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20221020032210.30250-1-suanmingm@nvidia.com> References: <20220923144334.27736-1-suanmingm@nvidia.com> <20221020032210.30250-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT032:EE_|SA0PR12MB7076:EE_ X-MS-Office365-Filtering-Correlation-Id: a5a61e71-a962-4023-65ad-08dab24a567c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VyUzfVQsTI/yzcvJI0W5HpH59G3YkeHORYpRoiD/OPtqrML/uVjGRz2tlt9ohtGoaGVcFvvqLF2QC3XBXVOszPQeXoJr/4RvBEX7wTJtc34LHHSBVU/+Bu4Yl7BCi93Kcrqfv85D618gt6+jU+u2AQe6Y2Rd0YKy8tPXYLhZsAYJxTG8cWUJxnnLlfMvTi8RU12BreeXWqwK5XxUX5xT8JkiiT1OrDFQqlZUAdUIgZVXPAtd4+7m5lS/9rhdkjQ6WcjuYF+St4SziZiVwYmE8ucSUDv8qaGRTk2Ubk1r6nP4bDw3T9fu2uAhLzZNqL6rKoZyfsJ3FGggIBbkHrbV0tShbFHnaF/V3q7qV3keBm/aZQ149KjvKq1dEMigTKi3N75kLWXTf0jMwXvQnWBXYFX8qrsTAALHBtPXhZARbWm56EgjFji3VOakBPzDNNv13TzCd7pg0CxCoOikUunxXYIYVkR0YeG8ImGzjDxltRHuENE3jreWFy6Pz3D1jtETRlezCjQ0z83iBciV1v2N8AT5LMXzjkPxgs/2DmY+0Z19pBIneRmcs0k4DcSBJltMsF6iGnVJl7ajQFXWyv8M4nbdT/qOFhuZEYexrGppgLg3xB/LOMWZ6atBLD/EjL4Fc+h+4Jhj2GjuiZ8ZJvAMR1yDCht+XQ1n2eMtBKTew5tmnfKtjIqs/cjQjk+enyGtQd0Fm7cmzcvfy8N+9vk3BnAyeAQdSrYgR/9NkYWeNL3frJ9vg/x7IXMu8cnQnmwcuU7EpZnDFjt7YH5b7WKwbg== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(41300700001)(8936002)(2906002)(5660300002)(36756003)(110136005)(6666004)(7696005)(54906003)(36860700001)(478600001)(70586007)(6636002)(40460700003)(8676002)(4326008)(107886003)(70206006)(26005)(6286002)(426003)(86362001)(82310400005)(47076005)(83380400001)(336012)(316002)(40480700001)(16526019)(356005)(7636003)(2616005)(55016003)(82740400003)(186003)(1076003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 03:22:37.2788 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5a61e71-a962-4023-65ad-08dab24a567c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7076 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In the flow_dv_hashfields_set() function, while item_flags was 0, the code went directly to the first if and the else case would never have chance be checked. This caused the IPv6 and TCP hash fields in the else case would never be set. This commit adds the dedicate HW steering hash field set function to generate the RSS hash fields. Fixes: 3a2f674b6aa8 ("net/mlx5: add queue and RSS HW steering action") Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_dv.c | 12 +++---- drivers/net/mlx5/mlx5_flow_hw.c | 59 ++++++++++++++++++++++++++++++++- 2 files changed, 62 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 0cf757898d..29d7bf7049 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -11274,8 +11274,7 @@ flow_dv_hashfields_set(uint64_t item_flags, rss_inner = 1; #endif if ((rss_inner && (items & MLX5_FLOW_LAYER_INNER_L3_IPV4)) || - (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L3_IPV4)) || - !items) { + (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L3_IPV4))) { if (rss_types & MLX5_IPV4_LAYER_TYPES) { if (rss_types & RTE_ETH_RSS_L3_SRC_ONLY) fields |= IBV_RX_HASH_SRC_IPV4; @@ -11285,8 +11284,7 @@ flow_dv_hashfields_set(uint64_t item_flags, fields |= MLX5_IPV4_IBV_RX_HASH; } } else if ((rss_inner && (items & MLX5_FLOW_LAYER_INNER_L3_IPV6)) || - (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L3_IPV6)) || - !items) { + (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L3_IPV6))) { if (rss_types & MLX5_IPV6_LAYER_TYPES) { if (rss_types & RTE_ETH_RSS_L3_SRC_ONLY) fields |= IBV_RX_HASH_SRC_IPV6; @@ -11309,8 +11307,7 @@ flow_dv_hashfields_set(uint64_t item_flags, return; } if ((rss_inner && (items & MLX5_FLOW_LAYER_INNER_L4_UDP)) || - (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L4_UDP)) || - !items) { + (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L4_UDP))) { if (rss_types & RTE_ETH_RSS_UDP) { if (rss_types & RTE_ETH_RSS_L4_SRC_ONLY) fields |= IBV_RX_HASH_SRC_PORT_UDP; @@ -11320,8 +11317,7 @@ flow_dv_hashfields_set(uint64_t item_flags, fields |= MLX5_UDP_IBV_RX_HASH; } } else if ((rss_inner && (items & MLX5_FLOW_LAYER_INNER_L4_TCP)) || - (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L4_TCP)) || - !items) { + (!rss_inner && (items & MLX5_FLOW_LAYER_OUTER_L4_TCP))) { if (rss_types & RTE_ETH_RSS_TCP) { if (rss_types & RTE_ETH_RSS_L4_SRC_ONLY) fields |= IBV_RX_HASH_SRC_PORT_TCP; diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index fecf28c1ca..d46e4c6769 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -62,6 +62,63 @@ flow_hw_rxq_flag_set(struct rte_eth_dev *dev, bool enable) priv->mark_enabled = enable; } +/** + * Set the hash fields according to the @p rss_desc information. + * + * @param[in] rss_desc + * Pointer to the mlx5_flow_rss_desc. + * @param[out] hash_fields + * Pointer to the RSS hash fields. + */ +static void +flow_hw_hashfields_set(struct mlx5_flow_rss_desc *rss_desc, + uint64_t *hash_fields) +{ + uint64_t fields = 0; + int rss_inner = 0; + uint64_t rss_types = rte_eth_rss_hf_refine(rss_desc->types); + +#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT + if (rss_desc->level >= 2) + rss_inner = 1; +#endif + if (rss_types & MLX5_IPV4_LAYER_TYPES) { + if (rss_types & RTE_ETH_RSS_L3_SRC_ONLY) + fields |= IBV_RX_HASH_SRC_IPV4; + else if (rss_types & RTE_ETH_RSS_L3_DST_ONLY) + fields |= IBV_RX_HASH_DST_IPV4; + else + fields |= MLX5_IPV4_IBV_RX_HASH; + } else if (rss_types & MLX5_IPV6_LAYER_TYPES) { + if (rss_types & RTE_ETH_RSS_L3_SRC_ONLY) + fields |= IBV_RX_HASH_SRC_IPV6; + else if (rss_types & RTE_ETH_RSS_L3_DST_ONLY) + fields |= IBV_RX_HASH_DST_IPV6; + else + fields |= MLX5_IPV6_IBV_RX_HASH; + } + if (rss_types & RTE_ETH_RSS_UDP) { + if (rss_types & RTE_ETH_RSS_L4_SRC_ONLY) + fields |= IBV_RX_HASH_SRC_PORT_UDP; + else if (rss_types & RTE_ETH_RSS_L4_DST_ONLY) + fields |= IBV_RX_HASH_DST_PORT_UDP; + else + fields |= MLX5_UDP_IBV_RX_HASH; + } else if (rss_types & RTE_ETH_RSS_TCP) { + if (rss_types & RTE_ETH_RSS_L4_SRC_ONLY) + fields |= IBV_RX_HASH_SRC_PORT_TCP; + else if (rss_types & RTE_ETH_RSS_L4_DST_ONLY) + fields |= IBV_RX_HASH_DST_PORT_TCP; + else + fields |= MLX5_TCP_IBV_RX_HASH; + } + if (rss_types & RTE_ETH_RSS_ESP) + fields |= IBV_RX_HASH_IPSEC_SPI; + if (rss_inner) + fields |= IBV_RX_HASH_INNER; + *hash_fields = fields; +} + /** * Generate the pattern item flags. * Will be used for shared RSS action. @@ -225,7 +282,7 @@ flow_hw_tir_action_register(struct rte_eth_dev *dev, MLX5_RSS_HASH_KEY_LEN); rss_desc.key_len = MLX5_RSS_HASH_KEY_LEN; rss_desc.types = !rss->types ? RTE_ETH_RSS_IP : rss->types; - flow_dv_hashfields_set(0, &rss_desc, &rss_desc.hash_fields); + flow_hw_hashfields_set(&rss_desc, &rss_desc.hash_fields); flow_dv_action_rss_l34_hash_adjust(rss->types, &rss_desc.hash_fields); if (rss->level > 1) { -- 2.25.1