From: Radu Nicolau <radu.nicolau@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org, qi.z.zhang@intel.com,
Radu Nicolau <radu.nicolau@intel.com>,
stable@dpdk.org
Subject: [PATCH] net/iavf: fix handling of IPsec events
Date: Thu, 20 Oct 2022 10:20:26 +0100 [thread overview]
Message-ID: <20221020092026.3852130-1-radu.nicolau@intel.com> (raw)
Verify that the message length is non zero and keep processing
virtual channel messages after the event is received.
Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto")
Cc: stable@dpdk.org
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
drivers/net/iavf/iavf_vchnl.c | 43 +++++++++++++++++++++--------------
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 4327c5a786..7fc239ee98 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -346,23 +346,32 @@ iavf_handle_virtchnl_msg(struct rte_eth_dev *dev)
iavf_handle_pf_event_msg(dev, info.msg_buf,
info.msg_len);
} else {
- /* check for inline IPsec events */
- struct inline_ipsec_msg *imsg =
- (struct inline_ipsec_msg *)info.msg_buf;
- struct rte_eth_event_ipsec_desc desc;
- if (msg_opc ==
- VIRTCHNL_OP_INLINE_IPSEC_CRYPTO &&
- imsg->ipsec_opcode ==
- INLINE_IPSEC_OP_EVENT) {
- struct virtchnl_ipsec_event *ev =
- imsg->ipsec_data.event;
- desc.subtype =
- RTE_ETH_EVENT_IPSEC_UNKNOWN;
- desc.metadata = ev->ipsec_event_data;
- rte_eth_dev_callback_process(dev,
- RTE_ETH_EVENT_IPSEC,
- &desc);
- return;
+ /* check for unsolicited messages i.e. events */
+ if (info.msg_len > 0) {
+ switch (msg_opc) {
+ case VIRTCHNL_OP_INLINE_IPSEC_CRYPTO: {
+ struct inline_ipsec_msg *imsg =
+ (struct inline_ipsec_msg *)info.msg_buf;
+ if (imsg->ipsec_opcode
+ == INLINE_IPSEC_OP_EVENT) {
+ struct rte_eth_event_ipsec_desc desc;
+ struct virtchnl_ipsec_event *ev =
+ imsg->ipsec_data.event;
+ desc.subtype =
+ RTE_ETH_EVENT_IPSEC_UNKNOWN;
+ desc.metadata =
+ ev->ipsec_event_data;
+ rte_eth_dev_callback_process(dev,
+ RTE_ETH_EVENT_IPSEC,
+ &desc);
+ continue;
+ }
+ }
+ break;
+ default:
+ break;
+ }
+
}
/* read message and it's expected one */
--
2.25.1
next reply other threads:[~2022-10-20 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 9:20 Radu Nicolau [this message]
2022-10-24 11:34 ` [PATCH v2] " Radu Nicolau
2022-10-25 7:30 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020092026.3852130-1-radu.nicolau@intel.com \
--to=radu.nicolau@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).