From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEE3EA0552; Fri, 21 Oct 2022 00:09:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83624410FC; Fri, 21 Oct 2022 00:09:40 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 9F5EC40F18 for ; Fri, 21 Oct 2022 00:09:39 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id 3so819101pfw.4 for ; Thu, 20 Oct 2022 15:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=eL5iBWHhDRDAPLzsKeClCVNwA306PHmYpK9QVVf1SQY=; b=oymDTJNsFJ8pwHz5rB5WzuYC0J+ZRAbQZ2/73eH3HE/F7zNIbwmxhh0sZa+S4cUxI/ a7OEkkfyj35Mj5m9poJQhuNwyDdc+awGaYeUaMpIexLKgiT6242H7n5m+rzBiE9thKJj 7yShrygYId7mCRisjgiFLYtufACH02SP531MrCy9TD9X/4YZbE+CBJ0FbQRPP/HZsVib 4oApiJsxjzjIYarIyH9wTfekFLaMI3yAxK8L8DdqO68JC3pK4Re1DzTscA7DGjaehLd4 4T5ZoLnxvpJmt9yF3o9BKyy/ICVSZ8lZN+yYY9Z2J9om8zDrAAFE0RE81fCPqJbK//Fd 40HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eL5iBWHhDRDAPLzsKeClCVNwA306PHmYpK9QVVf1SQY=; b=idBcHbFQNsfSAV4ldBClDSsUPbyJeUdN/qHtejj9QQFdEKtYX933Snk975UrgItWbV EGP/6bSm2rD5aBRTyc/4iPdoq+nb7Fr4+I4JTKa5zPWBmPypv9iZ1PwAB/JmcRBCIzLZ 9lRAT23pTsXdo7xcyvqAwZdPGqbLcqhbRScL7JFYE70oTnNoEbhv/Ne3mBv3EEkNMXp6 AAEURP/+fEzMDvNjkSp5CAU7qOWin5F1vB5bALt8empz/8AYYU6UEPI2of6z3iqJhkcG Hes62b9vnEZPSUjQCzCk6douzX/fDSSUgPBQT3Sv+Fu8U779+ILrgfgnAOIrssOcxGbO iX0g== X-Gm-Message-State: ACrzQf3F6d5yGpVVXkuVq5SPgiyJfL6laQWN2qwPb0xQttAEU+ZCyoUE 5Fu66sX3+nzUGTSd/V4BDzWFlw== X-Google-Smtp-Source: AMsMyM7UnCCb9/KNFxnDITMXmF2mGTG0bK9996Qy1vGsq/vOIoHfW60qOHMj3ir4i72mqfNsYG4X5w== X-Received: by 2002:a05:6a00:acb:b0:555:ac02:433e with SMTP id c11-20020a056a000acb00b00555ac02433emr16143409pfl.3.1666303778787; Thu, 20 Oct 2022 15:09:38 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id j12-20020a17090aeb0c00b00205ec23b392sm323937pjz.12.2022.10.20.15.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 15:09:38 -0700 (PDT) Date: Thu, 20 Oct 2022 15:09:37 -0700 From: Stephen Hemminger To: Feifei Wang Cc: David Hunt , dev@dpdk.org, nd@arm.com, Ruifeng Wang Subject: Re: [PATCH v1 3/3] examples/l3fwd-power: enable PMD power mgmt on Arm Message-ID: <20221020150937.1f5b262c@hermes.local> In-Reply-To: <20220825064251.2637274-4-feifei.wang2@arm.com> References: <20220825064251.2637274-1-feifei.wang2@arm.com> <20220825064251.2637274-4-feifei.wang2@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 25 Aug 2022 14:42:51 +0800 Feifei Wang wrote: > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index 887c6eae3f..2bd0d700f0 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -432,8 +432,16 @@ static void > signal_exit_now(int sigtype) > { > > - if (sigtype == SIGINT) > + if (sigtype == SIGINT) { > +#if defined(RTE_ARCH_ARM64) > + /** > + * wake_up api does not need input parameter on Arm, > + * so 0 is meaningless here. > + */ > + rte_power_monitor_wakeup(0); > +#endif > quit_signal = true; > + } > This method is problematic. There is no guarantee that power monitor is async signal safe.