From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AC99A00C5; Mon, 24 Oct 2022 05:14:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE29F40A89; Mon, 24 Oct 2022 05:14:27 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2088.outbound.protection.outlook.com [40.107.101.88]) by mails.dpdk.org (Postfix) with ESMTP id 6B30140A7E for ; Mon, 24 Oct 2022 05:14:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FhJ/mPeKw+YuaaVcf66mVeWp20OizcZFeiXCdNJPJIR/f3Gcbmh3Dxljw8Fn6wscgCT3Ug6NZwCFj57I9Yq7VSnz31w0fKeMKG1mC7vDEsW1cS4Xe0DH+nORBcW/MJeVxHzzLD3gpMaWibzA/BdPZTKiEGHp5WAckrYDQDtx2iR9I9TiwCrRUJ2VIUEh6Ky85HHU3c1g1UKvsLopdiKMvhpOW5kso+Rg0Euk/F1TQ+8dH59IveKGkhiNWvvTT9KsONQAReCrONriRvSr6VMWutwhl45rRhPI67o1Sxz/Xao70v6VwEo5yJ244v360alDiKlNzIQcpLPueCE48eicng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ApfbAnsw7mNNkg6iMwqtL+v2erl1PP4j1BLSj+BqPm8=; b=moAetvw4Pvo5Xqqg2LFIFBuGtozSszsnUTKr9Tb/24bLWM1yJXfpQajwLqAZEE1HhTfEt0oPmbwUdKrjFB0eWc0wqX7HeSSUGQO4XtcXN53njSezVMHagY5gCOVlX3Nj+ZM6kRhdHEUFOH5kkr0LfEaHvkLni6SeJv9kqKuCPWHhFVli3bJCBKuePtIODEEPxJFhudz/pkib6qGD0xNMyhPIwK5e2Sc+uzjHF0ayqCCt/9n3E+EphKyw2z9u292lxXrigux6+pBtTtf2LzDyAdztFLVjYDqKaW76HcmpwXmg8XP1SR5NU8P3oWHUnBi2uVKkepLJwMba3kIMe3PEaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ApfbAnsw7mNNkg6iMwqtL+v2erl1PP4j1BLSj+BqPm8=; b=QmzqdYfmSVY8958TVlPxaqtlTFD71cfLbb+DYbR/I3zqRPW0njxVs4ARmrHPGqk+/ArhNgxEemYYAbAHADFSLOScdg0ZJU5IspM4mixSZbTwh1M1BR7bZnO4zkLyHrT0yFBMGtkompV8QizqY+MUl9zELbYJ6svadY2QIoyGB6YsxCOmmCVb/8DE/zPMT6SrJio6l3d5T/xYBM2Egh1tNwSOtN6uVK4VkJmBXqS9MbPqLKZfoCGWKhGISt8K+oY70Og+JXu3VXtWr989ZYpH47A0FUk9bv3lxzA5d2bWUxlMXz+oy9rNad/qCbhM9lsRmBzI5FEZHlJEyR66UA4n6Q== Received: from DM6PR11CA0059.namprd11.prod.outlook.com (2603:10b6:5:14c::36) by SJ0PR12MB6781.namprd12.prod.outlook.com (2603:10b6:a03:44b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct 2022 03:14:24 +0000 Received: from DM6NAM11FT099.eop-nam11.prod.protection.outlook.com (2603:10b6:5:14c:cafe::51) by DM6PR11CA0059.outlook.office365.com (2603:10b6:5:14c::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend Transport; Mon, 24 Oct 2022 03:14:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT099.mail.protection.outlook.com (10.13.172.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 03:14:23 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Sun, 23 Oct 2022 20:14:23 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Sun, 23 Oct 2022 20:14:20 -0700 From: Spike Du To: , , , CC: , Subject: [PATCH] app/testpmd: fix testpmd crash when quit with mlx5 avail_thresh enabled Date: Mon, 24 Oct 2022 06:14:03 +0300 Message-ID: <20221024031403.1572010-1-spiked@nvidia.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT099:EE_|SJ0PR12MB6781:EE_ X-MS-Office365-Filtering-Correlation-Id: f172dc0f-f95f-4fe2-be21-08dab56dda01 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0w1Zs38p86aOKAKDtioiB27IlxlrdINdFSPn3hrVFp4TryL/+yAAwuOyb8RpKdR+UQ3BTwgN8mvr7c8KygWsb9z2Z+2PCo6v+Vvfp1l/MnhRA5dUH/U56vtcg2xfDcYTWycc9DdbLi8tEFTR+W0s34E1T16JIDPsJ3skwTTx1Eo2qB6fsi4jVZObPfYKp0Dv0fKEgfq/BN5MzrPJFqT/yuaFHbW938Dc16j5kBMhVaAPWq5SvjlLH18z/TodjkZcNI3TOuby46/JUfy0TBCmWyywwVtpkTa7MbEKB7wLPYM71eag59i9IK1qAZoknNhns2Jv/bmjgZqccjI1NB+YS//5xKWWT2qJuM2TuBNfD1dvs99oNinWsaWZzQRVMSI22EuvtOsX52XH0hSYS0cB3S/DO8QTxaQvLzRGn/y8v6aTC0nPM/V9xShQXGOMTKOTCY8dJAb0chyfPALDD0FhTHRJ72Ra50M5b2hn8MxvS6XvHZ1qflDAztbxyABSaRr8ii8UNK47s+4ty+KLKFpA8PxQxCuv5WoSp0JYwestZl9Abtmv7lvfR8zHBGSS1VFPN2SyUDJgKZv8hurPfWhnXJC7XPZmf9wE/FWNVryHCj1wIMsxa/qbARFtnUuXnW153Af5AVYsFKS3jJtjYXU3I5NszyEtDvf4r80uzFSgJYkbzfO9V1XKLJhpkTCQDh89E3fKaZdRJA3YmXzdEnji1zaqYRq0/Xewr0Syb1qufA3aKf4kPWO/1A7JvU4NZbs2P+yyXVYbakHFO+tzYc1tQg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(7636003)(356005)(478600001)(82310400005)(82740400003)(36756003)(54906003)(47076005)(426003)(8936002)(40480700001)(55016003)(6666004)(107886003)(110136005)(36860700001)(316002)(6286002)(26005)(41300700001)(86362001)(336012)(70586007)(2616005)(16526019)(1076003)(40460700003)(186003)(2906002)(5660300002)(7696005)(4326008)(8676002)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 03:14:23.8237 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f172dc0f-f95f-4fe2-be21-08dab56dda01 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT099.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6781 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler delays to reconfigure rx queue to re-arm this event. However at the same time, testpmd is destroying rx queues. It's never a valid use case for mlx5 avail_thresh. Before testpmd quit, user should disable avail_thresh configuration to not handle the events. This is documented in mlx5 driver guide. To avoid the crash in such use case, check port status, if it is not RTE_PORT_STARTED, don't process the avail_thresh event. Fixes: 0edfc9b08316 ("app/testpmd: add Host Shaper command") Signed-off-by: Spike Du --- drivers/net/mlx5/mlx5_testpmd.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx5_testpmd.c b/drivers/net/mlx5/mlx5_testpmd.c index ed84583..1a9ec78 100644 --- a/drivers/net/mlx5/mlx5_testpmd.c +++ b/drivers/net/mlx5/mlx5_testpmd.c @@ -25,6 +25,7 @@ static uint8_t host_shaper_avail_thresh_triggered[RTE_MAX_ETHPORTS]; #define SHAPER_DISABLE_DELAY_US 100000 /* 100ms */ +extern struct rte_port *ports; /** * Disable the host shaper and re-arm available descriptor threshold event. @@ -39,7 +40,15 @@ uint16_t port_id = port_rxq_id & 0xffff; uint16_t qid = (port_rxq_id >> 16) & 0xffff; struct rte_eth_rxq_info qinfo; + struct rte_port *port; + port = &ports[port_id]; + if (port->port_status != RTE_PORT_STARTED) { + printf("%s port_status(%d) is incorrect, stop avail_thresh " + "event processing.\n", + __func__, port->port_status); + return; + } printf("%s disable shaper\n", __func__); if (rte_eth_rx_queue_info_get(port_id, qid, &qinfo)) { printf("rx_queue_info_get returns error\n"); -- 1.8.3.1