From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8EA59A034C; Mon, 24 Oct 2022 14:33:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B439142B8F; Mon, 24 Oct 2022 14:33:53 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2069.outbound.protection.outlook.com [40.107.223.69]) by mails.dpdk.org (Postfix) with ESMTP id 5F22E42B83; Mon, 24 Oct 2022 14:33:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hrx4tcfXJjTOgYU8XXtmBCsBABrOkF2IBhQLDXQSgsHXOMhgtws8+BTTSMmJUGF4Kp3B62wJOhQ0JxZgFJVJ6hT034l5Bw4tDYKcBFp42V4q8+kFZeZB9QqAMOkVi954lT0u0nY7FPkvdkqZS90EB9gjkm2yC0bv84V07Ya9L1XUDPYdr2gPFmwCj4A9FBCgOYFqRGiRMYFismImY/zTuxCR4y0tXkjZok/CJ2Enm4UPofq/C6IzE/HtbtJsvfVZpuf6gAL9Zc2REWRHJkRFIQRAzZXqrywGHcElnsASELkBTeVP4vQ44degX3bzyMZ1RjaP9Iu7NSwN5bNDvgWI7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n6YXWB9IQMdzaKQUNGAMESeOu1esm1utSgORH/sq9No=; b=QsJufov+EOb3jYh9lJOwW0Qfidrrt695jOYEXKqBz+gZhdelsx0PR6YAvpFJnY4524B9aOpUmC6/TvPMbLuuRQR+UGqI4GNIXiy4aigWj1YLxqFFMZgy2BVWVHHL0X5rWbWkjDnX/JwqWu+TWwxrl0Uv1HoADEen8cXL7oO+c2qpVJU/QkM02z0GeV4vlvERjZGxNo1zxBtUWF0SWltBeEYkBmWVoRJORsZn8WWmzrvjDSar5udodHg+103EsPEwxgZc3QHg/ySI4yn2pl7SKUdpTaoIWnmAci0hlD1IcbIzlqnyBm9woH8kc6mPjZlzRiXYo6RVwlz12yZgQtjiWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n6YXWB9IQMdzaKQUNGAMESeOu1esm1utSgORH/sq9No=; b=B0XQu8PO03jPvgB6xYTRSgntbH0jzwnsI55zHzxKHGNJHOKyEkL1jL+4lbEQRkW5F6/1mZtRkTwaryogRSIDiyKeZmX7ZUieAkDiXomQXngZ1MlTwPYHPhEtJWx20ve9jjqhZMG8wpTyxJ1PA+OLAkzvA8VFAk3jYHKT9T6bDdfdCEDzoqD3QpLi0H/htC7Bgo2giU4j89IO4dzpINXwIz5bKP8MeZTtCn+6fJa8M6XTJV5xWy7n9xsAEBufTp79l65GLj7UoG0BqRlK40pwCQ8Ofhucyxvck1MTii+b9zxsBMjFqjzHQbFqaTwd7R6hTZScUhgzn4AOAtP5BEkPfA== Received: from MW4PR03CA0015.namprd03.prod.outlook.com (2603:10b6:303:8f::20) by MN2PR12MB4318.namprd12.prod.outlook.com (2603:10b6:208:1d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.40; Mon, 24 Oct 2022 12:33:49 +0000 Received: from CO1NAM11FT058.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8f:cafe::3a) by MW4PR03CA0015.outlook.office365.com (2603:10b6:303:8f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.26 via Frontend Transport; Mon, 24 Oct 2022 12:33:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT058.mail.protection.outlook.com (10.13.174.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 12:33:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Mon, 24 Oct 2022 05:33:45 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 24 Oct 2022 05:33:45 -0700 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29 via Frontend Transport; Mon, 24 Oct 2022 05:33:43 -0700 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , , Subject: [PATCH 2/2] net/mlx5: fix miss null check in ETH devargs parsing Date: Mon, 24 Oct 2022 15:33:35 +0300 Message-ID: <20221024123335.3163331-3-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221024123335.3163331-1-michaelba@nvidia.com> References: <20221024123335.3163331-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT058:EE_|MN2PR12MB4318:EE_ X-MS-Office365-Filtering-Correlation-Id: 1eaeb0bd-798d-46e5-2115-08dab5bc007e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G9FY/Ex4R1vKv9AxPrmINTLqlXtg/2bHMoZuLZnJav5HGPuv3DdF0bma8DKSKiKUaN94RzSb0DQMII9eSNVOd3EOfamMt9z2ag4PJSvzg+t4TPdlwdSSntivghFFdaQdw+2jVQ8lwLSu7/dYA3WkyiTucSMkWno5Lm6dVpGV3rfSdy5GZzNkr4B3YQ8yWbjyvZzsOXhfl2f9x6BsHZVu40PC9GV3klNBukbtNPHPq8zvBCni/+tbNifs8dS7ZLJhcpyJa6eGzSxXqJg9LTbGZdSbN5X2IYfrNQXLDomUxw8Cu+wPzm8feKwfdJ9c1I+3dcItrXFMfcpesBLylQNtYlPKPYzaQckoDe/Nh1dRV3xWE/xwwmxMmSeYbDf+4/cKYa2JYSWSpxsmY9D3VeVRe+x1+SWIrCaQ09Dj8pyzh2cKgvoUWljsH+MiPcxVp9cQJmYCJ/7Os+J+sEv23sRDOmyMOyXrUtHDyCxcGct44z1gufVWSNWbIgScuVyJga2mLO2Osm1iK96PJCo+q3CwLtOio7iy7Uw5fnmKVxQic2SsqE7e4KgDdpygKnSqgsL8/UNx9y8+NL9128Ldzi29Li8/9bQFjanT7wnI67S5nsZNJgIonIiRRqq88BfUshBmQIYb836bMFQjXPDjGQ4/buHdSkoRCNhFt7AVXaivrl2J/zS1V/Jbe2ii2op5WeE6HlVmBcN4aOHBkWhoNE6/M9wKWYQlZnG8NgagAJkwoREbwtvT98yuS7sVJtcAA/scYeQ5uE4O+qJwF/94EAuIvg== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(396003)(346002)(376002)(451199015)(46966006)(36840700001)(40470700004)(6666004)(316002)(36860700001)(450100002)(2906002)(54906003)(47076005)(6916009)(8936002)(55016003)(426003)(40480700001)(26005)(6286002)(2616005)(186003)(40460700003)(1076003)(70586007)(336012)(4326008)(8676002)(5660300002)(70206006)(86362001)(41300700001)(83380400001)(36756003)(7696005)(356005)(478600001)(7636003)(82740400003)(82310400005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 12:33:49.1373 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1eaeb0bd-798d-46e5-2115-08dab5bc007e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT058.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4318 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The "mlx5_os_parse_eth_devargs()" function parses the ETH devargs into a specific structure called "eth_da". It gets structure called "devargs" as a member of EAL device containing the relevant information. When "devargs" structure is invalid, the function avoids parsing it. However, when it valid but its field "args" is invalid, the function tries to parse it and dereference to NULL pointer. This patch adds check to avoid this NULL dereferencing. Fixes: 919488fbfa71 ("net/mlx5: support Sub-Function") Cc: xuemingl@nvidia.com Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index ab7ffa0931..2b6741396d 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -2411,7 +2411,7 @@ mlx5_os_parse_eth_devargs(struct rte_device *dev, dev->devargs->cls_str); return -rte_errno; } - if (eth_da->type == RTE_ETH_REPRESENTOR_NONE) { + if (eth_da->type == RTE_ETH_REPRESENTOR_NONE && dev->devargs->args) { /* Parse legacy device argument */ ret = rte_eth_devargs_parse(dev->devargs->args, eth_da); if (ret) { -- 2.25.1