From: Jie Wang <jie1x.wang@intel.com>
To: dev@dpdk.org
Cc: stevex.yang@intel.com, qi.z.zhang@intel.com,
qiming.yang@intel.com, aman.deep.singh@intel.com,
yuying.zhang@intel.com, Jie Wang <jie1x.wang@intel.com>,
stable@dpdk.org
Subject: [PATCH] app/testpmd: fix testpmd receive jumbo frame packets
Date: Tue, 25 Oct 2022 10:05:10 +0800 [thread overview]
Message-ID: <20221025020510.117132-1-jie1x.wang@intel.com> (raw)
For NIC I40E_10G-10G_BASE_T_X722, when testpmd is configured with
link speed, it cannot receive jumbo frame packets.
Because it has changed the link status of the ports if it was
configured with link speed.
When exiting testpmd that it automatically stops packet forwarding
and stops all the ports. But it doesn't update the link status of the
ports. If stop the ports first that it will update the link status.
This patch fix the error that testpmd will update the link status of
the ports when it exits.
Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM")
Fixes: 284c908cc588 ("app/testpmd: request device removal interrupt")
Cc: stable@dpdk.org
Signed-off-by: Jie Wang <jie1x.wang@intel.com>
---
app/test-pmd/testpmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 97adafacd0..c348a3f328 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3548,7 +3548,7 @@ pmd_test_exit(void)
}
#endif
if (ports != NULL) {
- no_link_check = 1;
+ no_link_check = 0;
RTE_ETH_FOREACH_DEV(pt_id) {
printf("\nStopping port %d...\n", pt_id);
fflush(stdout);
@@ -3675,7 +3675,7 @@ rmv_port_callback(void *arg)
need_to_start = 1;
stop_packet_forwarding();
}
- no_link_check = 1;
+ no_link_check = 0;
stop_port(port_id);
no_link_check = org_no_link_check;
--
2.25.1
next reply other threads:[~2022-10-25 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 2:05 Jie Wang [this message]
2022-10-27 15:37 ` Singh, Aman Deep
2022-10-28 2:30 ` Wang, Jie1X
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025020510.117132-1-jie1x.wang@intel.com \
--to=jie1x.wang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).