From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C05DA0543; Tue, 25 Oct 2022 09:51:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B86D541143; Tue, 25 Oct 2022 09:51:31 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 63118400D6 for ; Tue, 25 Oct 2022 09:51:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666684290; x=1698220290; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=vJRcfjMg8ZKAjM3XzOJWo13xjo6G6kM6OxWnjQtr1UM=; b=PORoQ36aaWVf0h3TwE0DWOZToW8I1T9jgtNF2Pd3qECH/rRhYUQ+xZly jd6UQW38g+G5SMARLn68EcfNDCLGBQ7aWLPWtrxp161nNBfbgMmAPuyUZ YF8a0qqY8Vom/T0eL1ACg71d9ir/M+5jIb1HB7xwr7XZClak14LB4x8Z2 rZxe8Xpqvv7gw8OnwNt89qNJkMS0COCY+4nYtp+d50UMT3TG7vmrnGIgB Re+AGajrti8xIw4XuUOR4WWaiSS1xbSx64ezRKVTQH9kQADHs4Io+K53H V97xn+JzER8ii+5lBdXIRXIa461Ka5hW1MoQGYTcX732KJ/WAmvIruWop A==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="371829496" X-IronPort-AV: E=Sophos;i="5.95,211,1661842800"; d="scan'208";a="371829496" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2022 00:51:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="631544789" X-IronPort-AV: E=Sophos;i="5.95,211,1661842800"; d="scan'208";a="631544789" Received: from unknown (HELO localhost.localdomain) ([10.190.193.12]) by orsmga002.jf.intel.com with ESMTP; 25 Oct 2022 00:51:27 -0700 From: Abhishek Maheshwari To: abhishek.maheshwari@intel.com Cc: dev@dpdk.org, chenbo.xia@intel.com, purna.chandra.mandal@intel.com Subject: [PATCH] vdpa/ifc/base: wait for queue disable before saving q-state Date: Tue, 25 Oct 2022 12:53:02 +0530 Message-Id: <20221025072302.1683505-1-abhishek.maheshwari@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Some ifc hardware require synchronization between disabling a queue and saving queue-state from LM registers. When queue is disabled from vDPA driver, ifc device stops executing new virtio-cmds and then updates LM registers with used/avail index. Before saving the queue-state, vDPA driver should wait until the queue is disabled from backend. Signed-off-by: Abhishek Maheshwari --- drivers/vdpa/ifc/base/ifcvf.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c index f1e1474447..fb51c793a2 100644 --- a/drivers/vdpa/ifc/base/ifcvf.c +++ b/drivers/vdpa/ifc/base/ifcvf.c @@ -257,6 +257,7 @@ ifcvf_hw_disable(struct ifcvf_hw *hw) u32 i; struct ifcvf_pci_common_cfg *cfg; u32 ring_state; + int q_disable_tries; cfg = hw->common_cfg; if (!cfg) { @@ -275,6 +276,20 @@ ifcvf_hw_disable(struct ifcvf_hw *hw) continue; } + /* Some ifc hardware require synchronization between disabling a queue + * and saving queue-state from LM registers. + * When queue is disabled from vDPA driver, ifc device stops executing + * new virtio-cmds and then updates LM registers with used/avail index. + * Before saving the queue-state, vDPA driver waits until the queue is + * disabled from backend. + */ + q_disable_tries = 10; + while (q_disable_tries-- && IFCVF_READ_REG16(&cfg->queue_enable)) + msec_delay(10); + + if (IFCVF_READ_REG16(&cfg->queue_enable)) + WARNINGOUT("Failed Q disable: %d. saved state is invalid\n", i); + if (hw->device_type == IFCVF_BLK) ring_state = *(u32 *)(hw->lm_cfg + IFCVF_LM_RING_STATE_OFFSET + -- 2.31.1