From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E9A92A00C4;
Sat, 29 Oct 2022 00:51:22 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 876EC40151;
Sat, 29 Oct 2022 00:51:22 +0200 (CEST)
Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com
[209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id B4E2040146
for <dev@dpdk.org>; Sat, 29 Oct 2022 00:51:20 +0200 (CEST)
Received: by mail-pj1-f41.google.com with SMTP id
z5-20020a17090a8b8500b00210a3a2364fso8896113pjn.0
for <dev@dpdk.org>; Fri, 28 Oct 2022 15:51:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=VPRDllKhsCP3SyQebQmN8eQZfjJqJfpVY3hjjnBW30U=;
b=Fjqog6AMNa4uESIPPYWPtqORdxHzGy4jN0jUvVdQeGo8bxO3xvAkobIQTa7dRw1Umm
kdTRwHC22rJeJUzHxCfyKULLbQ8na4fAFOIJUQ/G3QrqYWv3gx0/cjmu47T3XDPV4Aub
bE5z/orjjZzzKlixHYKFbImpxyB/3+1f4sq8N+2OcH08mrYatJTXmFQ/SAJkSAk/JP1n
JaoCffKhD0S0X+wyMaqn609vE9N0Dh5aNxu6HBS5dKnzaEb2otPpLd7r1Gx0fXE6B9YX
YLBgk1DDkmYRNq9DlhHRs21+Ht1ScRMSumjpLvcKN6tImjZgUHijPd1LmR9iPjNmUoYC
h6gQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=VPRDllKhsCP3SyQebQmN8eQZfjJqJfpVY3hjjnBW30U=;
b=fwtuXo7xZyPvlnpUtxIhAkRqRHI/l6lHwD5yjgovMwi+wRhz3GJSAEYkTOfY3Iwoa+
EEvdzU+bvkB6AYPvQCdgKJza+4d7rqahzPu84r/9pmfzQTdfN3c/aesDXsiQbCVACITt
K/earxAhIBFC+uTgxplhmg9+JqZVW7koao46jtQ9D3mBuXVSL+zGRW5cELEkrJaKPYlW
D61Aw/DybNBMR3acxrLMn+kbXf9YNHDJKt7A505waucGddqJgRacY8jFMEQIUM7wqejW
DdM+9Re++gwyBfaG3xu5l/YJQk5VHWDcN6HR6I5SLFfjt/0uOUpa8Yu+ufyvE5OnfhtX
kcbQ==
X-Gm-Message-State: ACrzQf1HKKYNI8puPkX9+RyMRzVoH7ftAimMoAyQU9fd8oKHPzRPImHd
YCeVgR7FQYVYrfMVyuVZO0VWFA==
X-Google-Smtp-Source: AMsMyM67af0DSobgcvScjZM5Oh9E5sEsOL8zS84nlB1SF+BmFH7ituzjjoWRGMvLPiGnIqJn6YqrAQ==
X-Received: by 2002:a17:902:6bc6:b0:183:e8a2:9760 with SMTP id
m6-20020a1709026bc600b00183e8a29760mr1308740plt.157.1666997479837;
Fri, 28 Oct 2022 15:51:19 -0700 (PDT)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
by smtp.gmail.com with ESMTPSA id
x7-20020aa79407000000b00561dcfa700asm3321901pfo.107.2022.10.28.15.51.18
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 28 Oct 2022 15:51:19 -0700 (PDT)
Date: Fri, 28 Oct 2022 15:51:17 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <dmiller423@gmail.com>
Cc: dev@dpdk.org, Mathew S Thoennes <tardis@us.ibm.com>, Konstantin Ananyev
<konstantin.ananyev@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>, Aman
Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>,
Olivier Matz <olivier.matz@6wind.com>, Yipeng Wang
<yipeng1.wang@intel.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Bruce
Richardson <bruce.richardson@intel.com>, Vladimir Medvedkin
<vladimir.medvedkin@intel.com>, Neil Horman <nhorman@tuxdriver.com>, Dmitry
Kozlyuk <dmitry.kozliuk@gmail.com>, Beilei Xing <beilei.xing@intel.com>,
Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko
<viacheslavo@nvidia.com>, Haiyue Wang <haiyue.wang@intel.com>, Jakub
Grajciar <jgrajcia@cisco.com>, Harman Kalra <hkalra@marvell.com>
Subject: Re: [PATCH] Add support for IBM Z s390x
Message-ID: <20221028155117.2880b051@hermes.local>
In-Reply-To: <20221028215240.103365-1-dmiller423@gmail.com>
References: <20221028215240.103365-1-dmiller423@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Fri, 28 Oct 2022 17:52:40 -0400
David Miller <dmiller423@gmail.com> wrote:
> +#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
> + switch (type) {
> + case RTE_UINT8:
> + {
> + uint8_t *temp = (uint8_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_UINT16:
> + {
> + uint16_t *temp = (uint16_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_UINT32:
> + {
> + uint32_t *temp = (uint32_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_INT8:
> + {
> + int8_t *temp = (int8_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_INT16:
> + {
> + int16_t *temp = (int16_t *)&result;
> + result = *temp;
> + break;
> + }
> + case RTE_INT32:
> + {
> + int32_t *temp = (int32_t *)&result;
> + result = *temp;
> + break;
> + }
> + default:
> + break;
> + }
> +#endif
You are indenting with 4 spaces.
The DPDK uses tab indentation like the Linux kernel.
Surprised that checkpatch isn't catching this.