From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3E2EA0540; Mon, 31 Oct 2022 17:09:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA31D427ED; Mon, 31 Oct 2022 17:08:52 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 2D561427EA for ; Mon, 31 Oct 2022 17:08:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eviymSqNKw/sS/yT8z0o8e4MG148TS7PEJe+BT27Pk9Hf93JBUO0iRTx9WgDwmUQP0OAX4dox1oijG8WbM2pNDwmG6CMtrUYA5l6ReXrwsljX8r3cf1m0wgNFfWU1rtFRVmAKXLR2kYyp4bPdlpjExbvJPerj5GCA1HHR5fc6b9yAO/m1zcc31nne+0LnMn/8RZB2s6W4lTy4J7EPOnBtTOjnAdBjessH+/mKDr0y1KINW9X0+kpE9cxOHOG0vsg9JdjIcDf5HHCFvhr3hMVgiVcCD7Ubi+mYsGcjzifiDrqQq1AgDoz2HJcrZKO3bGkdNlUBr7KxRJHXMAPLwhdbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ih5ZgqWjqLg8Zmhc5NqbUthU6YqEM/d6Zhyg8BiwLGI=; b=mZmJHtBWpf5XElcwZlTlpY78ilgOGQ2bJjwE4g3VyEE1soILmdpmJk7sH91BF2hrCwIn6uvv2WT8436CFC9gFQDpRC+bEZCwk8uSNrD0WUpzSQa5hQ7Pp3TT7IA9QIKNkJzu3wm9LlnVZ0r85q7qUt26hWYycdlet+8xZzkfBQWrk8/jOSTjTyZj3QRT8eKlJgJizXBtEUwimGlHf62YEAlzAwE04C0MFdHdoCMYrqa6G4CRT/yhVEgnhfHpHX+ytUIMk0vBILCJo8/f2Ptn29k3/F7urx2pkyu36/OachL1USGPhUuwhOvobCi6t+IXtENWgrNssYlZPy7OZYUd+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ih5ZgqWjqLg8Zmhc5NqbUthU6YqEM/d6Zhyg8BiwLGI=; b=H0scpUsNXBLQaZcpAbmGwfxtDG7AyJDQMtyLz7tOIS2ufubIB7mDIwTC5Xbxl70p2ZRcpkxLvd0JtVUztxaXb1eLMPScKYIMKgJZRpQC+7LujIrCqXOnw0PDcr3KZVUzoEExl5iZb42lxvJq45A8KR2/i9qgJZr6xEGV8PIO0A+HmWHnXEa09IREe+hz/XOD0b1UfGNw+IJcBzssQj+fw+j1VCzY1fnyLvr37erSsLqgDagYBOkHNGuMSeGTSccG4a++8us+TRiTNtpeURh0OqIN6u3sYoKLIkCmQBNDHklUsBHKysTNLX/k/tPgiHRgAa6hBl73fGJ+hr90eUOXBw== Received: from BN0PR04CA0011.namprd04.prod.outlook.com (2603:10b6:408:ee::16) by DM8PR12MB5414.namprd12.prod.outlook.com (2603:10b6:8:3e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Mon, 31 Oct 2022 16:08:47 +0000 Received: from BN8NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ee:cafe::ae) by BN0PR04CA0011.outlook.office365.com (2603:10b6:408:ee::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend Transport; Mon, 31 Oct 2022 16:08:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BN8NAM11FT069.mail.protection.outlook.com (10.13.176.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 16:08:47 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Mon, 31 Oct 2022 09:08:37 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 31 Oct 2022 09:08:36 -0700 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29 via Frontend Transport; Mon, 31 Oct 2022 09:08:35 -0700 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Xiaoyu Min Subject: [PATCH 4/5] net/mlx5: add assertions in counter get/put Date: Mon, 31 Oct 2022 18:08:23 +0200 Message-ID: <20221031160824.330200-5-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221031160824.330200-1-michaelba@nvidia.com> References: <20221031160824.330200-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT069:EE_|DM8PR12MB5414:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e62456c-a87b-40a2-47c4-08dabb5a3171 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oDIHOT98HHnV7zrJvjVk82ujezIqJzODd6mQYo7ZELqhQLFq1gR5GJZaynDhVc5wj6V3+U5dDrv9/ArAhYxiFcVUuZGNIjLKVSBbpu8syC5l3uTq+wU6nJ269+d14XJv5hgnXTu1HgaIEYC8Rc5Sh1cAwhiD2CcYR5t3NJ6BdV6uLTPSFxe6jWEAznLl68NzRP+LyvxH9zTe8AZ3UYkGr0DhvT2BMsUJwiRxC5UXquHD+DHZlAWEKSiUB819+C4ZCiV2pYYofWRsD4UUJqVGmKyMSkDUgOOTtSe9BTew34KEWBfY8pzAIkJyJlgtNu6A5oZ0ITTjYH2oxXrq8FBw8Mc61rK2DRzJ12EPwH/dMRSqPH6B9dfp2VUusszatPd6B3w/3DFJTS5oehbUYjrdFQkHJENd9qcLn2ZsdcLRYrbJZLQT0oKEW8gLJqlJzP5OMwly9P9sKmMcbHjU9mUpp7yCGsTC806EKXe3ZFj4a0ut5lfQB26KRU0HdS87zRS1YF05+ghUNlaJYcbMXmIMhZJrK/mRZEZfqiRUZUAAqhaJ4+QH5Bt4+FkppBJhTClgM5O+koQSF62RVxgm9jNchVJJuMeteq3+XNzOR3j4DnQJ4HQ4fZNyyvtZSvyf2y1f6qnJqx8i0xFTbhLTDvkv1aYEXq7sVA7pwePelBb449DEPPPElMZgoQSoVNfxqUSThHVZP6iFl69WbdStYuPrjugAQEtA+wlv9cJrtPXHiKp5oyYuWHA3swiB3nm3IcnusDkfvtBeh4ixKUqyOzVVAA== X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(40470700004)(46966006)(36840700001)(70586007)(70206006)(356005)(316002)(41300700001)(6916009)(7636003)(82310400005)(54906003)(107886003)(8936002)(7696005)(2616005)(36860700001)(5660300002)(6666004)(55016003)(40480700001)(426003)(478600001)(47076005)(186003)(4326008)(8676002)(82740400003)(1076003)(336012)(26005)(86362001)(6286002)(36756003)(40460700003)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 16:08:47.5429 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e62456c-a87b-40a2-47c4-08dabb5a3171 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5414 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add assertions to help debug in case of counter double alloc/free. Signed-off-by: Michael Baum Acked-by: Matan Azrad Acked-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_hws_cnt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.h b/drivers/net/mlx5/mlx5_hws_cnt.h index 6e371f1929..338ee4d688 100644 --- a/drivers/net/mlx5/mlx5_hws_cnt.h +++ b/drivers/net/mlx5/mlx5_hws_cnt.h @@ -396,6 +396,7 @@ mlx5_hws_cnt_pool_put(struct mlx5_hws_cnt_pool *cpool, uint32_t iidx; iidx = mlx5_hws_cnt_iidx(cpool, *cnt_id); + MLX5_ASSERT(cpool->pool[iidx].in_used); cpool->pool[iidx].in_used = false; cpool->pool[iidx].query_gen_when_free = __atomic_load_n(&cpool->query_gen, __ATOMIC_RELAXED); @@ -475,6 +476,7 @@ mlx5_hws_cnt_pool_get(struct mlx5_hws_cnt_pool *cpool, uint32_t *queue, __hws_cnt_query_raw(cpool, *cnt_id, &cpool->pool[iidx].reset.hits, &cpool->pool[iidx].reset.bytes); + MLX5_ASSERT(!cpool->pool[iidx].in_used); cpool->pool[iidx].in_used = true; cpool->pool[iidx].age_idx = age_idx; return 0; @@ -511,6 +513,7 @@ mlx5_hws_cnt_pool_get(struct mlx5_hws_cnt_pool *cpool, uint32_t *queue, &cpool->pool[iidx].reset.bytes); rte_ring_dequeue_zc_elem_finish(qcache, 1); cpool->pool[iidx].share = 0; + MLX5_ASSERT(!cpool->pool[iidx].in_used); cpool->pool[iidx].in_used = true; cpool->pool[iidx].age_idx = age_idx; return 0; -- 2.25.1