From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FDE0A00C2; Tue, 1 Nov 2022 03:25:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7C3740694; Tue, 1 Nov 2022 03:25:08 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id BA17C40685 for ; Tue, 1 Nov 2022 03:25:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667269507; x=1698805507; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=k+GcBXsvqHy6Pg1+VIEkgLCkL/wVeXfoUhXpuBUMH6w=; b=Y9Px3hUrWaf102X9WOCvXRVdXlJQvZeMGqfbBei7mirWPRFgXgYB6RTm +FiMd0Qqk4e8CgbJDWbwAiNAGkLhGDOaDyOwiFPt9R3OQypH412RcjIDZ pVPZPBmkSHootjOpYby0fVw0xIGx/bDw3qSZWa93bhcU3DMstenQfTLiF WgIO1KCW6sk3UmYcyEI3sJBwiwI8zie97nnDNpM4lkenBQe/jESZZMqGf Ch2SlBOy+2UULeELppnSo1w+n3dg6wVAsqSVqzUt0CzM4VsFDlj3+O/P3 XGo56bA08KP3U+Rd53e+NdKKJQTZIs/KOZYXA1MHvatBGEailJcaIWRS4 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="289440391" X-IronPort-AV: E=Sophos;i="5.95,229,1661842800"; d="scan'208";a="289440391" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2022 19:25:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10517"; a="667045570" X-IronPort-AV: E=Sophos;i="5.95,229,1661842800"; d="scan'208";a="667045570" Received: from dpdk-beileix-3.sh.intel.com ([10.67.110.253]) by orsmga001.jf.intel.com with ESMTP; 31 Oct 2022 19:25:05 -0700 From: beilei.xing@intel.com To: jingjing.wu@intel.com Cc: dev@dpdk.org, Beilei Xing Subject: [PATCH] net/idpf: fix compiling error in CentOS 7 Date: Tue, 1 Nov 2022 01:54:44 +0000 Message-Id: <20221101015444.102627-1-beilei.xing@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Beilei Xing There's build error with clang 3.4.2 in CentOS 7: drivers/net/idpf/idpf_vchnl.c:141:13: error: comparison of constant 522 with expression of type 'enum virtchnl_ops' is always false [-Werror,-Wtautological-constant-out-of-range-compare] Fixed the compiling error in the patch. Fixes: 549343c25db8 ("net/idpf: support device initialization") Signed-off-by: Beilei Xing --- drivers/net/idpf/idpf_vchnl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/idpf/idpf_vchnl.c b/drivers/net/idpf/idpf_vchnl.c index 00ac5b2a6b..ac6486d4ef 100644 --- a/drivers/net/idpf/idpf_vchnl.c +++ b/drivers/net/idpf/idpf_vchnl.c @@ -55,7 +55,7 @@ idpf_vc_clean(struct idpf_adapter *adapter) } static int -idpf_send_vc_msg(struct idpf_adapter *adapter, enum virtchnl_ops op, +idpf_send_vc_msg(struct idpf_adapter *adapter, uint32_t op, uint16_t msg_size, uint8_t *msg) { struct idpf_ctlq_msg *ctlq_msg; @@ -118,7 +118,7 @@ idpf_read_msg_from_cp(struct idpf_adapter *adapter, uint16_t buf_len, struct idpf_ctlq_msg ctlq_msg; struct idpf_dma_mem *dma_mem = NULL; enum idpf_vc_result result = IDPF_MSG_NON; - enum virtchnl_ops opcode; + uint32_t opcode; uint16_t pending = 1; int ret; @@ -132,7 +132,7 @@ idpf_read_msg_from_cp(struct idpf_adapter *adapter, uint16_t buf_len, rte_memcpy(buf, ctlq_msg.ctx.indirect.payload->va, buf_len); - opcode = (enum virtchnl_ops)rte_le_to_cpu_32(ctlq_msg.cookie.mbx.chnl_opcode); + opcode = rte_le_to_cpu_32(ctlq_msg.cookie.mbx.chnl_opcode); adapter->cmd_retval = (enum virtchnl_status_code)rte_le_to_cpu_32(ctlq_msg.cookie.mbx.chnl_retval); -- 2.26.2