From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 285ACA00C2; Tue, 1 Nov 2022 20:32:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90C8B40DDB; Tue, 1 Nov 2022 20:32:40 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id D53D840693 for ; Tue, 1 Nov 2022 20:32:38 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id u6so14490400plq.12 for ; Tue, 01 Nov 2022 12:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YxfDBB0DFmDmT1MU4aM6d461duuZ436sHx+Z8oupzFY=; b=iBEays1m95/kuEjRvm9KDWvxmKn71dKoV82EoFVp74ljUR5LTq3lCBo10skBcTSz0o KBbG7O1KOt7tfQg2r06PzsAKjlcB7lNufax1Ou1aCkUHUqx+JMp3RxL1uQANtKqQPvD7 LtmoyZCvxZCEVOSQIGFtDB10pJ9cfi1f8Bn+7UqscifK9DACW8EQXA5yO8IaS52fxzFC o2Kk6P9Vq48BBECzJ4UzafTYZ/Xognx3xlMvau6HjQp1wq9SzYkL+Ljdcrwvq6APiWwh JEUgD5RCajBvT2DqsLTXbyqHbkJvHnFOGpdlwW7Ql0AFUoALIdzKwAi6CjLrBLeb8MLy jZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YxfDBB0DFmDmT1MU4aM6d461duuZ436sHx+Z8oupzFY=; b=RB+ewbqhMzC3drweO2mFE800dJgJwCfOB0FoKF6dGXS3JnTMKtAp+uJSoL0/5sJ/oG UexjgnZE83XnM4wmYy2Y0Hb5n9mJWWW8moBNnYiofk9ZJygaQqFeYsS3Q6SdMbtqWEzm H9xJHQTHSqCl+9l3Gb3Z6lp7L45ZQoSJgG3YdKcTj5e+Ch5oawwdl9ENaO8+z34lWl30 faDU72MD7eJDYJuyuN2s5tZ9VLn5736Sj0ysuONeGQT9NzdXjxbj37emPugb7AcSxgVc psWnhcI8RUliu7tElXx2S1yP8k+iUfcf66QTKkRUv8uWr3pCMBzhYxOsxNLTn/yz1ro1 I3GA== X-Gm-Message-State: ACrzQf3llTjeotA4csTRXYs73Utl01gg2XlafVujFphe31Ze8AcQiKk8 T4k8gBtEo6Zj6ii0KYSaWSJ80g== X-Google-Smtp-Source: AMsMyM6Z2nzRMolbPQp3FWRA2Hw4CE/NmG/4jEE2iuFeYh1DrPPFQ2aXVncheesDSkqcGrEhBelrMQ== X-Received: by 2002:a17:902:dac5:b0:187:411c:4f1a with SMTP id q5-20020a170902dac500b00187411c4f1amr1799524plx.129.1667331157786; Tue, 01 Nov 2022 12:32:37 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d7-20020a17090abf8700b00212e5068e17sm6300738pjs.40.2022.11.01.12.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 12:32:37 -0700 (PDT) Date: Tue, 1 Nov 2022 12:32:35 -0700 From: Stephen Hemminger To: Ivan Malov Cc: dev@dpdk.org, "Jiang, YuX" , Chas Williams , "Min Hu (Connor)" , "Burakov, Anatoly" , stable@dpdk.org, Andrew Rybchenko Subject: Re: [PATCH] net/bonding: fix device configure reentrancy Message-ID: <20221101123235.7d321376@hermes.local> In-Reply-To: <20221101161853.2702425-1-ivan.malov@oktetlabs.ru> References: <20221101161853.2702425-1-ivan.malov@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 1 Nov 2022 19:18:53 +0300 Ivan Malov wrote: > diff --git a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h > index d067ea8c9a..7171516d0d 100644 > --- a/drivers/net/bonding/eth_bond_private.h > +++ b/drivers/net/bonding/eth_bond_private.h > @@ -184,6 +184,8 @@ struct bond_dev_private { > > void *vlan_filter_bmpmem; /* enabled vlan filter bitmap */ > struct rte_bitmap *vlan_filter_bmp; > + > + bool kvargs_processing_is_done; > }; Minor nit: why not use existing hole in data structure after slave_update_idx?