From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5E92A00C2; Wed, 2 Nov 2022 00:05:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EED341143; Wed, 2 Nov 2022 00:05:15 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id DF89740693 for ; Wed, 2 Nov 2022 00:05:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667343911; x=1698879911; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=stGw3QAuDvxSvbE1klX3upNNCpT9sdIrqBBXQMviIjI=; b=lakNgZH/Zt/SWn+zKjwdMUGy9ORi9JrSjv/UFFlnPcpjIUcMPYofLK5N +MrsK/QzVBf8BhcaeNqLndcs1mIy9QK1cA0yGFlbAYUfpBX79MZWfj7bC +gx/+EP8wYx0OIPkSGcgriGLTVOH5WHTFistUQEK0jj160YpgzuSLwjgj Zr1bUmvR95JRlSdPrx4TiEK9Y17IOFf1JcsZ2LIZ1Yplgowr13pA1yOsP kA2tqgHUCGrqZlNfslHze+ZdGIdNGfYpADvuIRCUVDmPH75PiXzUpBfJh lqFYwQnycXmYXSpkwJEtf7XPcZhUaIoE+chwUIgX6i5e5S8mL+z3UZlxG w==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="373484034" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="373484034" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 16:05:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="585175092" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="585175092" Received: from unknown (HELO icx-npg-scs1-cp1.localdomain) ([10.233.180.245]) by orsmga003.jf.intel.com with ESMTP; 01 Nov 2022 16:05:09 -0700 From: Nicolas Chautru To: dev@dpdk.org, gakhil@marvell.com, maxime.coquelin@redhat.com, hernan.vargas@intel.com Cc: Nicolas Chautru Subject: [PATCH v1 2/6] baseband/acc: fix to possible overflow Date: Tue, 1 Nov 2022 16:04:55 -0700 Message-Id: <20221101230459.50891-3-nicolas.chautru@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20221101230459.50891-1-nicolas.chautru@intel.com> References: <20221101230459.50891-1-nicolas.chautru@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Potential overflow issue when casting to 64bits, notably relevant when extending number of queues. Coverity issue: 381665 Fixes: 32e8b7ea35 ("baseband/acc100: refactor to segregate common code") Fixes: 40e3adbdd3 ("baseband/acc200: add queue configuration") Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +-- drivers/baseband/acc/rte_acc200_pmd.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index 23bc5d25bb..b6e500c6bc 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -888,8 +888,7 @@ acc100_queue_release(struct rte_bbdev *dev, uint16_t q_id) if (q != NULL) { /* Mark the Queue as un-assigned */ - d->q_assigned_bit_map[q->qgrp_id] &= (0xFFFFFFFFFFFFFFFF - - (uint64_t) (1 << q->aq_id)); + d->q_assigned_bit_map[q->qgrp_id] &= (~0ULL - (1 << (uint64_t) q->aq_id)); rte_free(q->companion_ring_addr); rte_free(q->lb_in); rte_free(q->lb_out); diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/acc/rte_acc200_pmd.c index 0cbb9a946b..76a5986448 100644 --- a/drivers/baseband/acc/rte_acc200_pmd.c +++ b/drivers/baseband/acc/rte_acc200_pmd.c @@ -964,7 +964,7 @@ acc200_queue_release(struct rte_bbdev *dev, uint16_t q_id) if (q != NULL) { /* Mark the Queue as un-assigned. */ - d->q_assigned_bit_map[q->qgrp_id] &= (~0ULL - (uint64_t) (1 << q->aq_id)); + d->q_assigned_bit_map[q->qgrp_id] &= (~0ULL - (1 << (uint64_t) q->aq_id)); rte_free(q->companion_ring_addr); rte_free(q->lb_in); rte_free(q->lb_out); -- 2.37.1