From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17755A00C2; Wed, 2 Nov 2022 00:05:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 033D34281B; Wed, 2 Nov 2022 00:05:19 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 248EA40E03 for ; Wed, 2 Nov 2022 00:05:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667343912; x=1698879912; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=x3R87SCFiSGMRbcDdpC+KRKY1dNyexZhHoUD8XiMt9c=; b=gRwA77UBMWCbul6k8X3oftu+uCjR4HEeOmu03c9lgp4ovJGZGIFeLnFO +h6H0gqxsSjOKEqaGfW5w2/pUsIa0NjsACQHGENs/GWOpNwMDXH6atced BeKnpNv+D0U65ocuP1n8rkL0CGEKeF5yARW4+rXgRJkwgxQSRaL+/Mlag aUzmIdpcWNJAA8Ccqq+YsBmzCSvpAuf6O7jwKe33/GPKjP5VSem3Fa7C9 ugjeXp8jnrhxdQQvU9iLVx3Zx38AGRtbk+euXmP8b5X1r3x2YhXXdSyWD V6a4aZHDzTI1Fql/u89F5iqfwUv879Pv2Rn1z6vXAicKht4WWmuytHxkq w==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="373484044" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="373484044" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 16:05:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="585175119" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="585175119" Received: from unknown (HELO icx-npg-scs1-cp1.localdomain) ([10.233.180.245]) by orsmga003.jf.intel.com with ESMTP; 01 Nov 2022 16:05:11 -0700 From: Nicolas Chautru To: dev@dpdk.org, gakhil@marvell.com, maxime.coquelin@redhat.com, hernan.vargas@intel.com Subject: [PATCH v1 6/6] baseband/acc: fix redundant function definition Date: Tue, 1 Nov 2022 16:04:59 -0700 Message-Id: <20221101230459.50891-7-nicolas.chautru@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20221101230459.50891-1-nicolas.chautru@intel.com> References: <20221101230459.50891-1-nicolas.chautru@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hernan Vargas Remove acc100_dma_fill_blk_type_in which already exists in acc_common.h Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code") Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 93 +-------------------------- 1 file changed, 3 insertions(+), 90 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index 727a718e9d..31076d382f 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -1435,93 +1435,6 @@ acc101_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, } } -/** - * Fills descriptor with data pointers of one block type. - * - * @param desc - * Pointer to DMA descriptor. - * @param input - * Pointer to pointer to input data which will be encoded. It can be changed - * and points to next segment in scatter-gather case. - * @param offset - * Input offset in rte_mbuf structure. It is used for calculating the point - * where data is starting. - * @param cb_len - * Length of currently processed Code Block - * @param seg_total_left - * It indicates how many bytes still left in segment (mbuf) for further - * processing. - * @param op_flags - * Store information about device capabilities - * @param next_triplet - * Index for ACC100 DMA Descriptor triplet - * @param scattergather - * Flag to support scatter-gather for the mbuf - * - * @return - * Returns index of next triplet on success, other value if lengths of - * pkt and processed cb do not match. - * - */ -static inline int -acc100_dma_fill_blk_type_in(struct acc_dma_req_desc *desc, - struct rte_mbuf **input, uint32_t *offset, uint32_t cb_len, - uint32_t *seg_total_left, int next_triplet, - bool scattergather) -{ - uint32_t part_len; - struct rte_mbuf *m = *input; - - if (scattergather) - part_len = (*seg_total_left < cb_len) ? *seg_total_left : cb_len; - else - part_len = cb_len; - cb_len -= part_len; - *seg_total_left -= part_len; - - desc->data_ptrs[next_triplet].address = - rte_pktmbuf_iova_offset(m, *offset); - desc->data_ptrs[next_triplet].blen = part_len; - desc->data_ptrs[next_triplet].blkid = ACC_DMA_BLKID_IN; - desc->data_ptrs[next_triplet].last = 0; - desc->data_ptrs[next_triplet].dma_ext = 0; - *offset += part_len; - next_triplet++; - - while (cb_len > 0) { - if (next_triplet < ACC_DMA_MAX_NUM_POINTERS_IN && m->next != NULL) { - - m = m->next; - *seg_total_left = rte_pktmbuf_data_len(m); - part_len = (*seg_total_left < cb_len) ? - *seg_total_left : - cb_len; - desc->data_ptrs[next_triplet].address = - rte_pktmbuf_iova_offset(m, 0); - desc->data_ptrs[next_triplet].blen = part_len; - desc->data_ptrs[next_triplet].blkid = - ACC_DMA_BLKID_IN; - desc->data_ptrs[next_triplet].last = 0; - desc->data_ptrs[next_triplet].dma_ext = 0; - cb_len -= part_len; - *seg_total_left -= part_len; - /* Initializing offset for next segment (mbuf) */ - *offset = part_len; - next_triplet++; - } else { - rte_bbdev_log(ERR, - "Some data still left for processing: " - "data_left: %u, next_triplet: %u, next_mbuf: %p", - cb_len, next_triplet, m->next); - return -EINVAL; - } - } - /* Storing new mbuf as it could be changed in scatter-gather case*/ - *input = m; - - return next_triplet; -} - /* May need to pad LDPC Encoder input to avoid small beat for ACC100. */ static inline uint16_t pad_le_in(uint16_t blen, struct acc_queue *q) @@ -1565,7 +1478,7 @@ acc100_dma_desc_le_fill(struct rte_bbdev_enc_op *op, return -1; } - next_triplet = acc100_dma_fill_blk_type_in(desc, input, in_offset, + next_triplet = acc_dma_fill_blk_type_in(desc, input, in_offset, pad_le_in(in_length_in_bytes, q), seg_total_left, next_triplet, false); if (unlikely(next_triplet < 0)) { rte_bbdev_log(ERR, @@ -1653,7 +1566,7 @@ acc100_dma_desc_td_fill(struct rte_bbdev_dec_op *op, return -1; } - next_triplet = acc100_dma_fill_blk_type_in(desc, input, in_offset, kw, + next_triplet = acc_dma_fill_blk_type_in(desc, input, in_offset, kw, seg_total_left, next_triplet, check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_DEC_SCATTER_GATHER)); @@ -1756,7 +1669,7 @@ acc100_dma_desc_ld_fill(struct rte_bbdev_dec_op *op, return -1; } - next_triplet = acc100_dma_fill_blk_type_in(desc, input, + next_triplet = acc_dma_fill_blk_type_in(desc, input, in_offset, input_length, seg_total_left, next_triplet, check_bit(op->ldpc_dec.op_flags, -- 2.37.1