From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB1A2A00C2; Wed, 2 Nov 2022 02:24:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E0AA40693; Wed, 2 Nov 2022 02:24:13 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2103.outbound.protection.outlook.com [40.107.237.103]) by mails.dpdk.org (Postfix) with ESMTP id BA9C240223 for ; Wed, 2 Nov 2022 02:24:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTwrUJkraNvDxz/zcxSvtc7UZlITjF5HZJ/ACH5ioJm9hbqDhba+MrRSJXB4gy8eJgSddp5fmh9ix1RjrQIp8j6m4kn/hN+T6/LavNKSM1SfNOvt+yl+t/+va66fvZmO63TY8UCOgUafmcPVv5pIkvgOpSslC03MiM3VdAF0TZa4LkncyY/GkKaSs+2gehSKGk9MwZ4ZImpzIEzMDaEHy6OP9JFVH+rCDRaYjkY4r2Z1TwAF9eaY0galiQDmvJSdUUe0z7YTpASNPGMKZQdZTlzwewK4ef/lh4m+DfLAn/Q2eRBXEJ8ik+oT94eXAY4b6wEVoxcafBe9dURx1/GNxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ACyXU+D/zaXCE4Y4m7Hw7DRCYMPmywIDcyyRoNxas1U=; b=YocxzdWKdkzEcpPIswqpCLg3TzEo2D3OhOtRKoQtZ8H23NhshVOTDrZqZotyoIECS1PW9GtTVuEB+b4KHf7UHIxqdYb/qjTdozhv43CXOW2Z3DhT/y/giT0rZoB5wb53zyUUN89tTIpFdtVx1bzIaFXuCNPdkgtT9xWEmBhIUUtlUjyQWFd6U2K0BBIBIUKonb0MbV8hewW7QLs8om4F3qEktReFUJ4eBGpmJq6eSD/cDEYoGTE+xW84KzaLQMzVH50BRNpVWIyuJVEn61dYgHGafKv+4Ku6teZjzNMDf70M4b7Pu1dX8m2jn+O2zcbRVQrsCfAbxIoZCR0eRUUkQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ACyXU+D/zaXCE4Y4m7Hw7DRCYMPmywIDcyyRoNxas1U=; b=HDXuPon7phiTA3VE41NqqsjsYj+l4QsyBtK4BRQZRw5mk7Sm9ckk+2SDKJVs0Y838GEWFz+ktG+mfSk5kwI7CdRXou3eslJBtbtICyz/z+geux7opFPxGOhb93aNUg+NgMT1oHbLWomLFF/1FTTTV8397Lsu1gwD7KtxOKCZ2zE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by MN2PR13MB4104.namprd13.prod.outlook.com (2603:10b6:208:24e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.19; Wed, 2 Nov 2022 01:24:05 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7c26:1a0b:2825:6f4b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7c26:1a0b:2825:6f4b%4]) with mapi id 15.20.5791.010; Wed, 2 Nov 2022 01:24:05 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He Subject: [PATCH] net/nfp: fix an out of bounds write problem Date: Wed, 2 Nov 2022 09:23:49 +0800 Message-Id: <20221102012349.26186-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SJ0PR13CA0231.namprd13.prod.outlook.com (2603:10b6:a03:2c1::26) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|MN2PR13MB4104:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d077567-71dc-4046-cf7f-08dabc70ee46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fbJI2h9qbsOqESpugINd9+Xe6bT1O1v/iz5aqyPGb5q95S726XjrqA5lFrlME3k5uvlunaQkHV72RG62hYGZ8/0E8uIB0eHrBgrRey4oKGivwhO3HwFcDYjE7VTVFOUDq6PcOsc6kWrLck+sLcXu4WOfpimDyZu5vpQuAIWuVM3DYg9urwmzjBA/QNqtiY80N1bFWedEYk804djSEyGKizczTlG2ddmpDNtggTDdFAsP2z+ZE4EdnfoOLdyJZb9Ne7ParNkF/ORA/51wNgyRPAClhBEqVZIVSFlf09+JhHVCFU3B6RvS1rSXBLc8cxGWe+oO2RLlwSZszMvwBa8vtnYpBJ5DIEo0oHQ+67TwlLYB1sJud9K0kELOBIUyTpQPdu1w/DW/JVm0mPJQzVARbBO+aDg5etfjx44rT3WnVITT6Ff71QHaT5XPU08PuOhflNIZ2FiqxHJUGTKcxArhsgKk86fgpr1OXiG1imAn9FRCjNsSaHfEMxPD6OiELZyUK3+2UxFp2Yhhd18mS6zOvY53UhSH0c73+Z/yTmkA2lCjGwZC0bGkW+euOcL+taKeLQnTYOwGLPdtRwVTxLEtzjUY7eCrUKJormVspc6wj8bA8uz6T4k5FdWoIOzCbu/tPAAc+c0PRI/5nSxzT4hXCRSfpmq1j9R3pe2veyNInfVPKmORkwDzEcvQkQk4IrKl0bFP+uAGMkUSiwTX1gsmryR2bjqPCsiKLOXQjXryqoKw5maUFvV72iRjPCdOp0wrdVyd/NiqxWuf0PnAjBUuxQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39830400003)(346002)(396003)(136003)(366004)(376002)(451199015)(6506007)(2616005)(186003)(6512007)(26005)(478600001)(38350700002)(1076003)(36756003)(107886003)(38100700002)(6666004)(66574015)(52116002)(6486002)(83380400001)(8936002)(41300700001)(6916009)(5660300002)(4744005)(44832011)(86362001)(2906002)(66476007)(316002)(66946007)(4326008)(8676002)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0RpQWtOTVBJcjRaV25zWHB4OS9yNXNGT0RrSmY1SGxZSUF6L1F4emI0b0xQ?= =?utf-8?B?OUlKbFdLeEdNL2lkb3hwUDhzTW9YK3hpcnI3ZFBWTVBqNEZGN2RzZVZFR041?= =?utf-8?B?RS9rQUFqL1I4ekdaWGNBUkVXaDVvdmgzbW9aUFhickg1UEtNclEzMXJ0UTNV?= =?utf-8?B?cnBmWXZlWjU0YW5BS1c0ZE1kd3hSSFNaT2FrYmlzeEJqZXFkUzVGS3ZtVjYw?= =?utf-8?B?VGJzWkNFdXF0YS85OVJHUlgrVnB6TXlWTCtLaDJ3NkZua1NycS82M3ZyWmVx?= =?utf-8?B?OHFuK1RwRVVZenh4QXM3YzhQanMwTTV1cHczL3lJN2kxVjRJY1o2NUdaWUdo?= =?utf-8?B?bkIycHRHSVdtdWI3QmpTQ3RVQlZ1NnUxdkQ1R1lMeFpBSmZCeG1nazJYVjA1?= =?utf-8?B?Um1veDNxT1k1MUFLWFJCTU5iSWJKanp2bmxwS3NDVlNtaDdHWEFpWUljSk1U?= =?utf-8?B?S1ZVMVNGWlB5Q0lHbGZXcDhUQUh0RitUTnQybUV0M294NGFCMzhKK3YrOW1J?= =?utf-8?B?bzcrZXhGY3BNVm1RdzFyc3FMamJFR2pZcksvRXhLRWYyUkY3OWJNYUJFaExB?= =?utf-8?B?K0hXL01va0hpNFU2WUhGcGxINnUxbEJIbjZVdTJ0Zmx6R0pUNVgxZUwyVmVS?= =?utf-8?B?YTBsVFoyNVFUeURWVkE0aVA3cFQxTE1WN0RtajV3TEhQZzBReFoxTzdBdGxs?= =?utf-8?B?SStNZmRmbXFxNnVZazczK3hzZGVnZE41Z0EwTUlKbXBjVzJRODB5Ujl6Wi9j?= =?utf-8?B?M3VCV0Q0SFFFaGlOb2liY2ZBM0JnT3NvMFM4WkM1M0F3OFNOYlNyZ3BTQ2ZY?= =?utf-8?B?aWY1djB1OGlhemFiRG52T2xkSzNPSThTbFFkRTFYdElDRW1Ya3BJbm5xYjcz?= =?utf-8?B?UWZvV29pM3E1V0gwTWNwbk11WHI4RDlwNTFLUEVpRnY2NW1OcXBmRG1lYlI5?= =?utf-8?B?dHFGQXd5UUdOZGJrVVlFUk1NYXIxeXVwZXZDRzRReWs2ZThJY2xiUkdkYVkw?= =?utf-8?B?cWx6WDk3K1VUc0F0a1MzS3JOcDRVNVhtdTZoYldtWUcvOVdIWE1naGlYYU1s?= =?utf-8?B?Yk5FV1RKaEEwQzRWTmJmOEYxWlUvS3l0cGZNOS9uVEZNR2Jid1pFNDdHUnhY?= =?utf-8?B?Sk9sRVhkTXpxRG5ZQzBHSlVseS9FaEZjWUVPa1lwRkdVZUZHZFEzcUZFcGg3?= =?utf-8?B?OTgxQzBJUjVTRkl2WndGZkxNM242MC9WYm9Kdm1vL0xSUWJab1FQajl4WnQ5?= =?utf-8?B?QlpNbTJPc0RrL0oxRHE1SndZeFppWWN4T2pYUjUyZnBseGRZWU9IWWJqZ25D?= =?utf-8?B?b3JHSmVpSHo5eGxXdk05RVRsYWhXcFFNbUlybkY5eUNDcDNjNDBDT1hyYWxV?= =?utf-8?B?ajlNSVhYWCsrbU5mNkxIYWlUeHYxK1pCSUVLdW5tZDk4aEdJSyswZ1BZTjYz?= =?utf-8?B?R3ZWd0VVUloxa2RFZ2tsQXJISjc4TWVmR1lkMlA4aEJXbTVaSGgrTWRCRGdD?= =?utf-8?B?MVdndUhvZVFCQWVvWGlaUS9ndTJSdDRScE11bGtLcm9CcmRqME5nWCtCUzJw?= =?utf-8?B?eHV3SnkwV1pBbHdpUVcrVWxrdGlzNllwUmh3MGpVeE5KYnF1d2xiZENjSDZL?= =?utf-8?B?aXJCN2lrY2JWVEhJYW9RQnpvdUlOV3c4K05FL1ByOC96Ynk1Zk9leVdtYU4r?= =?utf-8?B?YWpRcnp4eXNaV3pEVDE3cU1pSFdIbmJUL3dkWE5TOTliZzBJN1U0QjQ5RCs5?= =?utf-8?B?eGJZaGNyS1JpMWduZWNJWVlqS1ZaalN0Ry9wa2J4R0tnSm1uREU5M2ZsRTlL?= =?utf-8?B?WmhoS08rbVNtcGlxcll2MU1XaHpFRitnU3BjWDc1WkovdnNwUC92akk3ektP?= =?utf-8?B?a0o3YUJybThvVVpGVkN4OWRuNzRoQk42eTB1V0p3Z2s0K2l4TE94bnBXaXVM?= =?utf-8?B?bklhWEJBVmNYV1BDMnI4RjMwZDdTUmJmVkhwTEY3TUFsUkp3N0Q4ejlubFhy?= =?utf-8?B?dmRlaDIrN3dSTzc2dG9odlpLWCs0Rk9VWFQzRFhta1hOMElRQXdkbWVyRzAw?= =?utf-8?B?ME5WenZMNncxYVY5enJoN2tzSnNya1JNTmZXV05ucFdxcDBIU0pGMFhhR3FV?= =?utf-8?B?UmF5Z3dUc2JEZ3RWWXZ2WCsrUHYvYTlpbFhjTEgveGE1bUFiRW5TRXJtc0pK?= =?utf-8?B?T0E9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d077567-71dc-4046-cf7f-08dabc70ee46 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 01:24:04.9916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0AkxlG28Dc6gZBD2/uifDQI4J11dZZm13VhZ0fEKI+NQpntl8Jvb8P4bEOpzhtNUg2Fh7qrWbj3vjanpoHbIOtW2IJoqgM6YBCvV9fQcCYM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB4104 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix the check logic of the index of the array, which caused the out of bounds write problem. Coverity issue: 381616 Fixes: 0666af498761 ("net/nfp: support RSS based on VXLAN inner layer") Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c index 463eb64b1d..71711bfa22 100644 --- a/drivers/net/nfp/nfp_common.c +++ b/drivers/net/nfp/nfp_common.c @@ -1386,7 +1386,7 @@ nfp_net_set_vxlan_port(struct nfp_net_hw *hw, int ret; uint32_t i; - if (idx > NFP_NET_N_VXLAN_PORTS) { + if (idx >= NFP_NET_N_VXLAN_PORTS) { PMD_DRV_LOG(ERR, "The idx value is out of range."); return -ERANGE; } -- 2.29.3