* [PATCH v1 0/1] baseband/acc: coverity fix RC2
@ 2022-11-02 18:30 Nicolas Chautru
2022-11-02 18:30 ` [PATCH v1 1/1] baseband/acc: fix to possible negative shift Nicolas Chautru
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Chautru @ 2022-11-02 18:30 UTC (permalink / raw)
To: dev, gakhil, maxime.coquelin, hernan.vargas; +Cc: Nicolas Chautru
Another fix for coverity issue just raised on RC2
for ACC200 PMD.
Nicolas Chautru (1):
baseband/acc: fix to possible negative shift
drivers/baseband/acc/rte_acc200_pmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] baseband/acc: fix to possible negative shift
2022-11-02 18:30 [PATCH v1 0/1] baseband/acc: coverity fix RC2 Nicolas Chautru
@ 2022-11-02 18:30 ` Nicolas Chautru
2022-11-03 11:27 ` [EXT] " Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Chautru @ 2022-11-02 18:30 UTC (permalink / raw)
To: dev, gakhil, maxime.coquelin, hernan.vargas; +Cc: Nicolas Chautru
Potential occurrence of negative shift when using invalid
configuration on ACC200. Enforcing that depth > 0.
Coverity issue: 381636
Fixes: 40e3adbdd3 ("baseband/acc200: add queue configuration")
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/acc/rte_acc200_pmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/acc/rte_acc200_pmd.c
index 8ee9023451..7d7a6c6389 100644
--- a/drivers/baseband/acc/rte_acc200_pmd.c
+++ b/drivers/baseband/acc/rte_acc200_pmd.c
@@ -105,9 +105,9 @@ aqDepth(int qg_idx, struct rte_acc_conf *acc_conf)
qtopFromAcc(&q_top, acc_enum, acc_conf);
if (unlikely(q_top == NULL))
- return 0;
+ return 1;
- return q_top->aq_depth_log2;
+ return RTE_MAX(1, q_top->aq_depth_log2);
}
/* Return the AQ depth for a Queue Group Index. */
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 0/1] baseband/acc: coverity fix RC2
@ 2022-11-04 3:52 Hernan Vargas
0 siblings, 0 replies; 4+ messages in thread
From: Hernan Vargas @ 2022-11-04 3:52 UTC (permalink / raw)
To: dev, gakhil, trix, maxime.coquelin
Cc: nicolas.chautru, qi.z.zhang, Hernan Vargas
Fix for coverity issues 381631, 381646 raised on RC2 for the ACC100 PMD.
Hernan Vargas (1):
baseband/acc: fix check after deref and dead code
drivers/baseband/acc/rte_acc100_pmd.c | 4 ----
1 file changed, 4 deletions(-)
--
2.37.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-03 19:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 18:30 [PATCH v1 0/1] baseband/acc: coverity fix RC2 Nicolas Chautru
2022-11-02 18:30 ` [PATCH v1 1/1] baseband/acc: fix to possible negative shift Nicolas Chautru
2022-11-03 11:27 ` [EXT] " Akhil Goyal
2022-11-04 3:52 [PATCH v1 0/1] baseband/acc: coverity fix RC2 Hernan Vargas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).