* [PATCH] net/mlx5/hws: allow HWS support on non esw-manager devices
@ 2022-11-03 12:50 Alex Vesker
2022-11-07 11:06 ` [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr Alex Vesker
0 siblings, 1 reply; 3+ messages in thread
From: Alex Vesker @ 2022-11-03 12:50 UTC (permalink / raw)
To: valex, viacheslavo, thomas, suanmingm, Matan Azrad; +Cc: dev, orika
On context initialization the reparse capability support
for NIC and FDB tables was required for allowing HWS. This
caused a problem for devices that only want to run NIC
steering. Modified the check to require FDB reparse only
for esw-manager.
Fixes: b0290e5 ("net/mlx5/hws: add context object")
Signed-off-by: Alex Vesker <valex@nvidia.com>
Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_context.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_context.c b/drivers/net/mlx5/hws/mlx5dr_context.c
index ae86694a51..76ada7bb7f 100644
--- a/drivers/net/mlx5/hws/mlx5dr_context.c
+++ b/drivers/net/mlx5/hws/mlx5dr_context.c
@@ -108,7 +108,8 @@ static void mlx5dr_context_check_hws_supp(struct mlx5dr_context *ctx)
}
/* Current solution requires all rules to set reparse bit */
- if ((!caps->nic_ft.reparse || !caps->fdb_ft.reparse) ||
+ if ((!caps->nic_ft.reparse ||
+ (!caps->fdb_ft.reparse && caps->eswitch_manager)) ||
!IS_BIT_SET(caps->rtc_reparse_mode, MLX5_IFC_RTC_REPARSE_ALWAYS)) {
DR_LOG(INFO, "Required HWS reparse cap not supported");
return;
--
2.18.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr
2022-11-03 12:50 [PATCH] net/mlx5/hws: allow HWS support on non esw-manager devices Alex Vesker
@ 2022-11-07 11:06 ` Alex Vesker
2022-11-08 9:01 ` Raslan Darawsheh
0 siblings, 1 reply; 3+ messages in thread
From: Alex Vesker @ 2022-11-07 11:06 UTC (permalink / raw)
To: valex, viacheslavo, thomas, suanmingm, Matan Azrad; +Cc: dev, orika
On context initialization the reparse capability support
for NIC and FDB tables was required for allowing HWS. This
caused a problem for devices that only want to run NIC
steering and are not the esw-manager fow which FDB reparse
is disabled. Modified the check to require FDB reparse only for
esw-manager.
Fixes: b0290e5 ("net/mlx5/hws: add context object")
Signed-off-by: Alex Vesker <valex@nvidia.com>
Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_context.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_context.c b/drivers/net/mlx5/hws/mlx5dr_context.c
index ae86694a51..76ada7bb7f 100644
--- a/drivers/net/mlx5/hws/mlx5dr_context.c
+++ b/drivers/net/mlx5/hws/mlx5dr_context.c
@@ -108,7 +108,8 @@ static void mlx5dr_context_check_hws_supp(struct mlx5dr_context *ctx)
}
/* Current solution requires all rules to set reparse bit */
- if ((!caps->nic_ft.reparse || !caps->fdb_ft.reparse) ||
+ if ((!caps->nic_ft.reparse ||
+ (!caps->fdb_ft.reparse && caps->eswitch_manager)) ||
!IS_BIT_SET(caps->rtc_reparse_mode, MLX5_IFC_RTC_REPARSE_ALWAYS)) {
DR_LOG(INFO, "Required HWS reparse cap not supported");
return;
--
2.18.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr
2022-11-07 11:06 ` [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr Alex Vesker
@ 2022-11-08 9:01 ` Raslan Darawsheh
0 siblings, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2022-11-08 9:01 UTC (permalink / raw)
To: Alex Vesker, Alex Vesker, Slava Ovsiienko,
NBU-Contact-Thomas Monjalon (EXTERNAL),
Suanming Mou, Matan Azrad
Cc: dev, Ori Kam
Hi,
> -----Original Message-----
> From: Alex Vesker <valex@nvidia.com>
> Sent: Monday, November 7, 2022 1:07 PM
> To: Alex Vesker <valex@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Suanming Mou <suanmingm@nvidia.com>;
> Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>
> Subject: [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non
> esw-mngr
>
changed commit title a bit,
> On context initialization the reparse capability support
> for NIC and FDB tables was required for allowing HWS. This
> caused a problem for devices that only want to run NIC
> steering and are not the esw-manager fow which FDB reparse
> is disabled. Modified the check to require FDB reparse only for
> esw-manager.
>
> Fixes: b0290e5 ("net/mlx5/hws: add context object")
added missing empty line
> Signed-off-by: Alex Vesker <valex@nvidia.com>
> Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-08 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 12:50 [PATCH] net/mlx5/hws: allow HWS support on non esw-manager devices Alex Vesker
2022-11-07 11:06 ` [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr Alex Vesker
2022-11-08 9:01 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).