From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ACE4A00C2; Thu, 3 Nov 2022 13:51:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62F1E41614; Thu, 3 Nov 2022 13:51:37 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2043.outbound.protection.outlook.com [40.107.94.43]) by mails.dpdk.org (Postfix) with ESMTP id 439EF41155 for ; Thu, 3 Nov 2022 13:51:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F7SZGSL7cFIkF2ZunCzd+6zF7EtxxLhgbOFwjGrmHrV7wle/aZ8bbaWgJKNF+eW7ub/7DFV6vYJ57j5yOS29vdT0HD1Hnyzns/bRW/vt6p19WUVGUjm8VaCNPqOg8JhWbMyjwPlSCiCW/16cirgFq9ul91uisQzWZrv0vvar6AOZEqrqZKpAUaowD9uiXH9Zy9OhpjYzqJOoORAlb9XCWneCPOE9sRJ5nIqkBifVTKw2DO0t08gDgtsXuK7GIig5gAur8i2EHtp3vF0D9gV2VunlPOQxD/ky/dHbmQQkzEEpBAHejH+gvwcZL/KmQjns58nU4Zw+nWJ5ruZ7bDkxjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p+of5l4rfWRBjiqsxcO6wBolLQ3yXs44Tr7KXAp+6EY=; b=M5xI51KKvVZXzosqgNrISsDsKwh8f6uYVP+0MgrdSpe5Y0Gv7LsGklqu9oeVsKhxuELvGJrqALH4b0Py+oEw+RAjlIAUSG9G9YUPpXoB+iPsK1SFy0a/WN0DwQdHro6Ijl+APZTy3uvEoT6WIngaWz4XNRybXCFKxlT1sRFWOnZhJBH6BI4ML0oR6qQ4lVIumve6VOMhFY+W1UXvSuP06DPsn/+PUyTrjv1TVN6oyI2kdEJOJ129+514A9SrsBsHRJD8vIeW4A3fUoPS6XmRntwRaQBJow7tMOF00oth4U01EN7xrFfMrNN/XuTsCDLsSVgdq0fk1JlPrXXBRpfdWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p+of5l4rfWRBjiqsxcO6wBolLQ3yXs44Tr7KXAp+6EY=; b=iOW6hhKRDwQcXTuOOqqJxN730pBiBT3NJfyI1cy50IFO5McsjwITXb6y0ilhWAYy/2rM+4wOcA3D/DGxxnCZpF2InFuwwqgAwvNXRN/jJYquZ+2WZXWSUZQOiLRfiCco87H5dxvfCz9xwKprOnnmgfs6mpWzJIuCklo6PoYdtJW55HKjrxbuu/jiUBHVMONy9AAE35wLSw6uLjav36pG0QE8SGqQwmPDZDhFrY3EXePrUExtUZLooU8e1xWtOscxHyxdYprqTo9rC98zaQDKSc6IQ1dZz2WHhAOefrzTSTLnGzgCW81OMHrJK8FPEFISdGC//ibsUfwFT9Uwc+NMOg== Received: from DM6PR21CA0013.namprd21.prod.outlook.com (2603:10b6:5:174::23) by PH0PR12MB5498.namprd12.prod.outlook.com (2603:10b6:510:d6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 12:51:33 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:5:174:cafe::89) by DM6PR21CA0013.outlook.office365.com (2603:10b6:5:174::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8 via Frontend Transport; Thu, 3 Nov 2022 12:51:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 12:51:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Thu, 3 Nov 2022 05:51:24 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 3 Nov 2022 05:51:21 -0700 From: Alex Vesker To: , , , , Matan Azrad CC: , Subject: [PATCH] net/mlx5/hws: fix possible action setter segmenation fault Date: Thu, 3 Nov 2022 14:51:08 +0200 Message-ID: <20221103125108.7203-1-valex@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT032:EE_|PH0PR12MB5498:EE_ X-MS-Office365-Filtering-Correlation-Id: f5b148e5-05c9-44e1-6ed8-08dabd9a22ba X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wVdDOJJtNojc3s7NFlsPb4bKOFNIWaO32GmXsvcoS0RFsrmCxE0j5A1GdzUKXiRs6xGzm0TuF26npTZzf8wJDZ54BbYNDNv3S2OSPxFfCzuejuqNcsyBtVzWEe6vA99dToEvf6nrY3j3m5kt9szN3gh4KNDXQjiLe5UwLXj+16GLtVuLlLshJuFD5E/MsK1C5iRAl6SXDCDVJ9VlUgqrV5Zn870G2PkbJncVBJMyqVhNMtngZvz6AnsNsbsJU5aRxotyCBvi9j7psUm/lLiqtrijW3oLaaoj0bvBw7YeCTUUrb48Gr6I2g+GSKXc1vccGB/cjoaCSYjDoWLp8zFRlNEIl0cAbv6/EkYxmOnTMZTzI0h2lFnAX6G7+EeZY3541fYwrQ1O+2H5bnOVtMrVOzrH5FdqDsncVWeSa3tHd5eOIspX/7VU2lbZD37RT4duyvEwTMqfOc3KK4WuLB17KPrtM2tnSZswVUsXsAzdTQ6Ui2AgilIyGVKHOg38tb7hk6sla1becSiwjtwat/ac8G3N0aljPCHVyhHr52hs++qQPASaiFGbRQQUn7A7Lg32Lqqgxe1VRgsH1NxeLW58BFIQHo3NxsjQQDFAczs5f861cPzdFYxrUsABBcWH8rPRR5NMxUxOF5YqgOPm4lAZB6GsyFfxL/p9hTv4z8+NVaiiEo5ZmwLyn+Bx8NWXQA8a9/A3c9Uh7cJeju0QKOTwLUobWOzg+8vOvTxnWSnt+aKjyvkO1Q+6UK/0Fuwy3CdnCBvYRjkZ3zM5TvNx5EtbUA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(396003)(346002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(47076005)(316002)(186003)(1076003)(7636003)(356005)(478600001)(336012)(16526019)(55016003)(40480700001)(4744005)(36860700001)(8676002)(70206006)(70586007)(41300700001)(4326008)(86362001)(83380400001)(8936002)(5660300002)(36756003)(426003)(40460700003)(110136005)(54906003)(26005)(6286002)(6636002)(82310400005)(2906002)(82740400003)(6666004)(107886003)(7696005)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 12:51:33.0040 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5b148e5-05c9-44e1-6ed8-08dabd9a22ba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5498 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define. This bug can happen on RX/TX or FDB in the most complex cases. Current max was set to 7, but actual max is: Max TX: 8, Max RX: 10, Max FDB: 9 Fixes: f8c8a6d ("net/mlx5/hws: add action object") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit --- drivers/net/mlx5/hws/mlx5dr_action.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.h b/drivers/net/mlx5/hws/mlx5dr_action.h index f14d91f994..808f44a740 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.h +++ b/drivers/net/mlx5/hws/mlx5dr_action.h @@ -6,7 +6,7 @@ #define MLX5DR_ACTION_H_ /* Max number of STEs needed for a rule (including match) */ -#define MLX5DR_ACTION_MAX_STE 7 +#define MLX5DR_ACTION_MAX_STE 10 enum mlx5dr_action_stc_idx { MLX5DR_ACTION_STC_IDX_CTRL = 0, -- 2.18.1