From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD804A00C2; Thu, 3 Nov 2022 14:49:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9872342D0C; Thu, 3 Nov 2022 14:49:51 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2072.outbound.protection.outlook.com [40.107.237.72]) by mails.dpdk.org (Postfix) with ESMTP id 0FDA642D02 for ; Thu, 3 Nov 2022 14:49:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HmS9rjSL4LEMCFEAWwe3lDlTCWokB25oAO9Gptj+5tD56WDtTV+Zj/dQAAOaBuozu1Y1aL1BR9yecOzmqJczsVWw6HRR5ecKLwThEQy0EkYVPRQE8QJC4TMhn+WPMM9meoeyFY0t0Yee/aEJ3xbSSfjWjnGyQ67MFXdJQbdrYiROXsGfoA22w2YiRYLZyCNlGe3uRcI25jHGqc8fJDSNGCuOyXZvlLFASoCEIPGKC6wlSvSWDbphv8RItnywD2Fyj1+h62j5je2Iz3WcaVIT/Q58Oj9Od9fpVcUxnJZs0U4E6InLdYr6RMfx9JKcxz4CtHjNTbfU5F2oG9xFIISAsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ElqeCs2hTxSr/F3FqE3RqxVhLge+9Knis6Qw0yGH+BQ=; b=Z6wU7zNq48mSJ0Zri/mqXPZuSKplcAzZRjPkzizduwV4ryBow6VAu5l/nEnZuObZ8Mel2Den1+IGWdHLM3oe6PvK79ubBUeCf9yk9tMYGr8zDnxe46ppDI7Uv4w79sP4r8DV1lejH9Yl/fzw9wuTDsl0CG4A69WbgJwJLGBE+RADy8qamMKINazSkAwTndk++OJ5xxlJlTdhYuyyP3ZHojapEA+fS6+kmVOoe0YZL2AGVgPHC46J/WAtcA/kRER3O4xSt4Q01rhmlsMCYLq2eZV7wg9YW18RSPusPJdGL7lpz0vVTAbHVEBMHShQ2KVOXSsonSr3iW6lHqQopf9GeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElqeCs2hTxSr/F3FqE3RqxVhLge+9Knis6Qw0yGH+BQ=; b=odn6onfwnvPz1UwMNYJSDV7UwLs/ZvQZejUAdu7d8w9VtKS1UOabDhNHKq0r2cfMkITH+jH1LelG1r8cN9ODuDXAnmoZ1GiMymAo1kTHsBwMmZJBfML2qU9MpE/qw/lCWOll5ER9TF4pbi6DCqMMYcIO69B1XLzy6aPQ9NRBQ+Q= Received: from BN0PR04CA0122.namprd04.prod.outlook.com (2603:10b6:408:ed::7) by DM6PR12MB4299.namprd12.prod.outlook.com (2603:10b6:5:223::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 13:49:46 +0000 Received: from BN8NAM11FT101.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ed:cafe::5a) by BN0PR04CA0122.outlook.office365.com (2603:10b6:408:ed::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 13:49:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT101.mail.protection.outlook.com (10.13.177.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 13:49:46 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 08:49:45 -0500 From: Andrew Boyer To: CC: Andrew Boyer Subject: [PATCH 2/2] net/ionic: fix up minor coverity issue in packet transmit Date: Thu, 3 Nov 2022 06:49:09 -0700 Message-ID: <20221103134909.21791-3-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221103134909.21791-1-andrew.boyer@amd.com> References: <20221103134909.21791-1-andrew.boyer@amd.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT101:EE_|DM6PR12MB4299:EE_ X-MS-Office365-Filtering-Correlation-Id: 3adea669-4590-4c37-99cc-08dabda244f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xZ0i0XboFTNjtPKKaZXAlyNLI6NDzNBGENAzI/cGJ+/yCwI7865zzP55TW+VHCDrtNwReuEOvIJFRK5m+FXE/N1hBnelbfnS3v4tzE14jtQkXkXQGfxsgeZRXVDYhpdhNienNpXa+6YWx0qAbCGsUj51SYJWWrmGlCWfjYMk9Wbb/iqS+WvyCVM1NUOozksJY5IDbiRUMWXiIE3WJ0h/LFyofzIdR2jGmLR95jwGll64t6QcvaR2kCMj2IQHBXyhvFA+T3WSnjq4LrZ2AgwbScTFmMTEYxvToxVtnWCYseKYW3GFaj3sJzzIlY2ZxcCKza2j4UC7HJWOD36o2e6B8eRsuURaLraR0gIB2xLqZT7gyKXXIBhkemN5p16tRjzOmHgGtrAicoToR6TeLEUjG0Qiuyx6YYuYjBYJYp90pOvqFLf0CTbDErvGqz3qMq6HPcHhxTYgvEiRocvcqx1qycyb57lTT9nc3HNPFMGOLPpCmippJISZyusK/QDgL3QqWbeeQ7ReUn/3z+5UBQhibQ23BNdt75N9/LUEiyF84ce+Q2ZrUfvtymn0gu2tP5+dSXAlTcYSnELnwLzXUBg6aqSHZnl3Tl+Dqz09olj7Vx2r6zbG4ubOujk7RH+ewD1o7kv8cIbb+m7YxGjgSfHKOe3UqUTenPAYTckOqmKfwJuZhYz9Y9EUqVrs+YIinBrMzkQv39IWx5jYs51rUE2pG/hKGJNLh8TwDY5RkvzfKcTNF+TBiVegooPKDxqYoKe483zZJczUDPc0jvsAVTs7Q0lfgIqBNNfoi9G3j0nES4E= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(356005)(478600001)(36756003)(40460700003)(86362001)(40480700001)(2906002)(44832011)(70586007)(81166007)(6666004)(316002)(70206006)(4326008)(8936002)(8676002)(41300700001)(5660300002)(6916009)(16526019)(82310400005)(186003)(26005)(36860700001)(2616005)(1076003)(336012)(426003)(47076005)(83380400001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 13:49:46.5372 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3adea669-4590-4c37-99cc-08dabda244f8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT101.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4299 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If tx_pkts is NULL, nb_pkts must be 0. Coverity doesn't know this so it thinks this is a forward-NULL violation. Make things more clear by checking for nb_pkts instead. Coverity issue: 381614 Coverity issue: 381619 Fixes: e86a6fcc7cf3 ("net/ionic: add optimized non-scattered Rx/Tx") Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx_sg.c | 2 +- drivers/net/ionic/ionic_rxtx_simple.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx_sg.c b/drivers/net/ionic/ionic_rxtx_sg.c index 2752ba2acd..ab8e56e91c 100644 --- a/drivers/net/ionic/ionic_rxtx_sg.c +++ b/drivers/net/ionic/ionic_rxtx_sg.c @@ -175,7 +175,7 @@ ionic_xmit_pkts_sg(void *tx_queue, struct rte_mbuf **tx_pkts, rte_prefetch0(&desc_base[q->head_idx]); rte_prefetch0(IONIC_INFO_PTR(q, q->head_idx)); - if (tx_pkts) { + if (nb_pkts) { rte_mbuf_prefetch_part1(tx_pkts[0]); rte_mbuf_prefetch_part2(tx_pkts[0]); } diff --git a/drivers/net/ionic/ionic_rxtx_simple.c b/drivers/net/ionic/ionic_rxtx_simple.c index 0421fb32b2..5f81856256 100644 --- a/drivers/net/ionic/ionic_rxtx_simple.c +++ b/drivers/net/ionic/ionic_rxtx_simple.c @@ -148,7 +148,7 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, rte_prefetch0(&desc_base[q->head_idx]); rte_prefetch0(&q->info[q->head_idx]); - if (tx_pkts) { + if (nb_pkts) { rte_mbuf_prefetch_part1(tx_pkts[0]); rte_mbuf_prefetch_part2(tx_pkts[0]); } -- 2.17.1