From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Matan Azrad <matan@nvidia.com>,
Fan Zhang <royzhang1980@gmail.com>,
Ashish Gupta <ashish.gupta@marvell.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Alex Vesker <valex@nvidia.com>,
David Marchand <david.marchand@redhat.com>
Subject: [PATCH] common/mlx5: use build configuration dictionary
Date: Mon, 7 Nov 2022 17:37:20 +0100 [thread overview]
Message-ID: <20221107163720.4157535-1-thomas@monjalon.net> (raw)
In-Reply-To: <Y2JtJyOovaJXACdr@bricha3-MOBL.ger.corp.intel.com>
A recent commit added an explicit dependency check on common/mlx5.
For consistency, query dpdk_conf instead of the list of common drivers.
The lists *_drivers should be used only for printing.
Fixes: 3df380f61797 ("common/mlx5: fix disabling build")
Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/compress/mlx5/meson.build | 2 +-
drivers/crypto/mlx5/meson.build | 2 +-
drivers/net/mlx5/meson.build | 2 +-
drivers/regex/mlx5/meson.build | 2 +-
drivers/vdpa/mlx5/meson.build | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/compress/mlx5/meson.build b/drivers/compress/mlx5/meson.build
index 49ce3aff46..df4f79fa7e 100644
--- a/drivers/compress/mlx5/meson.build
+++ b/drivers/compress/mlx5/meson.build
@@ -9,7 +9,7 @@ endif
fmt_name = 'mlx5_compress'
deps += ['common_mlx5', 'eal', 'compressdev']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
# avoid referencing undefined variables from common/mlx5
subdir_done()
endif
diff --git a/drivers/crypto/mlx5/meson.build b/drivers/crypto/mlx5/meson.build
index 7521c4c671..7e32095695 100644
--- a/drivers/crypto/mlx5/meson.build
+++ b/drivers/crypto/mlx5/meson.build
@@ -9,7 +9,7 @@ endif
fmt_name = 'mlx5_crypto'
deps += ['common_mlx5', 'eal', 'cryptodev']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
# avoid referencing undefined variables from common/mlx5
subdir_done()
endif
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index f1aab18f82..abd507bd88 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -9,7 +9,7 @@ if not (is_linux or is_windows)
endif
deps += ['hash', 'common_mlx5']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
# avoid referencing undefined variables from common/mlx5
subdir_done()
endif
diff --git a/drivers/regex/mlx5/meson.build b/drivers/regex/mlx5/meson.build
index 70edc5b6da..87404101b9 100644
--- a/drivers/regex/mlx5/meson.build
+++ b/drivers/regex/mlx5/meson.build
@@ -8,7 +8,7 @@ if not is_linux
endif
deps += ['common_mlx5', 'eal', 'regexdev']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
# avoid referencing undefined variables from common/mlx5
subdir_done()
endif
diff --git a/drivers/vdpa/mlx5/meson.build b/drivers/vdpa/mlx5/meson.build
index 54a4eac6f4..e224d1bcc9 100644
--- a/drivers/vdpa/mlx5/meson.build
+++ b/drivers/vdpa/mlx5/meson.build
@@ -8,7 +8,7 @@ if not is_linux
endif
deps += ['hash', 'common_mlx5', 'vhost', 'pci', 'eal', 'sched']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
# avoid referencing undefined variables from common/mlx5
subdir_done()
endif
--
2.36.1
next prev parent reply other threads:[~2022-11-07 16:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 9:05 DPDK main build is broken for me in net/mlx5 if I disable common/mlx5 Andrew Rybchenko
2022-10-29 23:17 ` [PATCH 0/2] fix build disabling common/mlx5 Thomas Monjalon
2022-10-29 23:17 ` [PATCH 1/2] net/mlx5: fix disabling common/mlx5 dependency Thomas Monjalon
2022-10-29 23:17 ` [PATCH 2/2] common/mlx5: move Meson config initialization and check Thomas Monjalon
2022-10-30 7:34 ` [PATCH 0/2] fix build disabling common/mlx5 Andrew Rybchenko
2022-10-30 8:27 ` [PATCH v2 " Thomas Monjalon
2022-10-30 8:27 ` [PATCH v2 1/2] common/mlx5: fix build disabling Thomas Monjalon
2022-10-30 9:16 ` Matan Azrad
2022-11-02 12:10 ` Bruce Richardson
2022-11-02 12:29 ` Thomas Monjalon
2022-11-02 13:14 ` Bruce Richardson
2022-11-02 13:17 ` Thomas Monjalon
2022-11-07 16:37 ` Thomas Monjalon [this message]
2022-11-07 17:07 ` [PATCH] common/mlx5: use build configuration dictionary Bruce Richardson
2022-11-08 7:51 ` David Marchand
2022-11-14 10:31 ` David Marchand
2022-10-30 8:27 ` [PATCH v2 2/2] common/mlx5: move Meson config initialization and check Thomas Monjalon
2022-10-30 9:16 ` Matan Azrad
2022-10-30 9:14 ` [PATCH v2 0/2] fix build disabling common/mlx5 David Marchand
2022-10-30 11:08 ` [PATCH v3 " Thomas Monjalon
2022-10-30 11:08 ` [PATCH v3 1/2] common/mlx5: fix build disabling Thomas Monjalon
2022-10-30 13:33 ` Alex Vesker
2022-10-30 11:08 ` [PATCH v3 2/2] common/mlx5: move build config initialization and check Thomas Monjalon
2022-10-30 13:34 ` Alex Vesker
2022-10-30 15:12 ` [PATCH v3 0/2] fix build disabling common/mlx5 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107163720.4157535-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=ashish.gupta@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=royzhang1980@gmail.com \
--cc=valex@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).