From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0895EA00C4;
	Mon,  7 Nov 2022 17:37:35 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E4F0640156;
	Mon,  7 Nov 2022 17:37:34 +0100 (CET)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 109E440041
 for <dev@dpdk.org>; Mon,  7 Nov 2022 17:37:34 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 97B3C5C018B;
 Mon,  7 Nov 2022 11:37:31 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Mon, 07 Nov 2022 11:37:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm1; t=1667839051; x=1667925451; bh=Oe
 j3Pmmc8euxJVoCbARQTgqbh7TLlubRV4GkalOfbfE=; b=XIQWG3c7JvXKEckcvh
 HPn2Np0W9/Y+tWeVdRGtS4jl7mPZg5bxu5fU4X6eJU8PEjaqDGwsQB1XVXv16OuE
 O0TfLS9wjuBL+/JoyAhHVK29EZMIiMSf392QznsKNVTz0ws9MMniIUcBi0v4Xu+d
 4ZSdnWpwuW4hCjjWx8rsaXCbyWUKppgDI7SOAr6EMCRoiv4hcqv2GnTOiKWrtJa5
 KDAH17zjbVwLGKkGVmNDYJ91BvkLWczKcsXBSsg5ET7Guyt+dR5AvA6FKZh+bZ2c
 neaG1kQ95oaEema93XPAb+eoM/kpY07RF4puFqlO5Ns6SfT4XakaYm5Jw+Kz/k4m
 AsOA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
 :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; t=1667839051; x=1667925451; bh=Oej3Pmmc8euxJ
 VoCbARQTgqbh7TLlubRV4GkalOfbfE=; b=oCtv+W4wfHH6+Lu2LKQkiRgfw7PfS
 THxCQiLgkpFg2WcCJNmQtHt1alwJEy9w21vKrvsbhrJ7iX60SQdEVehflzAqP/4C
 zy3j47ARxw7x5T3p1rJzqoJxsQl64sOz0EVS0nFriosMjS64s6Q8LhWSOWCBmPq7
 4jgrcaKrVQn7+kFk+Ml2DH3NzAqNDZUErKpt7bs9BzRLD5N2KYnYB+l2vQ1hAQ8F
 X09WZs8pQ/BRZ7MMwTJ2zTdBpXGpBRPhhUnIwWXuMZFRk+nwWqJKm31zjq9zd4cl
 EuG4OmBnh46cyxY5ck73x6wazF1YCGoNPmm8ZdbIeeIL9t1e0aTzjheqw==
X-ME-Sender: <xms:SzRpY7Ut0OVdOigT0cCbgBdfca10NaXZj4GzIX9ta1IAG6Fathhrmw>
 <xme:SzRpYzkwhkPSHrBQUmCpGI-xRcQTuzF1yotiT-IeOEgFPMBJPUzSKgqf7IJeqmEIk
 IVnmAfsRz0T86gKXg>
X-ME-Received: <xmr:SzRpY3YWYikBSB5bww5Gz8C8FKSx9bpFUA88Vr0ExU-zf0od1h3c7NRsms8d4_WncYitUoey7OrsCruLEA2ibtPM-94uhfU>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdekgdeklecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek
 hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:SzRpY2UAnQwVFX58YNdXK3msf8C8wSnDlpfUsPPKc7YaSgRyFEF2Hg>
 <xmx:SzRpY1mtk5w1zfjuKxTZuz-u0sEtyBvElhH3u6iHZ4FHDdnvUarDFw>
 <xmx:SzRpYzdhkdWPhUWAhPKhjQ0TM_lmABzsxDvl8t9TCSJRWG_LYXH4dQ>
 <xmx:SzRpY7U6sF0UffyOOK8SFXHWmHOc2YPasLBbS43864ScZGFnZcig9Q>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 7 Nov 2022 11:37:30 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 Matan Azrad <matan@nvidia.com>, Fan Zhang <royzhang1980@gmail.com>,
 Ashish Gupta <ashish.gupta@marvell.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,
 Alex Vesker <valex@nvidia.com>, David Marchand <david.marchand@redhat.com>
Subject: [PATCH] common/mlx5: use build configuration dictionary
Date: Mon,  7 Nov 2022 17:37:20 +0100
Message-Id: <20221107163720.4157535-1-thomas@monjalon.net>
X-Mailer: git-send-email 2.36.1
In-Reply-To: <Y2JtJyOovaJXACdr@bricha3-MOBL.ger.corp.intel.com>
References: <Y2JtJyOovaJXACdr@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

A recent commit added an explicit dependency check on common/mlx5.
For consistency, query dpdk_conf instead of the list of common drivers.
The lists *_drivers should be used only for printing.

Fixes: 3df380f61797 ("common/mlx5: fix disabling build")

Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/compress/mlx5/meson.build | 2 +-
 drivers/crypto/mlx5/meson.build   | 2 +-
 drivers/net/mlx5/meson.build      | 2 +-
 drivers/regex/mlx5/meson.build    | 2 +-
 drivers/vdpa/mlx5/meson.build     | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/compress/mlx5/meson.build b/drivers/compress/mlx5/meson.build
index 49ce3aff46..df4f79fa7e 100644
--- a/drivers/compress/mlx5/meson.build
+++ b/drivers/compress/mlx5/meson.build
@@ -9,7 +9,7 @@ endif
 
 fmt_name = 'mlx5_compress'
 deps += ['common_mlx5', 'eal', 'compressdev']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
     # avoid referencing undefined variables from common/mlx5
     subdir_done()
 endif
diff --git a/drivers/crypto/mlx5/meson.build b/drivers/crypto/mlx5/meson.build
index 7521c4c671..7e32095695 100644
--- a/drivers/crypto/mlx5/meson.build
+++ b/drivers/crypto/mlx5/meson.build
@@ -9,7 +9,7 @@ endif
 
 fmt_name = 'mlx5_crypto'
 deps += ['common_mlx5', 'eal', 'cryptodev']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
     # avoid referencing undefined variables from common/mlx5
     subdir_done()
 endif
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index f1aab18f82..abd507bd88 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -9,7 +9,7 @@ if not (is_linux or is_windows)
 endif
 
 deps += ['hash', 'common_mlx5']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
     # avoid referencing undefined variables from common/mlx5
     subdir_done()
 endif
diff --git a/drivers/regex/mlx5/meson.build b/drivers/regex/mlx5/meson.build
index 70edc5b6da..87404101b9 100644
--- a/drivers/regex/mlx5/meson.build
+++ b/drivers/regex/mlx5/meson.build
@@ -8,7 +8,7 @@ if not is_linux
 endif
 
 deps += ['common_mlx5', 'eal', 'regexdev']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
     # avoid referencing undefined variables from common/mlx5
     subdir_done()
 endif
diff --git a/drivers/vdpa/mlx5/meson.build b/drivers/vdpa/mlx5/meson.build
index 54a4eac6f4..e224d1bcc9 100644
--- a/drivers/vdpa/mlx5/meson.build
+++ b/drivers/vdpa/mlx5/meson.build
@@ -8,7 +8,7 @@ if not is_linux
 endif
 
 deps += ['hash', 'common_mlx5', 'vhost', 'pci', 'eal', 'sched']
-if not ('mlx5' in common_drivers)
+if not dpdk_conf.has('RTE_COMMON_MLX5')
     # avoid referencing undefined variables from common/mlx5
     subdir_done()
 endif
-- 
2.36.1