[PATCH v1 0/1] baseband/acc100: fix for RC2

[PATCH v1 0/1] baseband/acc100: fix for RC2

[Nicolas Chautru]

Bug introduced in 22.11. The change to padding can lead to
reporting input size mismatch which is not a problem and
should not be considered as an error.

Nicolas Chautru (1):
  baseband/acc100: fix to input error related to padding

 drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.37.1

[PATCH v1 1/1] baseband/acc100: fix to input error related to padding

[Nicolas Chautru]

Previous commit includes some padding for some cases,
which may cause input warning from the HW
which should be safely ignored to avoid false alarm.

Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index 96daef87bc..ba8247d47e 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
 	/* Clearing status, it will be set based on response */
 	op->status = 0;
 
-	op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
 	op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 	op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 
@@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
 		rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n",
 				desc, rsp.val, descs_in_tb, desc->req.numCBs);
 
-		op->status |= ((rsp.input_err)
-				? (1 << RTE_BBDEV_DATA_ERROR) : 0);
 		op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 		op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
 
-- 
2.37.1

RE: [EXT] [PATCH v1 1/1] baseband/acc100: fix to input error related to padding

[Akhil Goyal]

> Previous commit includes some padding for some cases,
> which may cause input warning from the HW
> which should be safely ignored to avoid false alarm.
> 
> Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
Applied to dpdk-next-crypto.

Re: [PATCH v1 1/1] baseband/acc100: fix to input error related to padding

[Maxime Coquelin]

On 11/8/22 00:45, Nicolas Chautru wrote:
> Previous commit includes some padding for some cases,
> which may cause input warning from the HW
> which should be safely ignored to avoid false alarm.
> 
> Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function")
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index 96daef87bc..ba8247d47e 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -3779,7 +3779,6 @@ dequeue_enc_one_op_cb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
>   	/* Clearing status, it will be set based on response */
>   	op->status = 0;
>   
> -	op->status |= ((rsp.input_err) ? (1 << RTE_BBDEV_DATA_ERROR) : 0);
>   	op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>   	op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>   
> @@ -3853,8 +3852,6 @@ dequeue_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op **ref_op,
>   		rte_bbdev_log_debug("Resp. desc %p: %x descs %d cbs %d\n",
>   				desc, rsp.val, descs_in_tb, desc->req.numCBs);
>   
> -		op->status |= ((rsp.input_err)
> -				? (1 << RTE_BBDEV_DATA_ERROR) : 0);
>   		op->status |= ((rsp.dma_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>   		op->status |= ((rsp.fcw_err) ? (1 << RTE_BBDEV_DRV_ERROR) : 0);
>   

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime