From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
To: <dev@dpdk.org>
Cc: <matan@nvidia.com>, <rasland@nvidia.com>, <valex@nvidia.com>
Subject: [PATCH v2] net/mlx5/hws: fix timestamp format on Tx queue creation
Date: Wed, 9 Nov 2022 09:57:53 +0200 [thread overview]
Message-ID: <20221109075753.2449-1-viacheslavo@nvidia.com> (raw)
In-Reply-To: <20221108185650.15489-1-viacheslavo@nvidia.com>
The NIC since 6DX supports multiple timestamp formats
in CQEs configured via firmware. If real time timestamp
format has been configured the correct attributes should
be specified on queue creation via DevX. These attributes
setting was missed on steering queue creation and hardware
steering initialization failed.
Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_cmd.c | 4 ++++
drivers/net/mlx5/hws/mlx5dr_cmd.h | 2 ++
drivers/net/mlx5/hws/mlx5dr_send.c | 4 ++++
3 files changed, 10 insertions(+)
v1:
- http://patches.dpdk.org/project/dpdk/patch/20221108185650.15489-1-viacheslavo@nvidia.com/
v2:
- minor style changes
- removed unnessesary variables
diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c
index da8cc3d265..721376b8da 100644
--- a/drivers/net/mlx5/hws/mlx5dr_cmd.c
+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c
@@ -674,6 +674,7 @@ mlx5dr_cmd_sq_create(struct ibv_context *ctx,
MLX5_SET(sqc, sqc, cqn, attr->cqn);
MLX5_SET(sqc, sqc, flush_in_error_en, 1);
MLX5_SET(sqc, sqc, non_wire, 1);
+ MLX5_SET(sqc, sqc, ts_format, attr->ts_format);
MLX5_SET(wq, wqc, wq_type, MLX5_WQ_TYPE_CYCLIC);
MLX5_SET(wq, wqc, pd, attr->pdn);
MLX5_SET(wq, wqc, uar_page, attr->page_id);
@@ -763,6 +764,9 @@ int mlx5dr_cmd_query_caps(struct ibv_context *ctx,
MLX5_GET64(query_hca_cap_out, out,
capability.cmd_hca_cap.match_definer_format_supported);
+ caps->sq_ts_format = MLX5_GET(query_hca_cap_out, out,
+ capability.cmd_hca_cap.sq_ts_format);
+
MLX5_SET(query_hca_cap_in, in, op_mod,
MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE_2 |
MLX5_HCA_CAP_OPMOD_GET_CUR);
diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h
index 2548b2b238..2b3b47f473 100644
--- a/drivers/net/mlx5/hws/mlx5dr_cmd.h
+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h
@@ -121,6 +121,7 @@ struct mlx5dr_cmd_sq_create_attr {
uint32_t dbr_id;
uint32_t wq_id;
uint32_t log_wq_sz;
+ uint32_t ts_format;
};
struct mlx5dr_cmd_query_ft_caps {
@@ -159,6 +160,7 @@ struct mlx5dr_cmd_query_caps {
uint32_t eswitch_manager_vport_number;
uint8_t log_header_modify_argument_granularity;
uint8_t log_header_modify_argument_max_alloc;
+ uint8_t sq_ts_format;
uint64_t definer_format_sup;
uint32_t trivial_match_definer;
char fw_ver[64];
diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c
index 1e9953a38f..5c8bbe6fc6 100644
--- a/drivers/net/mlx5/hws/mlx5dr_send.c
+++ b/drivers/net/mlx5/hws/mlx5dr_send.c
@@ -492,6 +492,10 @@ static int mlx5dr_send_ring_create_sq_obj(struct mlx5dr_context *ctx,
attr.dbr_id = sq->db_umem->umem_id;
attr.wq_id = sq->buf_umem->umem_id;
attr.log_wq_sz = log_wq_sz;
+ if (ctx->caps->sq_ts_format == MLX5_HCA_CAP_TIMESTAMP_FORMAT_FR)
+ attr.ts_format = MLX5_QPC_TIMESTAMP_FORMAT_FREE_RUNNING;
+ else
+ attr.ts_format = MLX5_QPC_TIMESTAMP_FORMAT_DEFAULT;
sq->obj = mlx5dr_cmd_sq_create(ctx->ibv_ctx, &attr);
if (!sq->obj)
--
2.18.1
next prev parent reply other threads:[~2022-11-09 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 18:56 [PATCH] " Viacheslav Ovsiienko
2022-11-09 7:57 ` Viacheslav Ovsiienko [this message]
2022-11-09 9:55 ` [PATCH v2] " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109075753.2449-1-viacheslavo@nvidia.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=valex@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).